{
 "number": 34872,
 "input_hash": "a72bca589ed9f040",
 "model": "openrouter/google/gemini-3.8-flash",
 "batch": false,
 "created": "2026-09-17T16:18:27+00:00",
 "provider": "Google",
 "stop_reason": "end_turn",
 "usage": {
  "input_tokens": 25854,
  "cache_creation_input_tokens": 0,
  "cache_read_input_tokens": 0,
  "output_tokens": 3431
 },
 "cost_usd": 0.03225675,
 "error": null,
 "result": {
  "display": {
   "goal": [
    "Report mixed-input transactions safely and honestly in wallet history RPCs.",
    "Prevent bogus negative fees and false recipient attributions when external inputs are present."
   ],
   "reviewability": [
    "Needs rebase and author response to review comments.",
    "The author has been inactive for over two months."
   ],
   "agreement": [
    "Initial NACK against omitting send entries addressed by adding aggregate sends (achow101).",
    "Concept support for the conservative fallback model (rkrux, murchandamus).",
    "Inline feedback on terminology and zero-value input handling awaiting author response (murchandamus)."
   ],
   "categories": [
    {
     "name": "wallet",
     "why": [
      "P3 because it fixes misleading transaction history and bogus negative fees for collaborative transactions (#14136).",
      "It provides a sound fallback for CoinJoin and Payjoin users without requiring external metadata."
     ]
    }
   ]
  },
  "summary": "This pull request updates wallet history accounting in `gettransaction`, `listtransactions`, and `listsinceblock` for transactions with mixed wallet and foreign inputs. When transactions contain foreign inputs of unknown or nonzero value, the wallet omits speculative per-output sends and fees, reporting an aggregate debit entry and exposing mixed-input metadata instead.",
  "problem": "When a wallet transaction spends both wallet-owned and foreign inputs (such as CoinJoins or Payjoins), the wallet currently treats all outputs as sent by the wallet and calculates nonsensical or negative fees, misrepresenting transaction history to users.",
  "discussion": {
   "open_concerns": [
    "Clarification of 'attributable' terminology and RPC documentation descriptions.",
    "Handling and identification of known zero-value inputs such as ephemeral P2A anchors.",
    "Merge conflicts with multiple wallet PRs."
   ],
   "resolved_concerns": [
    "Original proposal completely omitted send entries for mixed-input transactions, which was rejected; resolved by reporting an aggregate debit send entry."
   ],
   "author_status": "silent since 2026-07-08; pinged for rebase on 2026-09-09"
  },
  "reviewability": {
   "state": "Stale",
   "label": "Needs rebase",
   "reason": "The branch has merge conflicts with master and the author has been silent for 71 days following review comments."
  },
  "agreement": {
   "state": "Positive",
   "summary": "achow101 NACKed omitting send entries, addressed by adding aggregate sends; rkrux and murchandamus support the reworked approach.",
   "reason": "The author addressed achow101's objection by retaining an aggregate send entry. Reviewers rkrux and murchandamus expressed concept support for the fallback approach, with murchandamus leaving constructive inline review comments.",
   "evidence": [
    "achow101 NACKed omitting send entries entirely on 2026-05-19",
    "w0xlt force-pushed a reworked approach on 2026-05-20 reporting aggregate sends",
    "rkrux Concept ACKed the reworked approach on 2026-05-21",
    "murchandamus reviewed on 2026-07-15 calling it a 'great improvement' while requesting clarifications"
   ]
  },
  "dependencies": {
   "depends_on": [],
   "enables": []
  },
  "categories": [
   {
    "name": "docs",
    "member": false,
    "evidence": "Release notes change is secondary to the wallet accounting modification.",
    "band": "Unranked",
    "reason_tag": "",
    "score": 0.0,
    "factors": {
     "security_stability": 0,
     "bug_severity": 0,
     "performance": 0,
     "user_value": 0,
     "leverage": 0
    },
    "rationale": "Documentation updates here are accompanying release notes for a wallet change."
   },
   {
    "name": "tests",
    "member": false,
    "evidence": "Functional test changes specifically verify wallet mixed-input history RPC behavior.",
    "band": "Unranked",
    "reason_tag": "",
    "score": 0.0,
    "factors": {
     "security_stability": 0,
     "bug_severity": 0,
     "performance": 0,
     "user_value": 0,
     "leverage": 0
    },
    "rationale": "Tests pin domain-specific behavior in the wallet rather than modifying test infrastructure."
   },
   {
    "name": "wallet",
    "member": true,
    "evidence": "Modifies wallet transaction caching, input ownership detection, and history accounting RPCs.",
    "band": "P3",
    "reason_tag": "bug fix",
    "score": 0.38,
    "factors": {
     "security_stability": 0,
     "bug_severity": 2,
     "performance": 0,
     "user_value": 2,
     "leverage": 0
    },
    "rationale": "Fixes a long-standing bug (#14136) where wallet history RPCs report incorrect negative fees and fabricate send entries for collaborative transactions. While important for users participating in CoinJoins or Payjoins, it affects a non-standard transaction flow and is reasonably deferrable."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": [],
  "card": "This PR fixes wallet history reporting in gettransaction, listtransactions, and listsinceblock for mixed-input transactions such as CoinJoins and Payjoins (#14136). When non-wallet inputs cannot be proven to contribute zero value, the wallet replaces misleading per-output send entries and negative fee calculations with an aggregate debit summary and mixed-input metadata. The author resolved an early objection against omitting send entries entirely, gaining concept support from rkrux and murchandamus. The PR is currently stale, needing a rebase and author responses to inline comments from July."
 },
 "raw_text": null
}