{
 "number": 35317,
 "input_hash": "4de123efde0c48e9",
 "model": "openrouter/google/gemini-3.8-flash",
 "batch": false,
 "created": "2026-09-17T15:52:41+00:00",
 "provider": "Google",
 "stop_reason": "end_turn",
 "usage": {
  "input_tokens": 15879,
  "cache_creation_input_tokens": 0,
  "cache_read_input_tokens": 0,
  "output_tokens": 5168
 },
 "cost_usd": 0.03128925,
 "error": null,
 "result": {
  "display": {
   "goal": [
    "Fix fundrawtransaction and walletcreatefundedpsbt silently ignoring the subtract_fee_from_outputs option",
    "Support and document snake_case option names consistently across wallet funding RPCs"
   ],
   "reviewability": [
    "Stale because the author has been inactive for 85 days after offering to close the PR"
   ],
   "agreement": [
    "No support for merging this piecemeal fix directly",
    "Reviewers prefer a unified transition to snake_case across all RPCs rather than one-off aliases (achow101)",
    "Reviewers favored closing this PR in favor of a tracking issue (sedited, maflcko)"
   ],
   "categories": [
    {
     "name": "wallet",
     "why": [
      "P3 because it fixes a silent defect where specifying subtract_fee_from_outputs leaves output values unadjusted and charges fees to the sender.",
      "The severity is limited because callers using the documented camelCase spelling are unaffected."
     ]
    },
    {
     "name": "rpc",
     "why": [
      "Unranked because parameter handling in wallet RPCs is covered by the wallet category."
     ]
    }
   ]
  },
  "summary": "This PR updates `fundrawtransaction` and `walletcreatefundedpsbt` to accept `subtract_fee_from_outputs` in addition to `subtractFeeFromOutputs` when building transaction recipients. Previously, the option was accepted during option parsing but silently ignored during recipient construction. It also adds snake_case funding options to RPC help documentation and client conversion tables.",
  "problem": "Callers passing the snake_case option `subtract_fee_from_outputs` to wallet funding RPCs have their option silently ignored, causing transaction recipients to receive full amounts and fees to be paid from wallet inputs instead.",
  "discussion": {
   "open_concerns": [
    "Reviewers prefer a unified approach to standardize all RPC argument handling to snake_case with deprecation of camelCase, rather than piecemeal aliases",
    "Reviewers suggested closing this PR in favor of a tracking issue or comprehensive overhaul"
   ],
   "resolved_concerns": [
    "RPC help text was updated to include snake_case option aliases and client conversion parameters were added"
   ],
   "author_status": "silent since 2026-06-24 after asking whether to close the PR"
  },
  "reviewability": {
   "state": "Stale",
   "label": "Author silent 85d",
   "reason": "The author has been inactive for 85 days after asking if the PR should be closed in favor of an issue."
  },
  "agreement": {
   "state": "Mild",
   "summary": "Reviewers favor a unified snake_case transition across all RPCs instead of piecemeal fixes; reviewers suggested closing in favor of an issue.",
   "reason": "There is no objection to fixing the bug itself, but reviewers prefer a comprehensive overhaul of RPC option naming across the codebase rather than adding aliases to individual wallet RPCs.",
   "evidence": [
    "achow101 suggested that argument handling across all RPCs should be unified to snake_case with deprecation of camelCase args rather than piecemeal changes",
    "sedited agreed that closing the PR in favor of an issue would be preferred",
    "maflcko pointed out existing tracking work on naming consistency and suggested a linter approach"
   ]
  },
  "dependencies": {
   "depends_on": [],
   "enables": []
  },
  "categories": [
   {
    "name": "wallet",
    "member": true,
    "evidence": "Modifies wallet RPC funding logic and recipient construction in src/wallet/rpc/spend.cpp.",
    "band": "P3",
    "reason_tag": "bug fix",
    "score": 0.35,
    "factors": {
     "security_stability": 0,
     "bug_severity": 1,
     "performance": 0,
     "user_value": 1,
     "leverage": 0
    },
    "rationale": "Fixes a bug where passing snake_case subtract_fee_from_outputs is accepted by parameter validation but ignored when calculating recipient amounts. The impact is relatively low because callers using the documented camelCase parameter work as expected."
   },
   {
    "name": "rpc",
    "member": false,
    "evidence": "Wallet RPC changes belong to the wallet category unless modifying the shared RPC framework itself.",
    "band": "Unranked",
    "reason_tag": "",
    "score": 0.0,
    "factors": {
     "security_stability": 0,
     "bug_severity": 0,
     "performance": 0,
     "user_value": 0,
     "leverage": 0
    },
    "rationale": "Updating parameter conversion tables in client.cpp for wallet RPC options is mechanical follow-up to wallet RPC logic."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": [],
  "card": "This PR updates fundrawtransaction and walletcreatefundedpsbt so that the snake_case subtract_fee_from_outputs option is honored instead of silently ignored when constructing recipients. It also exposes snake_case aliases in RPC help and adds them to client conversion tables. The bug causes unintended fee deduction behavior when callers supply snake_case options, but reviewers generally prefer a unified naming transition across all RPCs rather than one-off alias additions. Reviewers suggested closing the PR in favor of an issue, and the author has been inactive for 85 days."
 },
 "raw_text": null
}