{
 "number": 36373,
 "input_hash": "00b7c5793be2bea1",
 "model": "ledger",
 "prompt_hash": null,
 "created": "2026-10-09T01:20:00+00:00",
 "result": {
  "summary": "Logs the symlink-resolved canonical path of the active data directory during node startup logging. The resolved path is printed unconditionally on a separate line immediately following the configured data directory line.",
  "problem": "When the data directory or its parent paths contain symlinks, startup logs only print the configured path. Users and developers analyzing saved debug.log files cannot verify the actual underlying storage device or directory used during that run.",
  "card": "Logs the symlink-resolved canonical data directory during node startup immediately after the configured path. This makes saved debug.log files reflect the physical storage directory used when running bitcoind via symlinked paths. The author notes this assists benchmarking across different storage media when wrapper scripts prevent modifying startup flags. No dependencies.",
  "evidence": [
   "Author description: 'I've been testing a potential performance PR across different data directories (for example, SSD versus HDD). After each run, I save the debug.log file. It would be nice if the debug.log file showed which data directory was used for that run.'",
   "Author description: 'If a script starts bitcoind (e.g., on an RPi with a whole infrastructure, like Umbrel or myNode), changing the startup command arguments may be inconvenient or not even possible. It's easy to change the default directory to be a symlink. But in that case, debug.log doesn't show where the actual data directory is located.'"
  ],
  "scope_notes": "",
  "changed_since_previous": "The new version unconditionally logs the 'Resolved data directory' line on every startup instead of only printing it when the canonical path differs from the configured path, ensuring log parsers can rely on the line being present.",
  "thread": {
   "last_event_at": "2026-10-08T14:13:35Z",
   "events": 2,
   "head_sha": "21e37651cc065fe07f02f29d3d610f2e87498bce",
   "schema_floor": 2,
   "schema": 2
  },
  "waiting_on": [
   {
    "at": "2026-10-08",
    "id": "rc:4220032086",
    "on": "reviewer",
    "url": "https://github.com/bitcoin/bitcoin/pull/36373#discussion_r4220032086",
    "what": "input from reviewers on whether logging the resolved datadir line should be conditional or always printed"
   }
  ],
  "risk": {
   "level": "low",
   "touches": [],
   "why": "Touches only startup logging using standard filesystem canonicalization with an error code fallback."
  },
  "discussion": {
   "author_status": "last statement processed 2026-10-08",
   "open_concerns": [],
   "resolved_concerns": [
    "l0rinc: asks if this is part of a broader effort to improve symlink support (answered by LarryRuane 2026-10-08)",
    "l0rinc: avoid logging two separate lines for the same directory when it is not a symlink (answered by LarryRuane 2026-10-08)"
   ]
  },
  "reviewability": {
   "state": "Ready",
   "label": "Ready",
   "reason": "Nothing known that would invalidate a review now."
  },
  "agreement": {
   "state": "Crickets",
   "summary": "Crickets: no substantive comment either way",
   "reason": "Initial review by l0rinc questioned scope and suggested avoiding duplicate log lines when paths match. The author clarified scope and is awaiting further reviewer feedback before deciding whether to make the log line conditional.",
   "evidence": [],
   "objections": [
    {
     "reviewer": "l0rinc",
     "association": "MEMBER",
     "type": "question",
     "kind": "scope",
     "harm": "",
     "request": "",
     "question": "asks if this is part of a broader effort to improve symlink support",
     "text": "asks if this is part of a broader effort to improve symlink support",
     "clears_with": "answer",
     "blocking": false,
     "status": "answered",
     "status_note": "author replied that it is a self-contained PR, not part of a broader effort",
     "cleared": true,
     "author_replied": true,
     "others_replied": false,
     "fix_pushed": false,
     "replies": [
      "rc:4220032086"
     ],
     "evidence": "2026-10-08: 'Is this part of a broader effort to improve symlink support?'",
     "url": "https://github.com/bitcoin/bitcoin/pull/36373#discussion_r4213659555",
     "id": "rc:4213659555",
     "at": "2026-10-08",
     "status_at": "2026-10-08",
     "status_by": "LarryRuane",
     "resolution_evidence": "2026-10-08: LarryRuane: 'No, I'm not thinking this is part of a broader effort to improve symlink support.'",
     "pin": null,
     "from_schema": 2
    },
    {
     "reviewer": "l0rinc",
     "association": "MEMBER",
     "type": "suggestion",
     "kind": "interface",
     "harm": "",
     "request": "avoid logging two separate lines for the same directory when it is not a symlink",
     "question": "",
     "text": "avoid logging two separate lines for the same directory when it is not a symlink",
     "clears_with": "answer",
     "blocking": false,
     "status": "answered",
     "status_note": "author explained the scripting rationale, stated openness to making it conditional, and asked to wait for more opinions",
     "cleared": true,
     "author_replied": true,
     "others_replied": false,
     "fix_pushed": false,
     "replies": [
      "rc:4220032086"
     ],
     "evidence": "2026-10-08: 'I wouldn't want to see two separate log lines for the exact same folder in 99% of cases.'",
     "url": "https://github.com/bitcoin/bitcoin/pull/36373#discussion_r4213659555",
     "id": "rc:4213659555#2",
     "at": "2026-10-08",
     "status_at": "2026-10-08",
     "status_by": "LarryRuane",
     "resolution_evidence": "2026-10-08: LarryRuane: 'I can make the logging of that Resolved line conditional so it doesn't print the same path as the Using line, maybe I'll wait for a few more opinions.'",
     "pin": null,
     "from_schema": 2
    }
   ],
   "support": [],
   "participants": [
    {
     "login": "l0rinc",
     "stance": "question",
     "note": "asked whether this is part of broader symlink support and preferred not having redundant log lines",
     "association": "MEMBER",
     "comments": 1,
     "first": "2026-10-08",
     "last": "2026-10-08"
    }
   ],
   "derivation": "no substantive comment either way",
   "model_state": null,
   "corrections": [],
   "notes": "Initial review by l0rinc questioned scope and suggested avoiding duplicate log lines when paths match. The author clarified scope and is awaiting further reviewer feedback before deciding whether to make the log line conditional."
  },
  "dependencies": {
   "depends_on": [],
   "enables": []
  },
  "categories": [
   {
    "name": "utils",
    "member": true,
    "evidence": "Touches node startup logging in src/init/common.cpp by logging the symlink-resolved data directory path.",
    "band": "P4",
    "reason_tag": "user request",
    "score": 0.15,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 0,
     "user_value": 1
    },
    "rationale": "Adds an informational startup log line displaying the resolved canonical datadir path. While convenient for analyzing debug logs when symlinks are involved ('shows which data directory was used for that run'), it is a minor diagnostic logging improvement with no effect on node behavior or stability."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": []
 },
 "cost_usd": 0.0,
 "source": {
  "record": "2026-10-09T01:20:00+00:00",
  "code": "2026-10-09T01:21:56+00:00",
  "judgments": 1
 }
}