{
 "number": 36488,
 "input_hash": "182e5b7ee302b93a",
 "model": "ledger",
 "prompt_hash": null,
 "created": "2026-10-27T01:27:30+00:00",
 "result": {
  "summary": "Gates the legacy mixed-case `confTarget` option in wallet `bumpfee` and `psbtbumpfee` RPCs behind `-deprecatedrpc=confTarget`. Using the option without the deprecation flag now returns an `RPC_METHOD_DEPRECATED` error ahead of planned removal in the next cycle.",
  "problem": "The wallet fee-bump RPCs maintain support for an undocumented legacy `confTarget` option alongside `conf_target`, leaving lingering naming inconsistencies and duplicate parameter handling.",
  "card": "Gates the legacy mixed-case confTarget option in bumpfee and psbtbumpfee behind -deprecatedrpc=confTarget ahead of complete removal in the next release. The snake_case conf_target parameter has been documented and accepted since 2020, but the camelCase alias remained active. External RPC callers still using confTarget will receive a deprecation error unless the deprecation flag is set.",
  "evidence": [
   "PR description: 'Since commit 91f6d2bc8ff4d4cd1b86daa370ec9d2d9662394d in 2020, the wallet accepts and documents conf_target for the fee bump RPC. So it seems time to cut the confusion and properly deprecate it with the next cycle.'"
  ],
  "scope_notes": "",
  "changed_since_previous": "No functional changes; the concrete implementation adds the `-deprecatedrpc=confTarget` check in `bumpfee_helper`, functional test assertions, and release notes.",
  "thread": {
   "last_event_at": "2026-10-26T09:03:48Z",
   "events": 2,
   "head_sha": "fab22ac42e350d4b4481515fe8ba2a319a744389",
   "schema_floor": 2,
   "schema": 2
  },
  "waiting_on": [
   {
    "at": "2026-10-26",
    "id": "c:6412201138",
    "on": "reviewer",
    "url": "https://github.com/bitcoin/bitcoin/pull/36488#issuecomment-6412201138",
    "what": "fametrano to review author's reply declining the test suggestion"
   }
  ],
  "risk": {
   "level": "medium",
   "touches": [
    "wallet",
    "rpc_api"
   ],
   "why": "RPC clients still passing the confTarget option without upgrading to conf_target or enabling the deprecation flag will have fee-bump calls fail."
  },
  "discussion": {
   "author_status": "last statement processed 2026-10-26",
   "open_concerns": [],
   "resolved_concerns": [
    "fametrano: Add test coverage exercising that confTarget still works under -deprecatedrpc=confTarget in wallet_bumpfee.py (answered by maflcko 2026-10-26)"
   ]
  },
  "reviewability": {
   "state": "Ready",
   "label": "Ready",
   "reason": "Nothing known that would invalidate a review now."
  },
  "agreement": {
   "state": "Strong",
   "summary": "Strong: substantive support, no open objection (fametrano)",
   "reason": "Author replied to fametrano's suggestion to add functional tests, declining the request.",
   "evidence": [
    "fametrano: Tested ACK \u2014 tested on regtest with and without flag against client library; verified RPC errors, bumping, conflict handling, help, and getopenrpcinfo"
   ],
   "objections": [
    {
     "reviewer": "fametrano",
     "association": "NONE",
     "type": "suggestion",
     "kind": "correctness",
     "harm": "",
     "request": "Add test coverage exercising that confTarget still works under -deprecatedrpc=confTarget in wallet_bumpfee.py",
     "question": "",
     "text": "Add test coverage exercising that confTarget still works under -deprecatedrpc=confTarget in wallet_bumpfee.py",
     "clears_with": "answer",
     "blocking": false,
     "status": "answered",
     "status_note": "author declined adding tests, noting the option was undocumented and rarely used",
     "cleared": true,
     "author_replied": true,
     "others_replied": false,
     "fix_pushed": false,
     "replies": [
      "c:6412201138"
     ],
     "evidence": "2026-10-25: 'One `bumpfee` and one `psbtbumpfee` call with `{\"confTarget\": 6}` in that test would cover it.'",
     "url": "https://github.com/bitcoin/bitcoin/pull/36488#issuecomment-6394558268",
     "id": "c:6394558268",
     "at": "2026-10-25",
     "status_at": "2026-10-26",
     "status_by": "maflcko",
     "resolution_evidence": "2026-10-26: maflcko: 'I don't think it makes sense to add a test for this now'",
     "pin": null,
     "from_schema": 2
    }
   ],
   "support": [
    {
     "reviewer": "fametrano",
     "reason": "tested on regtest with and without flag against client library; verified RPC errors, bumping, conflict handling, help, and getopenrpcinfo",
     "substantive": true,
     "verdict": "Tested ACK",
     "id": "c:6394558268",
     "url": "https://github.com/bitcoin/bitcoin/pull/36488#issuecomment-6394558268",
     "at": "2026-10-25",
     "association": "NONE",
     "evidence": "tested",
     "areas": []
    }
   ],
   "participants": [
    {
     "login": "fametrano",
     "stance": "support",
     "note": "Tested ACK on regtest; suggested adding functional test coverage for confTarget",
     "association": "NONE",
     "comments": 1,
     "first": "2026-10-25",
     "last": "2026-10-25"
    }
   ],
   "derivation": "substantive support, no open objection (fametrano)",
   "model_state": null,
   "corrections": [],
   "notes": "Author replied to fametrano's suggestion to add functional tests, declining the request."
  },
  "dependencies": {
   "depends_on": [],
   "enables": []
  },
  "categories": [
   {
    "name": "docs",
    "member": false,
    "evidence": "Changes doc/release-notes-36488.md solely to document the RPC deprecation introduced by the code change.",
    "band": "Unranked",
    "reason_tag": "cleanup",
    "score": 0.0,
    "factors": {
     "bug_severity": 0,
     "leverage": 1,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "Release notes accompany a code change and do not constitute a standalone documentation change."
   },
   {
    "name": "rpc",
    "member": true,
    "evidence": "Labeled RPC/REST/ZMQ and gates an RPC option behind `-deprecatedrpc=confTarget` in test/functional/rpc_deprecated.py and wallet RPC handlers.",
    "band": "P3",
    "reason_tag": "cleanup",
    "score": 0.35,
    "factors": {
     "bug_severity": 0,
     "leverage": 1,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "Follows standard RPC deprecation discipline by gating the legacy `confTarget` option behind `-deprecatedrpc=confTarget`. PR description notes 'it seems time to cut the confusion and properly deprecate it with the next cycle' after `conf_target` was documented in 2020."
   },
   {
    "name": "wallet",
    "member": true,
    "evidence": "Labeled Wallet and modifies wallet RPC parameter handling in src/wallet/rpc/spend.cpp.",
    "band": "P4",
    "reason_tag": "cleanup",
    "score": 0.2,
    "factors": {
     "bug_severity": 0,
     "leverage": 1,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "Cleans up an undocumented parameter alias in wallet fee-bumping RPCs without altering wallet transaction logic. PR description cites retiring duplicate handling for `confTarget` alongside `conf_target`."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": []
 },
 "cost_usd": 0.0,
 "source": {
  "record": "2026-10-27T01:27:30+00:00",
  "code": "2026-10-11T01:23:34+00:00",
  "judgments": 3
 }
}