{
 "number": 36563,
 "input_hash": "4d2bc568580699c7",
 "model": "ledger",
 "prompt_hash": null,
 "created": "2026-10-21T01:20:50+00:00",
 "result": {
  "summary": "Adds JSON script test vectors covering subtle script execution edge cases. These include witness v0 versus tapscript size limits, OP_SUCCESS evaluation before script limits, witness v0 bypassing FindAndDelete, tapscript signature validation weight budgeting, and limit exemptions for unknown tapleaf versions. It also adds mapping for two script error strings in the test runner.",
  "problem": "The shared JSON script test fixtures omit coverage for several script boundary conditions and upgrade rules. Implementers of alternative Bitcoin software and downstream consumers cannot use the standard fixtures to verify conformant consensus behavior for these specific cases.",
  "card": "Adds JSON script test fixtures covering script validation edge cases developed during rbitcoin's implementation. It tests witness v0 versus tapscript size limits, OP_SUCCESS evaluation before script limits, omission of FindAndDelete in witness v0, tapscript signature weight budgets, and limit exemptions on unknown tapleaf versions. The new test vectors help alternative implementations and downstream projects verify consensus compatibility across subtle boundary conditions. No open dependencies.",
  "evidence": [
   "PR description: 'During rbitcoin's development, we created some additional script test vectors, some of which seem like they would be valuable additions to bitcoin core's script tests.'",
   "Commit messages document concrete gaps covered: 'assert v0 and tapscript size limits', 'assert OP_SUCCESS before script limits', 'assert witness v0 scripts skip FindAndDelete', 'assert tapscript signature weight budget', and 'assert unknown tapleaf versions skip limits'."
  ],
  "scope_notes": "Almost all changes (+194 lines) are JSON test fixture data in `src/test/data/script_tests.json`, accompanied by two error string mappings in `src/test/script_tests.cpp` to enable the runner to parse the expected failures.",
  "changed_since_previous": "",
  "thread": {
   "last_event_at": "2026-10-20T08:39:08Z",
   "events": 4,
   "head_sha": "60bb41f4940c7aa5553d7fe5223e0a9d6d147f5c",
   "schema_floor": 2,
   "schema": 2
  },
  "waiting_on": [
   {
    "at": "2026-10-19",
    "id": "c:6269505393",
    "on": "reviewer",
    "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6269505393",
    "what": "review of the test fixtures from instagibbs or others"
   }
  ],
  "risk": {
   "level": "low",
   "touches": [
    "tests"
   ],
   "why": "Touches only test fixtures and test error string mappings without changing consensus or validation code."
  },
  "discussion": {
   "author_status": "last statement processed 2026-10-20",
   "open_concerns": [],
   "resolved_concerns": [
    "instagibbs: Whether the author will update the PR based on review or add further test cases later (answered by reardencode 2026-10-19)"
   ]
  },
  "reviewability": {
   "state": "Ready",
   "label": "Ready",
   "reason": "Nothing known that would invalidate a review now."
  },
  "agreement": {
   "state": "Crickets",
   "summary": "Crickets: no substantive comment either way",
   "reason": "Added Yudis-bit's Tested ACK on Windows. The comment is excluded from the support list because approvals with no rationale from accounts with no history in the project do not count as support.",
   "evidence": [],
   "objections": [
    {
     "reviewer": "instagibbs",
     "association": "MEMBER",
     "type": "question",
     "kind": "maintenance",
     "harm": "",
     "request": "",
     "question": "Whether the author will update the PR based on review or add further test cases later",
     "text": "Whether the author will update the PR based on review or add further test cases later",
     "clears_with": "answer",
     "blocking": false,
     "status": "answered",
     "status_note": "author confirmed they will address review feedback and submit any future test cases in separate PRs",
     "cleared": true,
     "author_replied": true,
     "others_replied": false,
     "fix_pushed": false,
     "replies": [
      "c:6269505393"
     ],
     "evidence": "2026-10-19: 'are you looking to throw this over the fence or will you update it on review, or are you still going to add stuff later?'",
     "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6268527761",
     "id": "c:6268527761",
     "at": "2026-10-19",
     "status_at": "2026-10-19",
     "status_by": "reardencode",
     "resolution_evidence": "2026-10-19: reardencode: 'Happy to update based on review.'",
     "pin": null,
     "from_schema": 2
    }
   ],
   "support": [],
   "participants": [
    {
     "login": "fanquake",
     "stance": "neutral",
     "note": "tagged instagibbs and darosior for review",
     "association": "MEMBER",
     "comments": 1,
     "first": "2026-10-19",
     "last": "2026-10-19"
    },
    {
     "login": "instagibbs",
     "stance": "question",
     "note": "asked whether author plans to update the PR on review",
     "association": "MEMBER",
     "comments": 1,
     "first": "2026-10-19",
     "last": "2026-10-19"
    },
    {
     "login": "Yudis-bit",
     "stance": "support",
     "note": "Tested ACK on Windows without rationale (account with no project history)",
     "association": "NONE",
     "comments": 1,
     "first": "2026-10-20",
     "last": "2026-10-20"
    }
   ],
   "derivation": "no substantive comment either way",
   "model_state": null,
   "corrections": [],
   "notes": "Added Yudis-bit's Tested ACK on Windows. The comment is excluded from the support list because approvals with no rationale from accounts with no history in the project do not count as support."
  },
  "dependencies": {
   "depends_on": [],
   "enables": []
  },
  "categories": [
   {
    "name": "rpc",
    "member": false,
    "evidence": "Matched keyword 'json' from test fixture filename `src/test/data/script_tests.json`, but changes no RPC, REST, or ZMQ interfaces.",
    "band": "Unranked",
    "reason_tag": "test coverage",
    "score": 0.0,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 1,
     "user_value": 0
    },
    "rationale": "This PR touches unit test fixtures for script validation and does not touch RPC machinery."
   },
   {
    "name": "tools",
    "member": false,
    "evidence": "Matched keyword 'script' referring to Bitcoin Script consensus evaluation rather than command-line tools or contributor scripts.",
    "band": "Unranked",
    "reason_tag": "test coverage",
    "score": 0.0,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 1,
     "user_value": 0
    },
    "rationale": "This PR modifies test fixtures and unit test runners in `src/test/`, not tools or scripts under `contrib/`."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": []
 },
 "cost_usd": 0.0,
 "source": {
  "record": "2026-10-21T01:20:50+00:00",
  "code": "2026-10-20T01:18:47+00:00",
  "judgments": 2
 }
}