{ "number": 36574, "input_hash": "f077134973b082e4", "model": "ledger", "prompt_hash": null, "created": "2026-10-23T01:18:08+00:00", "result": { "summary": "Updates `ci/README.md` to reflect current container environments and CI harness mechanics. It replaces recommendations for an unmaintained QEMU binfmt container with modern Docker-recommended tooling, removes inaccurate claims that numbered CI scripts run sequentially, clarifies how container images and build caches are handled, and documents the policy against universally pinning CI dependencies by hash.", "problem": "Contributors running CI tasks locally or inspecting CI mechanics encounter outdated documentation, including unmaintained QEMU helper images, incorrect explanations of script execution order, and missing context on CI dependency pinning policies.", "card": "Updates ci/README.md to bring local CI setup instructions and harness documentation up to date. It replaces references to an unmaintained multiarch QEMU helper container with current upstream guidance, removes inaccurate descriptions of CI script ordering, clarifies container image and ccache behavior, and adds a section explaining the project's dependency hash pinning policy. This aids contributors attempting to understand or replicate CI environments locally.", "evidence": [ "Commit fabc10bc59 notes: 'docker.io/multiarch/qemu-user-static hasn't been updated in years and the replacement according to the Docker docs is tonistiigi/binfmt.'", "Commit fa5edac158 notes: 'Remove note that scripts are ordered. They are not: 02_run_container.py runs before 01_base_install.sh and some scripts have no number: GetCMakeLogFiles.cmake, wrap-valgrind.py, ...'" ], "scope_notes": "", "changed_since_previous": "The depends cache description references `./depends` instead of `../depends`.", "thread": { "last_event_at": "2026-10-22T12:23:37Z", "events": 8, "head_sha": "faebf98d5bbba0a6b85527f9d86650db7ef7e24a", "schema_floor": 2, "schema": 2 }, "waiting_on": [ { "at": "2026-10-22", "id": "rc:4348252227", "on": "reviewer", "url": "https://github.com/bitcoin/bitcoin/pull/36574#discussion_r4348252227", "what": "l0rinc to consider maflcko's reply regarding docker and dependency pinning" } ], "risk": { "level": "low", "touches": [ "docs" ], "why": "Touches only developer documentation for CI without altering any executable build or test scripts." }, "discussion": { "author_status": "last statement processed 2026-10-22", "open_concerns": [], "resolved_concerns": [ "Hamza1610: Clarify whether path references like ../depends are relative to the ci directory or the project root. (answered by maflcko 2026-10-21)", "l0rinc: The rationale arguing against dependency pinning is incomplete and ignores that pinning prevents silent updates to buggy versions and helps narrow down inconsistencies. (answered by maflcko 2026-10-22)" ] }, "reviewability": { "state": "Ready", "label": "Ready", "reason": "Nothing known that would invalidate a review now." }, "agreement": { "state": "Neutral", "summary": "Neutral: objections settled, nobody has spoken for the PR", "reason": "maflcko replied to l0rinc's pushback in rc:4348252227 arguing docker is an external dependency unrelated to pinning, moving the objection back to answered.", "evidence": [], "objections": [ { "reviewer": "Hamza1610", "association": "NONE", "type": "suggestion", "kind": "interface", "harm": "", "request": "Clarify whether path references like ../depends are relative to the ci directory or the project root.", "question": "", "text": "Clarify whether path references like ../depends are relative to the ci directory or the project root.", "clears_with": "answer", "blocking": false, "status": "answered", "status_note": "author replied that they dropped the change instead of clarifying paths", "cleared": true, "author_replied": true, "others_replied": false, "fix_pushed": false, "replies": [ "c:6311529154" ], "evidence": "2026-10-20: 'I would suggest you clarify on the path references.'", "url": "https://github.com/bitcoin/bitcoin/pull/36574#pullrequestreview-5588813287", "id": "r:5588813287", "at": "2026-10-20", "status_at": "2026-10-21", "status_by": "maflcko", "resolution_evidence": "2026-10-21: maflcko: 'thx, dropped the change instead. Seems better to leave paths as-is.'", "pin": null, "from_schema": 2 }, { "reviewer": "l0rinc", "association": "MEMBER", "type": "objection", "kind": "approach", "harm": "The rationale arguing against dependency pinning is incomplete and ignores that pinning prevents silent updates to buggy versions and helps narrow down inconsistencies.", "request": "", "question": "", "text": "The rationale arguing against dependency pinning is incomplete and ignores that pinning prevents silent updates to buggy versions and helps narrow down inconsistencies.", "clears_with": "answer", "blocking": false, "status": "answered", "status_note": "author replied that the docker issue is an external dependency not managed in this repo and unrelated to pinning", "cleared": true, "author_replied": true, "others_replied": false, "fix_pushed": false, "replies": [ "rc:4334596309", "rc:4334824769", "rc:4348252227" ], "evidence": "2026-10-20: 'I don't agree with this, but I won't block the change. These are all valid statements, but it's not complete.'", "url": "https://github.com/bitcoin/bitcoin/pull/36574#discussion_r4327800240", "id": "rc:4327800240", "at": "2026-10-20", "status_at": "2026-10-22", "status_by": "maflcko", "resolution_evidence": "2026-10-22: maflcko: 'So the docker issue 35202 is unrelated to pinning and the issue would happen again with or without pinning.'", "pin": null, "from_schema": 2 } ], "support": [], "participants": [ { "login": "Hamza1610", "stance": "neutral", "note": "suggested clarifying path references; author answered by dropping the change", "association": "NONE", "comments": 1, "first": "2026-10-20", "last": "2026-10-20" }, { "login": "l0rinc", "stance": "objection", "note": "disagrees with the readme's characterization of dependency pinning", "association": "MEMBER", "comments": 3, "first": "2026-10-20", "last": "2026-10-21" } ], "derivation": "objections settled, nobody has spoken for the PR", "model_state": null, "corrections": [], "notes": "maflcko replied to l0rinc's pushback in rc:4348252227 arguing docker is an external dependency unrelated to pinning, moving the objection back to answered." }, "dependencies": { "depends_on": [], "enables": [] }, "categories": [ { "name": "build", "member": true, "evidence": "Modifies ci/README.md to update container environment recommendations and clarify CI harness mechanics.", "band": "P4", "reason_tag": "cleanup", "score": 0.15, "factors": { "bug_severity": 0, "leverage": 0, "performance": 0, "security_stability": 0, "user_value": 0 }, "rationale": "Updates stale documentation for running CI containers locally. It replaces unmaintained QEMU binfmt container recommendations and corrects notes on script execution order, which has minor value for developers but no impact on CI operation or build integrity." }, { "name": "tests", "member": true, "evidence": "Carries the Tests label and documents how test runners and containers are invoked in CI.", "band": "P4", "reason_tag": "cleanup", "score": 0.1, "factors": { "bug_severity": 0, "leverage": 0, "performance": 0, "security_stability": 0, "user_value": 0 }, "rationale": "Edits documentation explaining CI test harness mechanics without changing test runners or test code. The updates fix minor inaccuracies for developers inspecting test workflows." } ], "confidence": "high", "uncertainties": [], "needs": [] }, "cost_usd": 0.0, "source": { "record": "2026-10-23T01:18:08+00:00", "code": "2026-10-23T01:20:22+00:00", "judgments": 2 } }