{
 "number": 36601,
 "input_hash": "20a5529d6dae73a1",
 "model": "ledger",
 "prompt_hash": null,
 "created": "2026-10-24T01:18:52+00:00",
 "result": {
  "summary": "Replaces usages of EmplaceCoinInternalDANGER with AddCoin and SpendCoin in unit test fixtures for the coin cache. It limits the use of EmplaceCoinInternalDANGER to dedicated fuzz, simulation, and duplicate-insertion tests that explicitly test snapshot coin insertion.",
  "problem": "Coin-cache test fixtures in coins_tests.cpp and coinsviewoverlay_tests.cpp use EmplaceCoinInternalDANGER to set up test state. Because that method is an internal bypass intended strictly for AssumeUTXO snapshot loading, using it in routine test fixtures unnecessarily couples standard cache tests to snapshot-specific mechanisms.",
  "card": "This PR replaces calls to EmplaceCoinInternalDANGER with AddCoin and SpendCoin across several coin cache unit test fixtures. It resolves the misuse of an internal AssumeUTXO snapshot-loading method for standard test fixture setup, keeping routine test coverage cleanly separated from snapshot loading internals. The change follows a review suggestion from PR #35295 and is extracted as an independent prerequisite for PR #36598.",
  "evidence": [
   "Author description notes this decouples standard test fixtures and follows an earlier review suggestion on PR #35295 (discussion_r3421846300).",
   "Author notes this is extracted from PR #36598 to allow independent review."
  ],
  "scope_notes": "Small test-only change (+10/-6 across two test files).",
  "changed_since_previous": "",
  "thread": {
   "last_event_at": "2026-10-23T12:53:49Z",
   "events": 1,
   "head_sha": "1c62336903ccf5f7f2aa1217eaf8344dee4e197a",
   "schema_floor": 2,
   "schema": 2
  },
  "waiting_on": [
   {
    "at": null,
    "id": "",
    "on": "nothing",
    "url": null,
    "what": ""
   }
  ],
  "risk": {
   "level": "low",
   "touches": [
    "tests"
   ],
   "why": "Touches only unit test fixtures in coins_tests.cpp and coinsviewoverlay_tests.cpp; a bug would only cause false test failures."
  },
  "discussion": {
   "author_status": "last statement processed 2026-10-23",
   "open_concerns": [],
   "resolved_concerns": []
  },
  "reviewability": {
   "state": "Ready",
   "label": "Ready",
   "reason": "Nothing known that would invalidate a review now."
  },
  "agreement": {
   "state": "Strong",
   "summary": "Strong: substantive support, no open objection (Hamza1610)",
   "reason": "Initial record. PR received a Tested ACK from Hamza1610 with no objections or suggestions raised. / Initial record. Hamza1610 provided a Tested ACK running unit tests.",
   "evidence": [
    "Hamza1610: Tested ACK \u2014 clean and structured changes; passed coins_tests and coinsviewoverlay_tests"
   ],
   "objections": [],
   "support": [
    {
     "reviewer": "Hamza1610",
     "reason": "clean and structured changes; passed coins_tests and coinsviewoverlay_tests",
     "substantive": true,
     "verdict": "Tested ACK",
     "id": "c:6365340911",
     "url": "https://github.com/bitcoin/bitcoin/pull/36601#issuecomment-6365340911",
     "at": "2026-10-23",
     "association": "NONE",
     "evidence": "tested",
     "areas": [
      "coins_tests",
      "coinsviewoverlay_tests"
     ]
    }
   ],
   "participants": [
    {
     "login": "Hamza1610",
     "stance": "support",
     "note": "Tested ACK with test suite execution",
     "association": "NONE",
     "comments": 1,
     "first": "2026-10-23",
     "last": "2026-10-23"
    }
   ],
   "derivation": "substantive support, no open objection (Hamza1610)",
   "model_state": null,
   "corrections": [],
   "notes": "Initial record. PR received a Tested ACK from Hamza1610 with no objections or suggestions raised. / Initial record. Hamza1610 provided a Tested ACK running unit tests."
  },
  "dependencies": {
   "depends_on": [],
   "enables": [
    "#36598"
   ]
  },
  "categories": [
   {
    "name": "tests",
    "member": false,
    "evidence": "Changes unit tests for the coins cache (src/test/coins_tests.cpp and src/test/coinsviewoverlay_tests.cpp) rather than shared test machinery or utilities.",
    "band": "Unranked",
    "reason_tag": "cleanup",
    "score": 0.0,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "This PR adjusts unit test fixtures for the coins cache rather than general test machinery or harnesses, which the category explicitly excludes."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": []
 },
 "cost_usd": 0.0,
 "source": {
  "record": "2026-10-24T01:18:52+00:00",
  "code": "2026-10-24T01:21:32+00:00",
  "judgments": 1
 }
}