{
 "number": 36706,
 "input_hash": "007c9237674889e6",
 "model": "ledger",
 "prompt_hash": null,
 "created": "2026-11-01T01:16:00+00:00",
 "result": {
  "summary": "Removes the unused `GetVirtualTransactionInputSize` helper function from the policy module. It also drops its invocation from the `tx_in` fuzz target and replaces it with direct weight calculation in a wallet unit test.",
  "problem": "`GetVirtualTransactionInputSize` has had no non-test callers since wallet input size estimation was changed to use descriptors in PR #26567, leaving dead code in the policy module.",
  "card": "Removes the unused GetVirtualTransactionInputSize function from policy code and updates the remaining fuzz and wallet tests. The helper became dead code after wallet input size estimation moved to descriptors in PR #26567. This is a routine internal cleanup with no user-facing or consensus impact.",
  "evidence": [
   "Commit message: \"The last non-test caller was removed in 9b7ec393b8 (#26567), when the wallet switched to estimating input sizes using descriptors. Since then it has only been used by the tx_in fuzz target and a helper in wallet_tests.\""
  ],
  "scope_notes": "",
  "changed_since_previous": "No functional changes; diff provided matches the previous description.",
  "thread": {
   "last_event_at": "2026-10-30T20:02:12Z",
   "events": 3,
   "head_sha": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "schema_floor": 2,
   "schema": 2
  },
  "waiting_on": [
   {
    "at": null,
    "id": "",
    "on": "nothing",
    "url": null,
    "what": ""
   }
  ],
  "risk": {
   "level": "low",
   "touches": [
    "mempool_policy",
    "tests"
   ],
   "why": "It deletes an unused helper function and inline declarations with no remaining production callers."
  },
  "discussion": {
   "author_status": "last statement processed 2026-10-30",
   "open_concerns": [],
   "resolved_concerns": []
  },
  "reviewability": {
   "state": "Ready",
   "label": "Ready",
   "reason": "Nothing known that would invalidate a review now."
  },
  "agreement": {
   "state": "Positive",
   "summary": "Positive: support without stated reasons, no open objection (jpk68, l0rinc)",
   "reason": "Initial record for PR 36706. l0rinc's inline comment rc:4424827991 is a style/naming nit on wallet_tests and is not tracked as a claim. / Initial record. Two approvals received (l0rinc and jpk68). l0rinc noted an inline nit on wallet_tests.cpp but approved the PR.",
   "evidence": [
    "jpk68: ACK",
    "l0rinc: ACK \u2014 lightly tested code review"
   ],
   "objections": [],
   "support": [
    {
     "reviewer": "jpk68",
     "reason": "",
     "substantive": false,
     "verdict": "ACK",
     "id": "c:6532346372",
     "url": "https://github.com/bitcoin/bitcoin/pull/36706#issuecomment-6532346372",
     "at": "2026-10-30",
     "association": "CONTRIBUTOR",
     "evidence": "none",
     "areas": []
    },
    {
     "reviewer": "l0rinc",
     "reason": "lightly tested code review",
     "substantive": false,
     "verdict": "ACK",
     "id": "r:5713933074",
     "url": "https://github.com/bitcoin/bitcoin/pull/36706#pullrequestreview-5713933074",
     "at": "2026-10-30",
     "association": "MEMBER",
     "evidence": "tested",
     "areas": []
    }
   ],
   "participants": [
    {
     "login": "jpk68",
     "stance": "support",
     "note": "ACKed the commit",
     "association": "CONTRIBUTOR",
     "comments": 1,
     "first": "2026-10-30",
     "last": "2026-10-30"
    },
    {
     "login": "l0rinc",
     "stance": "support",
     "note": "approved with a lightly tested code review ACK and noted an inline nit",
     "association": "MEMBER",
     "comments": 2,
     "first": "2026-10-30",
     "last": "2026-10-30"
    }
   ],
   "derivation": "support without stated reasons, no open objection (jpk68, l0rinc)",
   "model_state": null,
   "corrections": [],
   "notes": "Initial record for PR 36706. l0rinc's inline comment rc:4424827991 is a style/naming nit on wallet_tests and is not tracked as a claim. / Initial record. Two approvals received (l0rinc and jpk68). l0rinc noted an inline nit on wallet_tests.cpp but approved the PR."
  },
  "dependencies": {
   "depends_on": [],
   "enables": []
  },
  "categories": [
   {
    "name": "mempool",
    "member": true,
    "evidence": "Matches the 'TX fees and policy' label and directly modifies policy header and source files in src/policy/.",
    "band": "P4",
    "reason_tag": "cleanup",
    "score": 0.15,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "Removes an unused policy helper function (`GetVirtualTransactionInputSize`) that has had no production callers since PR #26567. As an internal dead-code cleanup with no behavioral effect on acceptance or relay rules, it is low priority."
   },
   {
    "name": "tests",
    "member": false,
    "evidence": "The one-line removal in src/test/fuzz/tx_in.cpp is purely a mechanical follow-up from deleting the policy helper.",
    "band": "Unranked",
    "reason_tag": "cleanup",
    "score": 0.0,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "Follow-up edit to a fuzz test due to an upstream function removal does not make this PR part of test infrastructure."
   },
   {
    "name": "wallet",
    "member": false,
    "evidence": "The change in src/wallet/test/wallet_tests.cpp is a mechanical edit following the removal of GetVirtualTransactionInputSize.",
    "band": "Unranked",
    "reason_tag": "cleanup",
    "score": 0.0,
    "factors": {
     "bug_severity": 0,
     "leverage": 0,
     "performance": 0,
     "security_stability": 0,
     "user_value": 0
    },
    "rationale": "Mechanical test adjustments following from changes in policy do not constitute wallet membership."
   }
  ],
  "confidence": "high",
  "uncertainties": [],
  "needs": []
 },
 "cost_usd": 0.0,
 "source": {
  "record": "2026-11-01T01:16:00+00:00",
  "code": "2026-11-01T01:20:15+00:00",
  "judgments": 3
 }
}