{
 "number": 35442,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/35442",
 "title": "test: remove usages of MAX_BIP125_RBF_SEQUENCE constant from functional tests",
 "author": "rkrux",
 "author_association": "CONTRIBUTOR",
 "created_at": "2026-06-02T13:46:22Z",
 "updated_at": "2026-06-26T23:00:48Z",
 "age_days": 107,
 "draft": true,
 "labels": [
  "Tests",
  "Needs rebase"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "7e4a0c57fca98407f7cca97886bdab23db6d0e4b",
 "head_ref": "rbfsequence-test",
 "head_repo": "rkrux/bitcoin",
 "head_history": [],
 "additions": 400,
 "deletions": 310,
 "changed_files": 18,
 "commit_count": 13,
 "size_bucket": "L",
 "mergeable_state": "dirty",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {},
   "conflicts": [
    {
     "number": 35543,
     "title": "test: introduce ExtendedPrivateKey and ExtendedPublicKey classes",
     "author": "rkrux"
    },
    {
     "number": 35472,
     "title": "test: add coverage for feebumper uncomputable cluster error path",
     "author": "151henry151"
    },
    {
     "number": 35433,
     "title": "wallet: deprecate replaceable argument from transaction (and psbt) creation (and modification) RPCs",
     "author": "rkrux"
    },
    {
     "number": 35302,
     "title": "Silent Payments:  Sending (take 2)",
     "author": "Eunovo"
    },
    {
     "number": 35100,
     "title": "rpc: Merge joinpsbts locktimes correctly",
     "author": "nervana21"
    },
    {
     "number": 32468,
     "title": "rpc: generateblock to allow multiple outputs",
     "author": "polespinasa"
    },
    {
     "number": 29278,
     "title": "Wallet:  Add `maxfeerate` wallet startup option",
     "author": "ismaelsadeeq"
    }
   ]
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "maflcko",
   "pablomartin4btc"
  ]
 },
 "signals": {
  "needs_rebase": true,
  "ci_failed": false,
  "mergeable_state": "dirty",
  "last_author_activity": "2026-06-10T12:24:55Z",
  "last_reviewer_activity": "2026-06-12T19:49:33Z",
  "last_reviewer": "pablomartin4btc",
  "author_silent_days": 99,
  "waiting_on_author_days": 96,
  "days_since_update": 82
 },
 "refs": {
  "mentioned": [
   35405,
   35433
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 35405,
    "type": "pull",
    "state": "closed",
    "merged": false,
    "merged_at": null,
    "title": "wallet: switch default optinrbf from true to false"
   },
   {
    "number": 35433,
    "type": "pull",
    "state": "open",
    "merged": false,
    "merged_at": null,
    "title": "wallet: deprecate replaceable argument from transaction (and psbt) creation (and modification) RPCs"
   }
  ],
  "conflicts": [
   35543,
   35472,
   35433,
   35302,
   35100,
   32468,
   29278
  ]
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "doc/release-notes-34917.md"
 ],
 "body": "Partially fixes https://github.com/bitcoin/bitcoin/issues/32661.\n\nDepends on https://github.com/bitcoin/bitcoin/pull/35433 from which the\nfirst 11 commits are added here and will be removed when this PR is\nundrafted. Only the last 2 commits are specific to this PR.\n\nThis is in line with the removal and deprecation of BIP 125 RBF signalling\nfrom the codebase.",
 "commits": [
  {
   "sha": "b74ffabcff894db9025e907973c501504012ccdd",
   "date": "2026-06-02T10:17:18Z",
   "message": "wallet: switch default wallet rbf from true to false\n\nWith the nodes running fullrbf, wallet doesn't need to opt into RBF. This patch\nswitches the default of wallet rbf to false. Users still have the option to\noptin RBF via the individual transaction (and PSBT) creation RPCs - for now."
  },
  {
   "sha": "aa722b592a954024b46bec3dfe3149a2d1494f24",
   "date": "2026-06-02T10:17:18Z",
   "message": "doc: update release notes of PR 34917 to mention new default wallet rbf value"
  },
  {
   "sha": "d7efd0f89c539516e8b9b062688aeac6d7efaf26",
   "date": "2026-06-02T10:17:18Z",
   "message": "wallet, rpc: deprecate replaceable argument in bumpfee, psbtbumpfee RPCs"
  },
  {
   "sha": "5870df54ca0c94fb3cc1f3b66830cd2240b0e570",
   "date": "2026-06-02T11:14:45Z",
   "message": "wallet, test: replace rbf_node with node in wallet_bumpfee.py\n\nPost deprecation of -walletrbf startup option and removal of the same\noption from the wallet_bumpfee.py test, the second node in this test\nis no longer a rbf node, so update its name to reflect so.\n\nAlso update the rbf_node_address correspondingly."
  },
  {
   "sha": "6d7e895a63df51f390bda30760edd1b18aaee6ff",
   "date": "2026-06-02T11:15:14Z",
   "message": "wallet, rpc: deprecate replaceable argument in sendall RPC"
  },
  {
   "sha": "f6b690bfcb8d79948ec5a1471821ae4bbcddfe54",
   "date": "2026-06-02T11:15:14Z",
   "message": "wallet, rpc: deprecate replaceable argument in walletcreatefundedpsbt, fundrawtransaction"
  },
  {
   "sha": "590865b6459a079d092e98b019268a727efa9ae1",
   "date": "2026-06-02T11:15:14Z",
   "message": "wallet, rpc: deprecate replaceable argument in send RPC"
  },
  {
   "sha": "f5e33e2bee21871e89a222a98e97a4efcec525dd",
   "date": "2026-06-02T11:15:14Z",
   "message": "wallet, rpc: deprecate replaceable argument in sendtoaddress, sendmany RPCs"
  },
  {
   "sha": "32494df13169c9c680655b739fde5e47cf3f10ed",
   "date": "2026-06-02T11:26:40Z",
   "message": "wallet, rpc: deprecate replaceable argument in createrawtransaction, createpsbt"
  },
  {
   "sha": "ed7e67ef8b2e845f61d230001743ea16922a66fc",
   "date": "2026-06-02T11:30:30Z",
   "message": "wallet, test: add test cases for deprecated RBF features\n\nTested RPCs: createrawtransaction, fundrawtransaction, createpsbt, bumpfee\nwalletcreatefundedpsbt, send, sendtoaddress, sendmany, sendall, psbtbumpfee."
  },
  {
   "sha": "17d9368760587eae553e7eb7d12a3d0cfb0832fe",
   "date": "2026-06-02T12:05:32Z",
   "message": "doc: update release notes of 34917 mentioning `replaceable` deprecation"
  },
  {
   "sha": "8e8765e46d3522178bb3b5f1a1ca73ed847c1155",
   "date": "2026-06-02T13:35:29Z",
   "message": "test: remove usage of MAX_BIP125_RBF_SEQUENCE constant in non-wallet tests\n\nRemove the usage in all the tests where used except the ones where the\nsequence is set to unique values to avoid creating duplicate transactions\nsimultaneously."
  },
  {
   "sha": "7e4a0c57fca98407f7cca97886bdab23db6d0e4b",
   "date": "2026-06-02T13:41:01Z",
   "message": "test: remove usages of MAX_BIP125_RBF_SEQUENCE in wallet tests except one\n\nIts usage is preserved only in wallet_deprecated_rbf.py and thus the constant\nis moved there. This will be removed as well in the next release when BIP 125\ndeprecated stuff is removed."
  }
 ],
 "timeline": [
  {
   "t": "2026-06-08T11:20:49Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "Not sure if a small test-only fixup needs a separate pull request. Can those two commits not just be included in the prior pull?\n\nAlso, it seems more important to remove `MAX_BIP125_RBF_SEQUENCE` from the real source code, so that the risk of pre-existing and future fingerprint vectors in this source code is reduced."
  },
  {
   "t": "2026-06-10T09:45:44Z",
   "kind": "comment",
   "who": "rkrux",
   "assoc": "CONTRIBUTOR",
   "text": "[quoted text omitted]\n\nYes, it is more important but it can't be done cleanly until the feature is removed completely post deprecation.\nWhereas it can be done easily in functional tests because all the tests have been updated to not rely on this deprecated feature anymore.\n\n[quoted text omitted]\nI will look into it."
  },
  {
   "t": "2026-06-10T12:14:50Z",
   "kind": "comment",
   "who": "rkrux",
   "assoc": "CONTRIBUTOR",
   "text": "[quoted text omitted]\n\nI didn't want to increase the scope of the previous PR, that's why raised this\nseparate PR here. I have pushed the last two test related commits in #35433\nnow but might remove them later if I notice they are making the review of that\nPR tougher for others."
  },
  {
   "t": "2026-06-10T12:24:55Z",
   "kind": "comment",
   "who": "rkrux",
   "assoc": "CONTRIBUTOR",
   "text": "Actually, no.\n\nThe first two commits here are from #35405 due to which these two commits\ncan't be appended cleanly in #35433. I'll wait on the resolution of #35405."
  },
  {
   "t": "2026-06-12T19:26:04Z",
   "kind": "comment",
   "who": "pablomartin4btc",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nPerhaps you can add that to the description too (\"Depends on https://github.com/bitcoin/bitcoin/pull/35405 - first 2 commits - and #35433 - 9 commits\"). Sorry, I'm late to the party and trying to follow the review order from the issue's pending [list](https://github.com/bitcoin/bitcoin/issues/32661#issuecomment-4565515381)."
  },
  {
   "t": "2026-06-12T19:49:33Z",
   "kind": "review_comment",
   "who": "pablomartin4btc",
   "assoc": "MEMBER",
   "path": "doc/release-notes-34917.md",
   "commit": "7e4a0c57fca98407f7cca97886bdab23db6d0e4b",
   "in_reply_to": null,
   "text": "I think that needs to be updated according to https://github.com/bitcoin/bitcoin/pull/35405/changes#r3340846939. Just for reference, I know this is still a draft."
  }
 ],
 "labels_log": [
  {
   "t": "2026-06-02T13:46:26Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  },
  {
   "t": "2026-06-26T23:00:48Z",
   "action": "labeled",
   "label": "Needs rebase",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 3921,
 "text_tokens_estimate": 980,
 "changed_paths": [
  "doc/release-notes-34917.md",
  "src/rpc/rawtransaction.cpp",
  "src/rpc/rawtransaction_util.cpp",
  "src/wallet/rpc/spend.cpp",
  "src/wallet/spend.cpp",
  "src/wallet/wallet.h",
  "test/functional/feature_rbf.py",
  "test/functional/mempool_accept.py",
  "test/functional/mempool_package_rbf.py",
  "test/functional/p2p_opportunistic_1p1c.py",
  "test/functional/p2p_segwit.py",
  "test/functional/rpc_packages.py",
  "test/functional/rpc_psbt.py",
  "test/functional/rpc_rawtransaction.py",
  "test/functional/test_framework/messages.py",
  "test/functional/wallet_bumpfee.py",
  "test/functional/wallet_deprecated_rbf.py",
  "test/functional/wallet_listsinceblock.py"
 ],
 "files": [
  {
   "path": "doc/release-notes-34917.md",
   "add": 20,
   "del": 4
  },
  {
   "path": "src/rpc/rawtransaction.cpp",
   "add": 9,
   "del": 5
  },
  {
   "path": "src/rpc/rawtransaction_util.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/wallet/rpc/spend.cpp",
   "add": 41,
   "del": 20
  },
  {
   "path": "src/wallet/spend.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/wallet/wallet.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "test/functional/feature_rbf.py",
   "add": 2,
   "del": 2
  },
  {
   "path": "test/functional/mempool_accept.py",
   "add": 1,
   "del": 2
  },
  {
   "path": "test/functional/mempool_package_rbf.py",
   "add": 13,
   "del": 13
  },
  {
   "path": "test/functional/p2p_opportunistic_1p1c.py",
   "add": 2,
   "del": 2
  },
  {
   "path": "test/functional/p2p_segwit.py",
   "add": 0,
   "del": 2
  },
  {
   "path": "test/functional/rpc_packages.py",
   "add": 2,
   "del": 3
  },
  {
   "path": "test/functional/rpc_psbt.py",
   "add": 5,
   "del": 5
  },
  {
   "path": "test/functional/rpc_rawtransaction.py",
   "add": 0,
   "del": 5
  },
  {
   "path": "test/functional/test_framework/messages.py",
   "add": 0,
   "del": 1
  },
  {
   "path": "test/functional/wallet_bumpfee.py",
   "add": 231,
   "del": 235
  },
  {
   "path": "test/functional/wallet_deprecated_rbf.py",
   "add": 70,
   "del": 5
  },
  {
   "path": "test/functional/wallet_listsinceblock.py",
   "add": 1,
   "del": 3
  }
 ],
 "test_lines": 605,
 "git": {
  "head": "7e4a0c57fca98407f7cca97886bdab23db6d0e4b",
  "head_matches_backup": true,
  "base": "13b7fffc5e065cf5555e87bb70030ef4322f15dc",
  "commits": [
   {
    "sha": "b74ffabcff",
    "subject": "wallet: switch default wallet rbf from true to false",
    "files": 2,
    "add": 3,
    "del": 2
   },
   {
    "sha": "aa722b592a",
    "subject": "doc: update release notes of PR 34917 to mention new default wallet rbf value",
    "files": 1,
    "add": 6,
    "del": 1
   },
   {
    "sha": "d7efd0f89c",
    "subject": "wallet, rpc: deprecate replaceable argument in bumpfee, psbtbumpfee RPCs",
    "files": 3,
    "add": 10,
    "del": 9
   },
   {
    "sha": "5870df54ca",
    "subject": "wallet, test: replace rbf_node with node in wallet_bumpfee.py",
    "files": 1,
    "add": 227,
    "del": 227
   },
   {
    "sha": "6d7e895a63",
    "subject": "wallet, rpc: deprecate replaceable argument in sendall RPC",
    "files": 1,
    "add": 7,
    "del": 2
   },
   {
    "sha": "f6b690bfcb",
    "subject": "wallet, rpc: deprecate replaceable argument in walletcreatefundedpsbt, fundrawtransaction",
    "files": 2,
    "add": 13,
    "del": 8
   },
   {
    "sha": "590865b645",
    "subject": "wallet, rpc: deprecate replaceable argument in send RPC",
    "files": 1,
    "add": 6,
    "del": 1
   },
   {
    "sha": "f5e33e2bee",
    "subject": "wallet, rpc: deprecate replaceable argument in sendtoaddress, sendmany RPCs",
    "files": 1,
    "add": 10,
    "del": 6
   },
   {
    "sha": "32494df131",
    "subject": "wallet, rpc: deprecate replaceable argument in createrawtransaction, createpsbt",
    "files": 3,
    "add": 10,
    "del": 11
   },
   {
    "sha": "ed7e67ef8b",
    "subject": "wallet, test: add test cases for deprecated RBF features",
    "files": 1,
    "add": 69,
    "del": 5
   },
   {
    "sha": "17d9368760",
    "subject": "doc: update release notes of 34917 mentioning `replaceable` deprecation",
    "files": 1,
    "add": 18,
    "del": 7
   },
   {
    "sha": "8e8765e46d",
    "subject": "test: remove usage of MAX_BIP125_RBF_SEQUENCE constant in non-wallet tests",
    "files": 6,
    "add": 20,
    "del": 24
   },
   {
    "sha": "7e4a0c57fc",
    "subject": "test: remove usages of MAX_BIP125_RBF_SEQUENCE in wallet tests except one",
    "files": 4,
    "add": 6,
    "del": 12
   }
  ],
  "patch_truncated": true
 },
 "input_hash": "357f0d14f2144b37",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}