{
 "number": 35733,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/35733",
 "title": "sign: Remove FillableSigningProvider",
 "author": "achow101",
 "author_association": "MEMBER",
 "created_at": "2026-07-15T22:53:29Z",
 "updated_at": "2026-09-15T12:40:25Z",
 "age_days": 63,
 "draft": false,
 "labels": [],
 "milestone": null,
 "base": "master",
 "head_sha": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
 "head_ref": "rm-fillablesigningprovider",
 "head_repo": "achow101/bitcoin",
 "head_history": [
  {
   "t": "2026-07-17T19:28:36Z",
   "sha": "6d19ba04acbeb04dba5afcb03fd5f25d644b64bd"
  },
  {
   "t": "2026-07-18T00:17:23Z",
   "sha": "cee0f3c2f9be81cdcc605c72f71f88db9dca32e9"
  },
  {
   "t": "2026-07-18T01:09:01Z",
   "sha": "e2aa2e64c80b217c79d54700110b51f700811426"
  },
  {
   "t": "2026-07-18T01:21:17Z",
   "sha": "632e42a12f141bd1e104011124618a6fa3a09fed"
  },
  {
   "t": "2026-08-19T20:03:05Z",
   "sha": "03969968a7dd517c0ae7ba31918ff5244ccb3839"
  },
  {
   "t": "2026-08-26T18:13:21Z",
   "sha": "814fdcba23814212b36326619361edf4ed06868e"
  },
  {
   "t": "2026-09-14T20:10:27Z",
   "sha": "b68a3837ec6b3e4358ded6823f45ef3c5143291b"
  }
 ],
 "additions": 190,
 "deletions": 288,
 "changed_files": 22,
 "commit_count": 7,
 "size_bucket": "L",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "concept_ack": [
     {
      "login": "vicjuma",
      "url": "https://github.com/bitcoin/bitcoin/pull/35733#pullrequestreview-4901065729"
     },
     {
      "login": "rkrux",
      "url": "https://github.com/bitcoin/bitcoin/pull/35733#issuecomment-5426550343"
     }
    ],
    "approach_ack": [
     {
      "login": "jeanpablojp",
      "url": "https://github.com/bitcoin/bitcoin/pull/35733#pullrequestreview-5025284697"
     }
    ]
   },
   "conflicts": [
    {
     "number": 34729,
     "title": "Reduce log noise",
     "author": "ajtowns"
    },
    {
     "number": 34520,
     "title": "refactor: Add [[nodiscard]] to functions returning bool+mutable ref",
     "author": "maflcko"
    }
   ]
  }
 },
 "acks_parsed": {
  "vicjuma": {
   "kind": "ack",
   "hash": null,
   "t": "2026-08-10T22:24:41Z",
   "stale": true
  },
  "jeanpablojp": {
   "kind": "approach_ack",
   "hash": null,
   "t": "2026-08-25T23:28:03Z",
   "stale": false
  },
  "rkrux": {
   "kind": "concept_ack",
   "hash": "03969968a7dd517c0ae7ba31918ff5244ccb3839",
   "t": "2026-08-26T14:09:17Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 0,
  "stale_ack": 1,
  "concept_ack": 1,
  "approach_ack": 1,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "jeanpablojp",
   "rkrux",
   "vicjuma"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-14T20:10:27Z",
  "last_reviewer_activity": "2026-08-26T14:09:17Z",
  "last_reviewer": "rkrux",
  "author_silent_days": 2,
  "waiting_on_author_days": 0,
  "days_since_update": 2
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": [
   34729,
   34520
  ]
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "src/bitcoin-tx.cpp",
  "src/test/fuzz/script_sign.cpp",
  "src/wallet/test/fuzz/scriptpubkeyman.cpp"
 ],
 "body": "`FillableSigningProvider` was initially extracted from the wallet in order to produce the `SigningProvider` encapsulation system that we use today for the wallet and for providing key material to signing. It's primary user was the legacy wallet, but it was also being used as a convenience in a few other places. Since the legacy wallet is removed, there is no need to keep it around as a separate class. Instead, the things that it was doing can be inlined into `LegacyDataSPKM` where the functionality is actually being used to support migrating legacy wallets.\n\nThe remaining uses are tests and the `bitcoin-tx` tool, some of which were relying on the implicit addition of segwit scripts when adding a key. However, these can also use `FlatSigningProvider` with explicitly adding the segwit scripts when necessary, and have thusly been converted to do so.",
 "commits": [
  {
   "sha": "b76230b90ed0eecd2304ccf166a361930c044a9f",
   "date": "2026-09-14T20:07:52Z",
   "message": "sign: Do not sign SCRIPTHASH redeemScripts > 520 bytes"
  },
  {
   "sha": "f61330b828b1c23ba19a22c7820745f39e48a17d",
   "date": "2026-09-14T20:07:52Z",
   "message": "test: Use FlatSigningProvider in SetupDummyInputs\n\nInstead of using FillableSigningProvider, use a FlatSigningProvider."
  },
  {
   "sha": "036d789014a5a0522be018aaab81261dbfce9511",
   "date": "2026-09-14T20:07:52Z",
   "message": "fuzz: Remove use of FillableSigningProvider"
  },
  {
   "sha": "b7ed7087f8e91db6ad091f03b8e22a9d61dcb4e4",
   "date": "2026-09-14T20:10:07Z",
   "message": "tests: Replace FillableSigningProvider with FlatSigningProvider\n\nFillableSigningProvider is not a necessary part of the tests and\nFlatSigningProvider is sufficient."
  },
  {
   "sha": "9f0b7481ce4c1c7f4f01d69a80bf9f5ecffd5751",
   "date": "2026-09-14T20:10:09Z",
   "message": "bitcoin-tx: Replace FillableSigningProvider with FlatSigningProvider\n\nbitcoin-tx does not need to use FillableSigningProvider, it can use\nFlatSigningProvider and inline ImplicitlyLearnRelatedKeyScripts."
  },
  {
   "sha": "53489b5ed376b1f0a9f1ce0a976bd48d9d8f3eb1",
   "date": "2026-09-14T20:10:09Z",
   "message": "wallet: Combine FillableSigningProvider into LegacyDataSPKM\n\nThe only real user of FillableSigningProvider is LegacyDataSPKM. Instead\nof having it be a separate class which LegacyDataSPKM subclasses, move\nthe implementation directly into LegacyDataSPKM and have LegacyDataSPKM\nbe a subclass of SigningProvider."
  },
  {
   "sha": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "date": "2026-09-14T20:10:09Z",
   "message": "doc: Remove reference to FillableSigningProvider"
  }
 ],
 "timeline": [
  {
   "t": "2026-07-17T19:28:36Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "6d19ba04acbeb04dba5afcb03fd5f25d644b64bd"
  },
  {
   "t": "2026-07-18T00:17:23Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "cee0f3c2f9be81cdcc605c72f71f88db9dca32e9"
  },
  {
   "t": "2026-07-18T01:09:01Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "e2aa2e64c80b217c79d54700110b51f700811426"
  },
  {
   "t": "2026-07-18T01:21:17Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "632e42a12f141bd1e104011124618a6fa3a09fed"
  },
  {
   "t": "2026-08-10T21:22:58Z",
   "kind": "review_comment",
   "who": "vicjuma",
   "assoc": "CONTRIBUTOR",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": null,
   "text": "The key path works correctly. A helper function would maybe be handy same as the `AddKey` one but since we are only using it in a single place, I guess expanding it here may be fine.\n\n### bitcoin-tx testing\n**Creating unsigned transaction**\n```console\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$ TX=$(./bitcoin-tx -regtest -create \\\n     in=7dc357e7ba70b0b503c9a12f4a293add0b1d230e08de3cad83e142737746c4b8:1 \\\n     outaddr=0.9:mmhnpJgEDuPxTmw6Nuu5Ms2xmP21n6XoCi)\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$\n```\n\n**Signing the transaction**\n```console\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$ TX=$(./bitcoin-tx -regtest \"$TX\" \\\n     set=prevtxs:\"[{\\\"txid\\\":\\\"7dc357e7ba70b0b503c9a12f4a293add0b1d230e08de3cad83e142737746c4b8\\\",\\\"vout\\\":1,\\\"scriptPubKey\\\":\\\"76a91443dd6b08400c8e763c5e1b8520957e132cac817088ac\\\",\\\"amount\\\":1}]\" \\\n     set=privatekeys:\"[\\\"cNPgXXtoNEkhZd6txFEPQvWMF8gfvyG15JnYxgtrbQgiesHPwERA\\\"]\" \\\n     sign=ALL)\n```\n\n**Confirming**\n```console\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$ ./bitcoin-cli -regtest testmempoolaccept \"[\\\"$TX\\\"]\" 0\n[\n  {\n    \"txid\": \"96aba7a976963a610c82d8fe5ba0f5da1837d64e875127fc74b3253c2de1b9d9\",\n    \"wtxid\": \"96aba7a976963a610c82d8fe5ba0f5da1837d64e875127fc74b3253c2de1b9d9\",\n    \"allowed\": true,\n    \"vsize\": 191,\n    \"fees\": {\n      \"base\": 0.10000000\n    }\n  }\n]\n```\n\nThe values used were generated from `bitcoin 24.0` binary from the [commands](https://github.com/vicjuma/pr-35733-used-commands/blob/main/pr-35733.txt)"
  },
  {
   "t": "2026-08-10T21:32:37Z",
   "kind": "review_comment",
   "who": "vicjuma",
   "assoc": "CONTRIBUTOR",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": null,
   "text": "Following this function, the maximum script element size condition is being checked `redeemScript.size() > MAX_SCRIPT_ELEMENT_SIZE`"
  },
  {
   "t": "2026-08-10T21:59:41Z",
   "kind": "review_comment",
   "who": "vicjuma",
   "assoc": "CONTRIBUTOR",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": null,
   "text": "It was thoughtful to remove the check since `pay-to-witness-script-hash`  doesn't share the same `MAX_SCRIPT_ELEMENT_SIZE` limit as the `pay-to-script-hash`.\n\nThe script path works correctly.\n\n### bitcoin-tx testing\n**Creating unsigned transaction**\n```console\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$ TX=$(./bitcoin-tx -regtest -create \\\n  in=f4e3e878eefc814436f3cf27752bb1896934dcd8fa8663ffd8187e9358d0c03b:0 \\\n  outaddr=0.9:mwbmunN2ojMDLGWwZJuqPNX3dfyuvNqheF)\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$\n```\n\n**Signing the transaction**\n```console\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$ TX=$(./bitcoin-tx -regtest \"$TX\" \\\n  set=prevtxs:\"[{\\\"txid\\\":\\\"f4e3e878eefc814436f3cf27752bb1896934dcd8fa8663ffd8187e9358d0c03b\\\",\\\"vout\\\":0,\\\"scriptPubKey\\\":\\\"a91417c74210b483bf6dd004660b05b356b6c3aa12dc87\\\",\\\"redeemScript\\\":\\\"522103804969501e96ed27704e3d82bef2b5ef04a53d80683ea1a4dbbb9d2e63b7e09921034c988b448e0fa6a1fcc09f33a20abf5ab0ca3e393fa717bb251493dd2819412752ae\\\",\\\"amount\\\":1.00000000}]\" \\\n  set=privatekeys:\"[\\\"cTzVvTMsbz75L9mF15FdM6AZWe22EXstSoQGhBGNMjYRjm28N7Yx\\\",\\\"cNc7X8u7KCubwor6rsuSMFdNCCEwK2qSkbHv5WFTPDWmBdRNWHgG\\\"]\" \\\n  sign=ALL)\n```\n\n**Confirming**\n```console\nratedg@0xratedg:~/projects/contributions/bitcoin/build2/bin$ ./bitcoin-cli -regtest testmempoolaccept \"[\\\"$TX\\\"]\" 0\n[\n  {\n    \"txid\": \"6286887e90dfd4aebcbdec8d1949593ce46ed6b0d10a03e8f84db6fe7d52a914\",\n    \"wtxid\": \"6286887e90dfd4aebcbdec8d1949593ce46ed6b0d10a03e8f84db6fe7d52a914\",\n    \"allowed\": true,\n    \"vsize\": 302,\n    \"fees\": {\n      \"base\": 0.10000000\n    }\n  }\n]\n```\n\nThe values used were generated from `bitcoin 24.0` binary from the [commands](https://github.com/vicjuma/pr-35733-used-commands/blob/main/pr-35733.txt)"
  },
  {
   "t": "2026-08-10T22:14:08Z",
   "kind": "review_comment",
   "who": "vicjuma",
   "assoc": "CONTRIBUTOR",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": null,
   "text": "appropriate for the self-contained bitcoin-tx"
  },
  {
   "t": "2026-08-10T22:14:21Z",
   "kind": "review_comment",
   "who": "vicjuma",
   "assoc": "CONTRIBUTOR",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": null,
   "text": "appropriate for the self-contained bitcoin-tx"
  },
  {
   "t": "2026-08-10T22:24:41Z",
   "kind": "review",
   "who": "vicjuma",
   "assoc": "CONTRIBUTOR",
   "state": "COMMENTED",
   "commit": "632e42a12f141bd1e104011124618a6fa3a09fed",
   "text": "ACK for the bitcoin-tx changes. Will try to review the remaining parts"
  },
  {
   "t": "2026-08-19T20:03:05Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "03969968a7dd517c0ae7ba31918ff5244ccb3839"
  },
  {
   "t": "2026-08-25T23:28:03Z",
   "kind": "review",
   "who": "jeanpablojp",
   "assoc": "CONTRIBUTOR",
   "state": "COMMENTED",
   "commit": "03969968a7dd517c0ae7ba31918ff5244ccb3839",
   "text": "Approach ACK\n\nBuilt and ran the tests."
  },
  {
   "t": "2026-08-25T23:28:03Z",
   "kind": "review_comment",
   "who": "jeanpablojp",
   "assoc": "CONTRIBUTOR",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": null,
   "text": "`AddCScript` rejected scripts over 520 bytes for both P2SH and P2WSH, but the limit only applies to the script the scriptSig has to push. With a 1-of-16 multisig of 547 bytes, master leaves both inputs unsigned. This branch fixes P2WSH, which now makes it into the mempool, and also signs P2SH, producing a transaction that is consensus-invalid with `Push value size limit exceeded`. Worth keeping the limit for the script the scriptSig pushes? Neither case seems to have a vector in `bitcoin-util-test.json`."
  },
  {
   "t": "2026-08-25T23:28:03Z",
   "kind": "review_comment",
   "who": "jeanpablojp",
   "assoc": "CONTRIBUTOR",
   "path": "src/wallet/test/fuzz/scriptpubkeyman.cpp",
   "commit": "03969968a7dd517c0ae7ba31918ff5244ccb3839",
   "in_reply_to": null,
   "text": "For a script over 520 bytes `LoadCScript` returns true without storing it, where `AddCScript` returned false. So `added_script` counts a script that was never stored, and the `>=` branch runs instead of the exact-equality one. 16 compressed keys already reach 547 bytes."
  },
  {
   "t": "2026-08-25T23:28:03Z",
   "kind": "review_comment",
   "who": "jeanpablojp",
   "assoc": "CONTRIBUTOR",
   "path": "src/test/fuzz/script_sign.cpp",
   "commit": "03969968a7dd517c0ae7ba31918ff5244ccb3839",
   "in_reply_to": null,
   "text": "`AddKey(k)` also answered `GetPubKey()` and, for compressed keys, inserted the P2WPKH script P2SH-P2WPKH needs. The current `script_sign` corpus finds both, and with only `provider.keys` those lookups start failing. Could the explicit insertions `bitcoin-tx` does be kept here too?"
  },
  {
   "t": "2026-08-26T14:09:17Z",
   "kind": "comment",
   "who": "rkrux",
   "assoc": "MEMBER",
   "text": "Concept ACK 03969968a7dd517c0ae7ba31918ff5244ccb3839 to containerise the codepath related to legacy wallets while discouraging usage of this seemingly outdated signing provider."
  },
  {
   "t": "2026-08-26T18:13:21Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "814fdcba23814212b36326619361edf4ed06868e"
  },
  {
   "t": "2026-08-26T18:13:39Z",
   "kind": "review_comment",
   "who": "achow101",
   "assoc": "MEMBER",
   "path": "src/bitcoin-tx.cpp",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
   "in_reply_to": 3858368606,
   "text": "I added a commit to enforce this in signing."
  },
  {
   "t": "2026-08-26T18:13:48Z",
   "kind": "review_comment",
   "who": "achow101",
   "assoc": "MEMBER",
   "path": "src/wallet/test/fuzz/scriptpubkeyman.cpp",
   "commit": "03969968a7dd517c0ae7ba31918ff5244ccb3839",
   "in_reply_to": 3858368608,
   "text": "Fixed"
  },
  {
   "t": "2026-08-26T18:13:53Z",
   "kind": "review_comment",
   "who": "achow101",
   "assoc": "MEMBER",
   "path": "src/test/fuzz/script_sign.cpp",
   "commit": "03969968a7dd517c0ae7ba31918ff5244ccb3839",
   "in_reply_to": 3858368613,
   "text": "Done"
  },
  {
   "t": "2026-09-14T20:10:27Z",
   "kind": "force_push",
   "who": "achow101",
   "commit": "b68a3837ec6b3e4358ded6823f45ef3c5143291b"
  }
 ],
 "labels_log": [
  {
   "t": "2026-07-15T23:51:21Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-07-18T02:23:30Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-08-18T09:46:05Z",
   "action": "labeled",
   "label": "Needs rebase",
   "who": "DrahtBot"
  },
  {
   "t": "2026-08-19T21:35:26Z",
   "action": "unlabeled",
   "label": "Needs rebase",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-09T16:23:23Z",
   "action": "labeled",
   "label": "Needs rebase",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-14T20:19:32Z",
   "action": "unlabeled",
   "label": "Needs rebase",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 6779,
 "text_tokens_estimate": 1694,
 "changed_paths": [
  "doc/developer-notes.md",
  "src/bench/ccoins_caching.cpp",
  "src/bitcoin-tx.cpp",
  "src/script/sign.cpp",
  "src/script/signingprovider.cpp",
  "src/script/signingprovider.h",
  "src/test/fuzz/key.cpp",
  "src/test/fuzz/script_sign.cpp",
  "src/test/multisig_tests.cpp",
  "src/test/orphanage_tests.cpp",
  "src/test/script_p2sh_tests.cpp",
  "src/test/script_tests.cpp",
  "src/test/transaction_tests.cpp",
  "src/test/txvalidationcache_tests.cpp",
  "src/test/util/setup_common.cpp",
  "src/test/util/transaction_utils.cpp",
  "src/test/util/transaction_utils.h",
  "src/wallet/scriptpubkeyman.cpp",
  "src/wallet/scriptpubkeyman.h",
  "src/wallet/test/fuzz/scriptpubkeyman.cpp",
  "src/wallet/test/spend_tests.cpp",
  "src/wallet/test/wallet_tests.cpp"
 ],
 "files": [
  {
   "path": "doc/developer-notes.md",
   "add": 1,
   "del": 2
  },
  {
   "path": "src/bench/ccoins_caching.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/bitcoin-tx.cpp",
   "add": 10,
   "del": 4
  },
  {
   "path": "src/script/sign.cpp",
   "add": 3,
   "del": 0
  },
  {
   "path": "src/script/signingprovider.cpp",
   "add": 0,
   "del": 109
  },
  {
   "path": "src/script/signingprovider.h",
   "add": 0,
   "del": 74
  },
  {
   "path": "src/test/fuzz/key.cpp",
   "add": 14,
   "del": 20
  },
  {
   "path": "src/test/fuzz/script_sign.cpp",
   "add": 8,
   "del": 2
  },
  {
   "path": "src/test/multisig_tests.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/test/orphanage_tests.cpp",
   "add": 3,
   "del": 2
  },
  {
   "path": "src/test/script_p2sh_tests.cpp",
   "add": 16,
   "del": 13
  },
  {
   "path": "src/test/script_tests.cpp",
   "add": 7,
   "del": 6
  },
  {
   "path": "src/test/transaction_tests.cpp",
   "add": 29,
   "del": 23
  },
  {
   "path": "src/test/txvalidationcache_tests.cpp",
   "add": 4,
   "del": 3
  },
  {
   "path": "src/test/util/setup_common.cpp",
   "add": 3,
   "del": 2
  },
  {
   "path": "src/test/util/transaction_utils.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/test/util/transaction_utils.h",
   "add": 1,
   "del": 2
  },
  {
   "path": "src/wallet/scriptpubkeyman.cpp",
   "add": 62,
   "del": 10
  },
  {
   "path": "src/wallet/scriptpubkeyman.h",
   "add": 10,
   "del": 2
  },
  {
   "path": "src/wallet/test/fuzz/scriptpubkeyman.cpp",
   "add": 4,
   "del": 2
  },
  {
   "path": "src/wallet/test/spend_tests.cpp",
   "add": 3,
   "del": 2
  },
  {
   "path": "src/wallet/test/wallet_tests.cpp",
   "add": 7,
   "del": 5
  }
 ],
 "test_lines": 191,
 "git": {
  "head": "b68a3837ec6b3e4358ded6823f45ef3c5143291b",
  "head_matches_backup": true,
  "base": "cff00c547e7460fa1ec4aa1e38217793593d4263",
  "commits": [
   {
    "sha": "b76230b90e",
    "subject": "sign: Do not sign SCRIPTHASH redeemScripts > 520 bytes",
    "files": 1,
    "add": 3,
    "del": 0
   },
   {
    "sha": "f61330b828",
    "subject": "test: Use FlatSigningProvider in SetupDummyInputs",
    "files": 4,
    "add": 6,
    "del": 7
   },
   {
    "sha": "036d789014",
    "subject": "fuzz: Remove use of FillableSigningProvider",
    "files": 2,
    "add": 22,
    "del": 22
   },
   {
    "sha": "b7ed7087f8",
    "subject": "tests: Replace FillableSigningProvider with FlatSigningProvider",
    "files": 9,
    "add": 72,
    "del": 56
   },
   {
    "sha": "9f0b7481ce",
    "subject": "bitcoin-tx: Replace FillableSigningProvider with FlatSigningProvider",
    "files": 1,
    "add": 10,
    "del": 4
   },
   {
    "sha": "53489b5ed3",
    "subject": "wallet: Combine FillableSigningProvider into LegacyDataSPKM",
    "files": 5,
    "add": 76,
    "del": 197
   },
   {
    "sha": "b68a3837ec",
    "subject": "doc: Remove reference to FillableSigningProvider",
    "files": 1,
    "add": 1,
    "del": 2
   }
  ],
  "patch_truncated": true
 },
 "input_hash": "3e612f8bf83824d0",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}