{
 "number": 35893,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/35893",
 "title": "test: cover submitpackage other-wtxid for same-txid-diff-witness",
 "author": "mercie-ux",
 "author_association": "NONE",
 "created_at": "2026-08-05T06:50:04Z",
 "updated_at": "2026-08-12T08:59:22Z",
 "age_days": 43,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "9054f7cde43a264300bb0567215bda5f55803ae5",
 "head_ref": "test-submitpackage-other-wtxid",
 "head_repo": "mercie-ux/bitcoin",
 "head_history": [
  {
   "t": "2026-08-12T03:37:31Z",
   "sha": "9054f7cde43a264300bb0567215bda5f55803ae5"
  }
 ],
 "additions": 31,
 "deletions": 0,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "blocked",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "jeanpablojp",
      "url": "https://github.com/bitcoin/bitcoin/pull/35893#issuecomment-5264594568"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "instagibbs": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-08-09T13:55:13Z",
   "stale": false
  },
  "jeanpablojp": {
   "kind": "ack",
   "hash": "9054f7cde43a264300bb0567215bda5f55803ae5",
   "t": "2026-08-12T08:59:18Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "instagibbs",
   "jeanpablojp"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "blocked",
  "last_author_activity": "2026-08-12T03:38:00Z",
  "last_reviewer_activity": "2026-08-12T08:59:18Z",
  "last_reviewer": "jeanpablojp",
  "author_silent_days": 36,
  "waiting_on_author_days": 36,
  "days_since_update": 36
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "test/functional/rpc_packages.py"
 ],
 "body": "The specific behaviour tied to the `// TODO: allow witness replacement in packages.` had no functional test anywhere, just the unit test coverage, showing the underlying mempool logic and not the RPC's actual JSON output.\nThis test submits a same-txid-different-witness transaction via `submitpackage` while its counterpart is already in the mempool, and asserts `submitpackage` correctly reports `other-wtxid` pointing at the transaction already in the mempool, its existing, documented behavior, not something this change introduces.\nVerified the test can actually fail by temporarily asserting the wrong wtxid and confirmed it fails as expected.",
 "commits": [
  {
   "sha": "9054f7cde43a264300bb0567215bda5f55803ae5",
   "date": "2026-08-12T03:36:10Z",
   "message": "test: cover submitpackage other-wtxid for same-txid-diff-witness\n\nThe specific behaviour tied to the `// TODO: allow witness replacement in packages.` had no functional test anywhere, just the unit test coverage, showing the underlying mempool logic and not the RPC's actual JSON output.\nThis test submits a same-txid-different-witness transaction via `submitpackage` while its counterpart is already in the mempool, and asserts `submitpackage` correctly reports `other-wtxid` pointing at the transaction already in the mempool, its existing, documented behavior, not something this change introduces.\nVerified the test can actually fail by temporarily asserting the wrong wtxid and confirmed it fails as expected."
  }
 ],
 "timeline": [
  {
   "t": "2026-08-09T13:55:13Z",
   "kind": "comment",
   "who": "instagibbs",
   "assoc": "MEMBER",
   "text": "concept ack"
  },
  {
   "t": "2026-08-12T01:04:05Z",
   "kind": "review",
   "who": "jeanpablojp",
   "assoc": "NONE",
   "state": "COMMENTED",
   "commit": "ec8a53618ebb4c71f4f71ba282fb990e45e413fc",
   "text": "tACK ec8a53618ebb4c71f4f71ba282fb990e45e413fc"
  },
  {
   "t": "2026-08-12T01:04:05Z",
   "kind": "review_comment",
   "who": "jeanpablojp",
   "assoc": "NONE",
   "path": "test/functional/rpc_packages.py",
   "commit": "ec8a53618ebb4c71f4f71ba282fb990e45e413fc",
   "in_reply_to": null,
   "text": "this block isn't needed, the mempool takes child_one on the unconfirmed parent; deleted the line and re-ran to check. feel free to ignore"
  },
  {
   "t": "2026-08-12T03:37:31Z",
   "kind": "force_push",
   "who": "mercie-ux",
   "commit": "9054f7cde43a264300bb0567215bda5f55803ae5"
  },
  {
   "t": "2026-08-12T03:37:51Z",
   "kind": "review_comment",
   "who": "mercie-ux",
   "assoc": "NONE",
   "path": "test/functional/rpc_packages.py",
   "commit": "ec8a53618ebb4c71f4f71ba282fb990e45e413fc",
   "in_reply_to": 3762865452,
   "text": "removed it, thanks"
  },
  {
   "t": "2026-08-12T03:38:00Z",
   "kind": "review_comment",
   "who": "mercie-ux",
   "assoc": "NONE",
   "path": "test/functional/rpc_packages.py",
   "commit": "ec8a53618ebb4c71f4f71ba282fb990e45e413fc",
   "in_reply_to": 3762865452,
   "text": "removed it, thanks"
  },
  {
   "t": "2026-08-12T08:59:18Z",
   "kind": "comment",
   "who": "jeanpablojp",
   "assoc": "NONE",
   "text": "reACK 9054f7cde43a264300bb0567215bda5f55803ae5"
  }
 ],
 "labels_log": [
  {
   "t": "2026-08-05T06:50:08Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 1709,
 "text_tokens_estimate": 427,
 "changed_paths": [
  "test/functional/rpc_packages.py"
 ],
 "files": [
  {
   "path": "test/functional/rpc_packages.py",
   "add": 31,
   "del": 0
  }
 ],
 "test_lines": 31,
 "git": {
  "head": "9054f7cde43a264300bb0567215bda5f55803ae5",
  "head_matches_backup": true,
  "base": "67efced1fc83a0b7215cc1513e7c4754fee0f12f",
  "commits": [
   {
    "sha": "9054f7cde4",
    "subject": "test: cover submitpackage other-wtxid for same-txid-diff-witness",
    "files": 1,
    "add": 31,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "9324d766a8a36455",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}