{
 "number": 36023,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36023",
 "title": "build: Always define HAVE_SYSTEM",
 "author": "Sjors",
 "author_association": "MEMBER",
 "created_at": "2026-08-19T13:26:12Z",
 "updated_at": "2026-08-19T15:52:33Z",
 "age_days": 29,
 "draft": false,
 "labels": [
  "Build system"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "013fffe371f566387d4d386c21e6d3f9cfd92cf1",
 "head_ref": "2026/08/have-system",
 "head_repo": "Sjors/bitcoin",
 "head_history": [
  {
   "t": "2026-08-19T14:01:52Z",
   "sha": "34a31597ab862963b22c5e2300d8a78ec4c81dad"
  },
  {
   "t": "2026-08-19T14:06:05Z",
   "sha": "013fffe371f566387d4d386c21e6d3f9cfd92cf1"
  }
 ],
 "additions": 1,
 "deletions": 1,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "blocked",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {},
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fanquake",
   "hebasto",
   "maflcko"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "blocked",
  "last_author_activity": "2026-08-19T14:06:05Z",
  "last_reviewer_activity": "2026-08-19T13:46:00Z",
  "last_reviewer": "maflcko",
  "author_silent_days": 29,
  "waiting_on_author_days": 0,
  "days_since_update": 29
 },
 "refs": {
  "mentioned": [
   19803
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 19803,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2020-08-31",
    "title": "Bugfix: Define and use HAVE_FDATASYNC correctly outside LevelDB"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "When this feature is unavailable, `#cmakedefine` leaves its macro undefined, triggering `-Wundef`. I noticed this while building the kernel for iOs.\n\nUse `#cmakedefine01` to always generate 0 or 1.",
 "commits": [
  {
   "sha": "013fffe371f566387d4d386c21e6d3f9cfd92cf1",
   "date": "2026-08-19T14:05:48Z",
   "message": "build: Always define HAVE_SYSTEM\n\nWhen this feature is unavailable, #cmakedefine leaves its macro\nundefined, triggering -Wundef. Use #cmakedefine01 to always generate 0\nor 1."
  }
 ],
 "timeline": [
  {
   "t": "2026-08-19T13:35:32Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nPlease don't make random changes for no reason."
  },
  {
   "t": "2026-08-19T13:36:10Z",
   "kind": "comment",
   "who": "hebasto",
   "assoc": "MEMBER",
   "text": "Maybe simply revert 976b034b13d28877aee641833d5ee28a8cc5d83f?"
  },
  {
   "t": "2026-08-19T13:46:00Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "Ref: https://github.com/bitcoin/bitcoin/issues/16419\n\nCan we not use a single style and enforce it with a linter, similar to the `lint_includes_build_config` one?"
  },
  {
   "t": "2026-08-19T14:01:52Z",
   "kind": "force_push",
   "who": "Sjors",
   "commit": "34a31597ab862963b22c5e2300d8a78ec4c81dad"
  },
  {
   "t": "2026-08-19T14:04:49Z",
   "kind": "comment",
   "who": "Sjors",
   "assoc": "MEMBER",
   "text": "@fanquake I dropped `HAVE_FDATASYNC`. It was deliberately made this way in #19803 for some reason.\n\n@hebasto using `#if defined(HAVE_SYSTEM)` looks ugly imo, but it also risks someone using `#if HAVE_SYSTEM` accidentally."
  },
  {
   "t": "2026-08-19T14:06:05Z",
   "kind": "force_push",
   "who": "Sjors",
   "commit": "013fffe371f566387d4d386c21e6d3f9cfd92cf1"
  }
 ],
 "labels_log": [
  {
   "t": "2026-08-19T13:26:16Z",
   "action": "labeled",
   "label": "Build system",
   "who": "DrahtBot"
  },
  {
   "t": "2026-08-19T14:03:08Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-08-19T15:52:33Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-08-19T14:18:15Z",
   "kind": "renamed",
   "who": "Sjors",
   "from": "build: Always define HAVE_SYSTEM and HAVE_FDATASYNC",
   "to": "build: Always define HAVE_SYSTEM"
  }
 ],
 "text_chars": 924,
 "text_tokens_estimate": 231,
 "changed_paths": [
  "cmake/bitcoin-build-config.h.in"
 ],
 "files": [
  {
   "path": "cmake/bitcoin-build-config.h.in",
   "add": 1,
   "del": 1
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "013fffe371f566387d4d386c21e6d3f9cfd92cf1",
  "head_matches_backup": true,
  "base": "59224b66aa1db43adc61c15ee41b413951f22f80",
  "commits": [
   {
    "sha": "013fffe371",
    "subject": "build: Always define HAVE_SYSTEM",
    "files": 1,
    "add": 1,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "c97c85418d5c9fef",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}