{
 "number": 36052,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36052",
 "title": "ci: Doc: Move all config comments right next to the option they explain",
 "author": "maflcko",
 "author_association": "MEMBER",
 "created_at": "2026-08-21T11:19:23Z",
 "updated_at": "2026-09-09T11:33:28Z",
 "age_days": 27,
 "draft": false,
 "labels": [
  "Tests",
  "Needs rebase"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "fa03706fdef52e85b36b758c5867519acfc32a70",
 "head_ref": "2608-ci-doc-comments",
 "head_repo": "maflcko/bitcoin-core",
 "head_history": [],
 "additions": 101,
 "deletions": 99,
 "changed_files": 26,
 "commit_count": 2,
 "size_bucket": "M",
 "mergeable_state": "dirty",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "hebasto",
      "url": "https://github.com/bitcoin/bitcoin/pull/36052#pullrequestreview-4999968009"
     }
    ]
   },
   "conflicts": [
    {
     "number": 36033,
     "title": "[wip,nomerge,rfc] build: Require C++23 compiler",
     "author": "maflcko"
    },
    {
     "number": 35957,
     "title": "ci: Enable Boost.MultiIndex invariant-checking mode",
     "author": "hebasto"
    },
    {
     "number": 35468,
     "title": "ci, iwyu: Request IPC file generation explicitly",
     "author": "hebasto"
    },
    {
     "number": 33593,
     "title": "guix: Use UCRT runtime for Windows release binaries",
     "author": "hebasto"
    }
   ]
  }
 },
 "acks_parsed": {
  "hebasto": {
   "kind": "ack",
   "hash": "fa03706fdef52e85b36b758c5867519acfc32a70",
   "t": "2026-08-22T10:50:55Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "hebasto"
  ]
 },
 "signals": {
  "needs_rebase": true,
  "ci_failed": false,
  "mergeable_state": "dirty",
  "last_author_activity": "2026-08-21T11:18:27Z",
  "last_reviewer_activity": "2026-08-22T10:50:55Z",
  "last_reviewer": "hebasto",
  "author_silent_days": 27,
  "waiting_on_author_days": 26,
  "days_since_update": 8
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": [
   36033,
   35957,
   35468,
   33593
  ]
 },
 "stack": {
  "shares_commits_with": [
   36042
  ],
  "based_on": [],
  "base_for": [
   36042
  ]
 },
 "review_paths": [],
 "body": "This is a CI doc-style-cleanup. `BITCOIN_CONFIG` is a single manually-formatted large string. This is fine, but shellcheck doesn't like when trailing comments are added: `SC2155 -- Declare and assign separately`.\n\nFix this style by using `printf` to format the single string. The second commit then moves the comments right into (or next to) the line that it concerns.",
 "commits": [
  {
   "sha": "fa5c10acec151b69b941964e5bd0b7b0f0a939c3",
   "date": "2026-08-21T11:16:07Z",
   "message": "ci: refactor: Use printf %q quoting for BITCOIN_CONFIG\n\nThis refactor turns a long manually formatted and quoted string into one\nformatted and quoted by printf."
  },
  {
   "sha": "fa03706fdef52e85b36b758c5867519acfc32a70",
   "date": "2026-08-21T11:18:27Z",
   "message": "ci: Doc: Move all config comments right next to the option they explain"
  }
 ],
 "timeline": [
  {
   "t": "2026-08-22T10:50:55Z",
   "kind": "review",
   "who": "hebasto",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "fa03706fdef52e85b36b758c5867519acfc32a70",
   "text": "ACK fa03706fdef52e85b36b758c5867519acfc32a70."
  }
 ],
 "labels_log": [
  {
   "t": "2026-08-21T11:19:28Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-09T11:33:27Z",
   "action": "labeled",
   "label": "Needs rebase",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-08-21T11:19:27Z",
   "kind": "renamed",
   "who": "DrahtBot",
   "from": " ci: Doc: Move all config comments right next to the option they explain ",
   "to": "ci: Doc: Move all config comments right next to the option they explain"
  }
 ],
 "text_chars": 718,
 "text_tokens_estimate": 179,
 "changed_paths": [
  "ci/test/00_setup_env_arm.sh",
  "ci/test/00_setup_env_freebsd_cross.sh",
  "ci/test/00_setup_env_i686_no_ipc.sh",
  "ci/test/00_setup_env_mac_cross.sh",
  "ci/test/00_setup_env_mac_cross_intel.sh",
  "ci/test/00_setup_env_mac_native.sh",
  "ci/test/00_setup_env_mac_native_fuzz.sh",
  "ci/test/00_setup_env_native_alpine_musl.sh",
  "ci/test/00_setup_env_native_asan.sh",
  "ci/test/00_setup_env_native_chimera_lto.sh",
  "ci/test/00_setup_env_native_fuzz.sh",
  "ci/test/00_setup_env_native_fuzz_with_msan.sh",
  "ci/test/00_setup_env_native_fuzz_with_valgrind.sh",
  "ci/test/00_setup_env_native_iwyu.sh",
  "ci/test/00_setup_env_native_msan.sh",
  "ci/test/00_setup_env_native_nowallet.sh",
  "ci/test/00_setup_env_native_previous_releases.sh",
  "ci/test/00_setup_env_native_tidy.sh",
  "ci/test/00_setup_env_native_tsan.sh",
  "ci/test/00_setup_env_native_valgrind.sh",
  "ci/test/00_setup_env_netbsd_cross.sh",
  "ci/test/00_setup_env_openbsd_cross.sh",
  "ci/test/00_setup_env_riscv_bare_cross.sh",
  "ci/test/00_setup_env_s390x.sh",
  "ci/test/00_setup_env_win64.sh",
  "ci/test/00_setup_env_win64_msvcrt.sh"
 ],
 "files": [
  {
   "path": "ci/test/00_setup_env_arm.sh",
   "add": 5,
   "del": 5
  },
  {
   "path": "ci/test/00_setup_env_freebsd_cross.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_i686_no_ipc.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_mac_cross.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_mac_cross_intel.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_mac_native.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_mac_native_fuzz.sh",
   "add": 5,
   "del": 1
  },
  {
   "path": "ci/test/00_setup_env_native_alpine_musl.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_native_asan.sh",
   "add": 7,
   "del": 7
  },
  {
   "path": "ci/test/00_setup_env_native_chimera_lto.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_native_fuzz.sh",
   "add": 4,
   "del": 4
  },
  {
   "path": "ci/test/00_setup_env_native_fuzz_with_msan.sh",
   "add": 6,
   "del": 7
  },
  {
   "path": "ci/test/00_setup_env_native_fuzz_with_valgrind.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_native_iwyu.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_native_msan.sh",
   "add": 6,
   "del": 7
  },
  {
   "path": "ci/test/00_setup_env_native_nowallet.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_native_previous_releases.sh",
   "add": 8,
   "del": 8
  },
  {
   "path": "ci/test/00_setup_env_native_tidy.sh",
   "add": 4,
   "del": 4
  },
  {
   "path": "ci/test/00_setup_env_native_tsan.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_native_valgrind.sh",
   "add": 4,
   "del": 5
  },
  {
   "path": "ci/test/00_setup_env_netbsd_cross.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_openbsd_cross.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_riscv_bare_cross.sh",
   "add": 4,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_s390x.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_win64.sh",
   "add": 3,
   "del": 3
  },
  {
   "path": "ci/test/00_setup_env_win64_msvcrt.sh",
   "add": 3,
   "del": 3
  }
 ],
 "test_lines": 200,
 "git": {
  "head": "fa03706fdef52e85b36b758c5867519acfc32a70",
  "head_matches_backup": true,
  "base": "5e8586ec5b01abaa6289eee1b551245425e8fffb",
  "commits": [
   {
    "sha": "fa5c10acec",
    "subject": "ci: refactor: Use printf %q quoting for BITCOIN_CONFIG",
    "files": 26,
    "add": 95,
    "del": 90
   },
   {
    "sha": "fa03706fde",
    "subject": "ci: Doc: Move all config comments right next to the option they explain",
    "files": 6,
    "add": 9,
    "del": 12
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "5a97dfc2abf0c9ec",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}