{
 "number": 36206,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36206",
 "title": "build: drop use of `OBJC_OLD_DISPATCH_PROTOTYPES`",
 "author": "fanquake",
 "author_association": "MEMBER",
 "created_at": "2026-09-09T13:02:56Z",
 "updated_at": "2026-09-16T14:05:13Z",
 "age_days": 8,
 "draft": false,
 "labels": [
  "macOS",
  "Build system",
  "DrahtBot Guix build requested"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "59f7f3d07d9556fa2e9df2f39d8b9057ca87fdc2",
 "head_ref": "drop_OBJC_OLD_DISPATCH_PROTOTYPES",
 "head_repo": "fanquake/bitcoin",
 "head_history": [
  {
   "t": "2026-09-11T10:02:03Z",
   "sha": "2e2bd1869fceda386bc5d0a2c0e00410ac09592c"
  },
  {
   "t": "2026-09-16T13:41:06Z",
   "sha": "59f7f3d07d9556fa2e9df2f39d8b9057ca87fdc2"
  }
 ],
 "additions": 0,
 "deletions": 1,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "concept_ack": [
     {
      "login": "hebasto",
      "url": "https://github.com/bitcoin/bitcoin/pull/36206#pullrequestreview-5166472653"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "hebasto": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-09-10T11:26:17Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "hebasto"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-16T14:05:13Z",
  "last_reviewer_activity": "2026-09-10T11:26:17Z",
  "last_reviewer": "hebasto",
  "author_silent_days": 1,
  "waiting_on_author_days": 0,
  "days_since_update": 1
 },
 "refs": {
  "mentioned": [
   16720
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 16720,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2019-09-01",
    "title": "qt: Replace objc_msgSend() function calls with the native Objective-C syntax"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Now that we target macOS >= `14.0` and use macOS SDK `14.0`, and no-longer use `objc_msgSend`, this can be removed. Was added in #16720.",
 "commits": [
  {
   "sha": "59f7f3d07d9556fa2e9df2f39d8b9057ca87fdc2",
   "date": "2026-09-16T13:40:57Z",
   "message": "build: drop use of OBJC_OLD_DISPATCH_PROTOTYPES\n\nNow that we target macOS >= 14.0 and use macOS SDK 14.0, and no-longer\nuse objc_msgSend, this can be removed."
  }
 ],
 "timeline": [
  {
   "t": "2026-09-10T11:26:17Z",
   "kind": "review",
   "who": "hebasto",
   "assoc": "MEMBER",
   "state": "COMMENTED",
   "commit": "b7d1404ae4fbaebf371cf70e0d98f0918c029dda",
   "text": "Concept ACK.\n\nHere is a related [snippet](https://github.com/qt/qtbase/blob/ed77a3ca9ef1bf5e33b6f32ea41110734fb14e88/cmake/QtInternalTargets.cmake#L267-L270) from the Qt 6.8.4 codebase:\n```cmake\n        # Xcode 14's Clang will emit objc_msgSend stubs by default, which ld\n        # from earlier Xcode versions will fail to understand when linking\n        # against static libraries with these stubs. Disable the stubs explicitly,\n        # for as long as we do support Xcode < 14.\n```"
  },
  {
   "t": "2026-09-11T10:02:03Z",
   "kind": "force_push",
   "who": "fanquake",
   "commit": "2e2bd1869fceda386bc5d0a2c0e00410ac09592c"
  },
  {
   "t": "2026-09-16T13:41:06Z",
   "kind": "force_push",
   "who": "fanquake",
   "commit": "59f7f3d07d9556fa2e9df2f39d8b9057ca87fdc2"
  },
  {
   "t": "2026-09-16T14:05:13Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "Guix Build:\n```bash\nx86_64\n9563fcb440a63886389ff9c480ceef147797d03565545ee5f52836af72d2dd50  guix-build-59f7f3d07d95/output/arm64-apple-darwin/SHA256SUMS.part\nf3d38f62c4e57fb5a1960d26408cc26fa45142d1710976a5ba34e46f4510f43c  guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-codesigning.tar.gz\n372818871a447b17df671756d63ec231e1cbb069f504184b51910d7bde022853  guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-unsigned.tar.gz\n5937a8b22b43e92846f6d77aa68eee44a339678c169ef9615f9828f764a30c0b  guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-unsigned.zip\nfcc723c484f7491f74b21aa0b95cad3c542411f66aafa971f83c931dc0899fc8  guix-build-59f7f3d07d95/output/dist-archive/bitcoin-59f7f3d07d95.tar.gz\n87cfd971cad29007ac55aed0a32fda34942a618f0d9857c5d5efc53c7aca9ac1  guix-build-59f7f3d07d95/output/x86_64-apple-darwin/SHA256SUMS.part\n2308d14ee2ea00f4a938908d18e337def2246091618c14e0131607c632996a57  guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-codesigning.tar.gz\ncad9997a879197adacebfd43c6ccced6451d2942adbe1a19b30d9c3df24d4d7c  guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-unsigned.tar.gz\n3e5d5bf5296ac4c6bf9a50b41e5f3e1655040fbd1487c9a27c62a473e5c74fe0  guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-unsigned.zip\n```"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-09T13:03:00Z",
   "action": "labeled",
   "label": "Build system",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-09T13:09:53Z",
   "action": "labeled",
   "label": "macOS",
   "who": "fanquake"
  },
  {
   "t": "2026-09-09T13:09:53Z",
   "action": "labeled",
   "label": "Android",
   "who": "fanquake"
  },
  {
   "t": "2026-09-09T13:09:59Z",
   "action": "unlabeled",
   "label": "Android",
   "who": "fanquake"
  },
  {
   "t": "2026-09-16T13:51:13Z",
   "action": "labeled",
   "label": "DrahtBot Guix build requested",
   "who": "maflcko"
  }
 ],
 "state_log": [],
 "text_chars": 2303,
 "text_tokens_estimate": 575,
 "changed_paths": [
  "CMakeLists.txt"
 ],
 "files": [
  {
   "path": "CMakeLists.txt",
   "add": 0,
   "del": 1
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "59f7f3d07d9556fa2e9df2f39d8b9057ca87fdc2",
  "head_matches_backup": true,
  "base": "b8215855437288cac95c7fd5d41104c73c0f3495",
  "commits": [
   {
    "sha": "59f7f3d07d",
    "subject": "build: drop use of OBJC_OLD_DISPATCH_PROTOTYPES",
    "files": 1,
    "add": 0,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "5d64cf93790deb8e",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}