{
 "number": 36229,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36229",
 "title": "test: Cover AddrMan add edge cases",
 "author": "mertsaner",
 "author_association": "FIRST_TIME_CONTRIBUTOR",
 "created_at": "2026-09-11T16:31:37Z",
 "updated_at": "2026-09-13T08:33:26Z",
 "age_days": 5,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "02161b94dfcca42eeecc155e56c2edaf791087de",
 "head_ref": "test/addrman-add-edge-cases",
 "head_repo": "mertsaner/bitcoin",
 "head_history": [
  {
   "t": "2026-09-11T16:32:35Z",
   "sha": "ba34bb4e5dff86cac035b8f87c3fbd7ebfb072b9"
  },
  {
   "t": "2026-09-12T05:47:19Z",
   "sha": "02161b94dfcca42eeecc155e56c2edaf791087de"
  }
 ],
 "additions": 164,
 "deletions": 0,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "M",
 "mergeable_state": "unstable",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {},
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "brunoerg"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "unstable",
  "last_author_activity": "2026-09-12T05:47:19Z",
  "last_reviewer_activity": "2026-09-11T19:46:19Z",
  "last_reviewer": "brunoerg",
  "author_silent_days": 5,
  "waiting_on_author_days": 0,
  "days_since_update": 4
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Add focused unit tests for meaningful AddrMan::Add edge cases without changing production behavior.\n\nThe tests cover:\n\nempty and rejected batches;\nmixed batches containing rejected and valid addresses;\nduplicate records within a batch;\nrejection of unroutable addresses;\ntimestamp penalty clamping at zero;\none-hour and 24-hour timestamp update boundaries using a deterministic fake clock;\npreservation of source-derived bucket placement across newer announcements;\npreservation of tried-table membership for newer records; and\nservice flags being merged without removing previously known capabilities.",
 "commits": [
  {
   "sha": "02161b94dfcca42eeecc155e56c2edaf791087de",
   "date": "2026-09-12T05:47:17Z",
   "message": "test: Cover AddrMan add edge cases\n\nExercise empty and rejected batches, timestamp boundaries, penalties, source bucket stability, and tried address updates in AddrMan."
  }
 ],
 "timeline": [
  {
   "t": "2026-09-11T16:32:35Z",
   "kind": "force_push",
   "who": "mertsaner",
   "commit": "ba34bb4e5dff86cac035b8f87c3fbd7ebfb072b9"
  },
  {
   "t": "2026-09-11T19:46:19Z",
   "kind": "comment",
   "who": "brunoerg",
   "assoc": "MEMBER",
   "text": "corecheck doesn't show any gained coverage, can you tell us what these edge cases are addressing in practice? any mutation?"
  },
  {
   "t": "2026-09-12T05:47:19Z",
   "kind": "force_push",
   "who": "mertsaner",
   "commit": "02161b94dfcca42eeecc155e56c2edaf791087de"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-11T16:31:41Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 931,
 "text_tokens_estimate": 232,
 "changed_paths": [
  "src/test/addrman_tests.cpp"
 ],
 "files": [
  {
   "path": "src/test/addrman_tests.cpp",
   "add": 164,
   "del": 0
  }
 ],
 "test_lines": 164,
 "git": {
  "head": "02161b94dfcca42eeecc155e56c2edaf791087de",
  "head_matches_backup": true,
  "base": "f3fec67c3eeb27d5be1bc9d57ca737b74fcd762d",
  "commits": [
   {
    "sha": "02161b94df",
    "subject": "test: Cover AddrMan add edge cases",
    "files": 1,
    "add": 164,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "c11a1540570a7af3",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}