{
 "number": 36262,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36262",
 "title": "test: cover orphan reconsideration interruptibility",
 "author": "ViniciusCestarii",
 "author_association": "CONTRIBUTOR",
 "created_at": "2026-09-15T15:03:36Z",
 "updated_at": "2026-09-16T13:15:01Z",
 "age_days": 2,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "1ad8b857fa76ec5c8173fe41db2fcdd998bf3e9d",
 "head_ref": "test-orphan_reconsideration_interruptible",
 "head_repo": "ViniciusCestarii/bitcoin",
 "head_history": [
  {
   "t": "2026-09-15T16:38:52Z",
   "sha": "1ad8b857fa76ec5c8173fe41db2fcdd998bf3e9d"
  }
 ],
 "additions": 72,
 "deletions": 0,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "concept_ack": [
     {
      "login": "instagibbs",
      "url": "https://github.com/bitcoin/bitcoin/pull/36262#issuecomment-5698063281"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "instagibbs": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-09-16T13:14:57Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "instagibbs"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-15T16:38:52Z",
  "last_reviewer_activity": "2026-09-16T13:14:57Z",
  "last_reviewer": "instagibbs",
  "author_silent_days": 1,
  "waiting_on_author_days": 1,
  "days_since_update": 1
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Add test checking that ProcessOrphanTx reconsiders at most one orphan per ProcessMessages(). This test prevents regression of [CVE-2024-52914](https://bitcoincore.org/en/2024/07/03/disclose-orphan-dos/) which currently no existing test checks.\n\nThe test kills 2 mutants found with https://github.com/ViniciusCestarii/mutant-harness:\n\n1. Remove <code>return true</code> after an orphan is accepted\n\n```diff\n--- a/src/net_processing.cpp\n+++ b/src/net_processing.cpp\n@@ -3494,7 +3494,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)\n         if (result.m_result_type == MempoolAcceptResult::ResultType::VALID) {\n             LogDebug(BCLog::TXPACKAGES, \"   accepted orphan tx %s (wtxid=%s)\\n\", orphanHash.ToString(), orphan_wtxid.ToString());\n             ProcessValidTx(peer.m_id, porphanTx, result.m_replaced_transactions);\n-            return true;\n         } else if (state.GetResult() != TxValidationResult::TX_MISSING_INPUTS) {\n```\n\n2. Remove <code>return true</code> after an orphan is rejected for a reason other than <code>TX_MISSING_INPUTS</code>\n\n```diff\n--- a/src/net_processing.cpp\n+++ b/src/net_processing.cpp\n@@ -3508,7 +3508,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)\n          state.GetResult() != TxValidationResult::TX_RESULT_UNSET)) {\n                 ProcessInvalidTx(peer.m_id, porphanTx, state, /*first_time_failure=*/false);\n             }\n-            return true;\n         }\n     }\n```",
 "commits": [
  {
   "sha": "1ad8b857fa76ec5c8173fe41db2fcdd998bf3e9d",
   "date": "2026-09-15T16:38:44Z",
   "message": "test: cover orphan reconsideration interruptibility"
  }
 ],
 "timeline": [
  {
   "t": "2026-09-15T16:38:52Z",
   "kind": "force_push",
   "who": "ViniciusCestarii",
   "commit": "1ad8b857fa76ec5c8173fe41db2fcdd998bf3e9d"
  },
  {
   "t": "2026-09-16T13:14:57Z",
   "kind": "comment",
   "who": "instagibbs",
   "assoc": "MEMBER",
   "text": "concept ACK"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-15T15:03:40Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-15T16:04:09Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-15T17:43:51Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-09-15T16:38:01Z",
   "kind": "convert_to_draft",
   "who": "ViniciusCestarii"
  },
  {
   "t": "2026-09-15T17:06:10Z",
   "kind": "ready_for_review",
   "who": "ViniciusCestarii"
  }
 ],
 "text_chars": 1542,
 "text_tokens_estimate": 385,
 "changed_paths": [
  "src/test/denialofservice_tests.cpp"
 ],
 "files": [
  {
   "path": "src/test/denialofservice_tests.cpp",
   "add": 72,
   "del": 0
  }
 ],
 "test_lines": 72,
 "git": {
  "head": "1ad8b857fa76ec5c8173fe41db2fcdd998bf3e9d",
  "head_matches_backup": true,
  "base": "dadca55f60ad1e756bd9ad88351729f0e6af2181",
  "commits": [
   {
    "sha": "1ad8b857fa",
    "subject": "test: cover orphan reconsideration interruptibility",
    "files": 1,
    "add": 72,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "5b7cd5689d9c550e",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}