{
 "number": 36268,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36268",
 "title": "refactor: prune unused semi-colons",
 "author": "fanquake",
 "author_association": "MEMBER",
 "created_at": "2026-09-16T09:58:06Z",
 "updated_at": "2026-09-16T10:21:36Z",
 "age_days": 1,
 "draft": true,
 "labels": [
  "Refactoring",
  "CI failed"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "c3e94cab4b8685802dd5ecfa5ac495babb91310c",
 "head_ref": "extra_semicolons",
 "head_repo": "fanquake/bitcoin",
 "head_history": [
  {
   "t": "2026-09-16T10:21:01Z",
   "sha": "c3e94cab4b8685802dd5ecfa5ac495babb91310c"
  }
 ],
 "additions": 97,
 "deletions": 95,
 "changed_files": 62,
 "commit_count": 4,
 "size_bucket": "M",
 "mergeable_state": "unstable",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {},
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": []
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": true,
  "mergeable_state": "unstable",
  "last_author_activity": "2026-09-16T10:21:01Z",
  "last_reviewer_activity": null,
  "last_reviewer": null,
  "author_silent_days": 1,
  "waiting_on_author_days": 0,
  "days_since_update": 1
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Enable [`-Wextra-semi`](https://clang.llvm.org/docs/DiagnosticsReference.html#wextra-semi) and delete all the redundant semicolons.\n\nWaiting on a pull of the libmultiprocess subtree.",
 "commits": [
  {
   "sha": "86790fb8d6ef2caf830cae8cae9648e0ca1fa5d9",
   "date": "2026-09-16T09:36:49Z",
   "message": "[nomerge] libmultiprocess fixups\n\nThese will be pulled in with the next subtree update."
  },
  {
   "sha": "b736aab404cff6f018e542a20433e9fd155f179a",
   "date": "2026-09-16T09:36:49Z",
   "message": "refactor: prevent trailing semi warning on TRACEPOINT_SEMAPHORE"
  },
  {
   "sha": "b3dc9e6e6b84940974a09f95bf416da73f94e021",
   "date": "2026-09-16T10:20:49Z",
   "message": "refactor: remove redundant semicolons"
  },
  {
   "sha": "c3e94cab4b8685802dd5ecfa5ac495babb91310c",
   "date": "2026-09-16T10:20:53Z",
   "message": "build: add -Wextra-semi to warn flags"
  }
 ],
 "timeline": [
  {
   "t": "2026-09-16T10:21:01Z",
   "kind": "force_push",
   "who": "fanquake",
   "commit": "c3e94cab4b8685802dd5ecfa5ac495babb91310c"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-16T09:58:10Z",
   "action": "labeled",
   "label": "Refactoring",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-16T10:21:32Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 445,
 "text_tokens_estimate": 111,
 "changed_paths": [
  "CMakeLists.txt",
  "src/addresstype.h",
  "src/bench/coin_selection.cpp",
  "src/blockencodings.h",
  "src/crypto/muhash.h",
  "src/cuckoocache.h",
  "src/dbwrapper.cpp",
  "src/dbwrapper.h",
  "src/headerssync.h",
  "src/index/blockfilterindex.cpp",
  "src/index/coinstatsindex.cpp",
  "src/init.cpp",
  "src/ipc/capnp/protocol.cpp",
  "src/ipc/libmultiprocess/include/mp/proxy-types.h",
  "src/ipc/libmultiprocess/include/mp/type-function.h",
  "src/logging.h",
  "src/merkleblock.h",
  "src/net.h",
  "src/net_processing.cpp",
  "src/netaddress.cpp",
  "src/netbase.h",
  "src/node/eviction.cpp",
  "src/node/interfaces.cpp",
  "src/node/kernel_notifications.cpp",
  "src/node/mempool_args.h",
  "src/primitives/transaction.h",
  "src/protocol.h",
  "src/qt/addresstablemodel.cpp",
  "src/qt/notificator.cpp",
  "src/qt/splashscreen.h",
  "src/random.h",
  "src/rpc/request.h",
  "src/script/miniscript.h",
  "src/serialize.h",
  "src/test/checkqueue_tests.cpp",
  "src/test/cuckoocache_tests.cpp",
  "src/test/fuzz/kitchen_sink.cpp",
  "src/test/fuzz/muhash.cpp",
  "src/test/fuzz/rpc.cpp",
  "src/test/fuzz/socks5.cpp",
  "src/test/pcp_tests.cpp",
  "src/test/rpc_tests.cpp",
  "src/test/settings_tests.cpp",
  "src/test/util/coins.cpp",
  "src/test/util/net.h",
  "src/test/util/setup_common.cpp",
  "src/txmempool.h",
  "src/txrequest.cpp",
  "src/util/check.h",
  "src/util/fs.h",
  "src/util/sock.cpp",
  "src/util/time.cpp",
  "src/util/trace.h",
  "src/validation.h",
  "src/validationinterface.h",
  "src/wallet/scan.h",
  "src/wallet/scriptpubkeyman.h",
  "src/wallet/spend.cpp",
  "src/wallet/test/fuzz/scriptpubkeyman.cpp",
  "src/wallet/test/util.cpp",
  "src/wallet/test/walletload_tests.cpp",
  "src/wallet/wallet.h"
 ],
 "files": [
  {
   "path": "CMakeLists.txt",
   "add": 1,
   "del": 0
  },
  {
   "path": "src/addresstype.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/bench/coin_selection.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/blockencodings.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/crypto/muhash.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/cuckoocache.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/dbwrapper.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/dbwrapper.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/headerssync.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/index/blockfilterindex.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/index/coinstatsindex.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/init.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/ipc/capnp/protocol.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/ipc/libmultiprocess/include/mp/proxy-types.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/ipc/libmultiprocess/include/mp/type-function.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/logging.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/merkleblock.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/net.h",
   "add": 6,
   "del": 6
  },
  {
   "path": "src/net_processing.cpp",
   "add": 4,
   "del": 4
  },
  {
   "path": "src/netaddress.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/netbase.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/node/eviction.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/node/interfaces.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/node/kernel_notifications.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/node/mempool_args.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/primitives/transaction.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/protocol.h",
   "add": 4,
   "del": 4
  },
  {
   "path": "src/qt/addresstablemodel.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/qt/notificator.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/qt/splashscreen.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/random.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/rpc/request.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/script/miniscript.h",
   "add": 4,
   "del": 4
  },
  {
   "path": "src/serialize.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/checkqueue_tests.cpp",
   "add": 5,
   "del": 5
  },
  {
   "path": "src/test/cuckoocache_tests.cpp",
   "add": 3,
   "del": 3
  },
  {
   "path": "src/test/fuzz/kitchen_sink.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/fuzz/muhash.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/fuzz/rpc.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/fuzz/socks5.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/pcp_tests.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/rpc_tests.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/settings_tests.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/util/coins.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/util/net.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/util/setup_common.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/txmempool.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/txrequest.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/util/check.h",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/util/fs.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/util/sock.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/util/time.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/util/trace.h",
   "add": 3,
   "del": 1
  },
  {
   "path": "src/validation.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/validationinterface.h",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/wallet/scan.h",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/wallet/scriptpubkeyman.h",
   "add": 3,
   "del": 3
  },
  {
   "path": "src/wallet/spend.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/wallet/test/fuzz/scriptpubkeyman.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/wallet/test/util.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/wallet/test/walletload_tests.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/wallet/wallet.h",
   "add": 6,
   "del": 7
  }
 ],
 "test_lines": 46,
 "git": {
  "head": "c3e94cab4b8685802dd5ecfa5ac495babb91310c",
  "head_matches_backup": true,
  "base": "7dedc4545a495ab6725a2a36cec2b6a1a9bf8dbf",
  "commits": [
   {
    "sha": "86790fb8d6",
    "subject": "[nomerge] libmultiprocess fixups",
    "files": 2,
    "add": 2,
    "del": 2
   },
   {
    "sha": "b736aab404",
    "subject": "refactor: prevent trailing semi warning on TRACEPOINT_SEMAPHORE",
    "files": 1,
    "add": 3,
    "del": 1
   },
   {
    "sha": "b3dc9e6e6b",
    "subject": "refactor: remove redundant semicolons",
    "files": 58,
    "add": 91,
    "del": 92
   },
   {
    "sha": "c3e94cab4b",
    "subject": "build: add -Wextra-semi to warn flags",
    "files": 1,
    "add": 1,
    "del": 0
   }
  ],
  "patch_truncated": true
 },
 "input_hash": "222a4beae98f18e7",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}