{
 "number": 36271,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36271",
 "title": "Revert #36057 & document mingw-w64 requirement",
 "author": "fanquake",
 "author_association": "MEMBER",
 "created_at": "2026-09-16T12:36:44Z",
 "updated_at": "2026-09-16T19:28:37Z",
 "age_days": 1,
 "draft": false,
 "labels": [],
 "milestone": null,
 "base": "master",
 "head_sha": "ce76c082cead6a107d1c95f584a0eff390b3539f",
 "head_ref": "revert_36057",
 "head_repo": "fanquake/bitcoin",
 "head_history": [
  {
   "t": "2026-09-16T13:50:45Z",
   "sha": "bc63b069143b1c5cba083a6573c9c0d9c2e7b219"
  },
  {
   "t": "2026-09-16T14:03:52Z",
   "sha": "ce76c082cead6a107d1c95f584a0eff390b3539f"
  }
 ],
 "additions": 5,
 "deletions": 19,
 "changed_files": 6,
 "commit_count": 3,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "ViniciusCestarii",
      "url": "https://github.com/bitcoin/bitcoin/pull/36271#pullrequestreview-5227376196"
     }
    ],
    "concept_ack": [
     {
      "login": "hebasto",
      "url": "https://github.com/bitcoin/bitcoin/pull/36271#pullrequestreview-5225833101"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "hebasto": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-09-16T17:07:41Z",
   "stale": false
  },
  "ViniciusCestarii": {
   "kind": "ack",
   "hash": "ce76c082cead6a107d1c95f584a0eff390b3539f",
   "t": "2026-09-16T19:28:33Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "ViniciusCestarii",
   "hebasto",
   "maflcko"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-16T14:07:18Z",
  "last_reviewer_activity": "2026-09-16T19:28:33Z",
  "last_reviewer": "ViniciusCestarii",
  "author_silent_days": 1,
  "waiting_on_author_days": 0,
  "days_since_update": 0
 },
 "refs": {
  "mentioned": [
   32380,
   36057
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 36057,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-08-27",
    "title": "build: check for SetThreadDescription() at configure time"
   },
   {
    "number": 32380,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2025-10-28",
    "title": "Modernize use of UTF-8 in Windows code"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "depends/README.md"
 ],
 "body": "A follow-up reverting #36057, now that we've branched off for `33.x`.\nAlso documents `mingw-w64` requirements (#32380).",
 "commits": [
  {
   "sha": "e394ba6dae51ec0bcf8a41df5dbeef8fb706b702",
   "date": "2026-09-16T12:31:04Z",
   "message": "Revert \"build: check for SetThreadDescription() at configure time\"\n\nThis reverts commit bed46bd16c2b34eec62849b96cebbbdbcdd2c1ac."
  },
  {
   "sha": "93ae95aeca9ab6a08cb85313eaf25d1246e04532",
   "date": "2026-09-16T13:50:06Z",
   "message": "doc: document mingw-w64 requirement in Windows build docs"
  },
  {
   "sha": "ce76c082cead6a107d1c95f584a0eff390b3539f",
   "date": "2026-09-16T14:03:30Z",
   "message": "nix: drop MSVCRT build"
  }
 ],
 "timeline": [
  {
   "t": "2026-09-16T13:50:45Z",
   "kind": "force_push",
   "who": "fanquake",
   "commit": "bc63b069143b1c5cba083a6573c9c0d9c2e7b219"
  },
  {
   "t": "2026-09-16T14:01:24Z",
   "kind": "review_comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "path": "depends/README.md",
   "commit": "bc63b069143b1c5cba083a6573c9c0d9c2e7b219",
   "in_reply_to": null,
   "text": "I think this one can be removed as well now:\n\n```diff\ndiff --git a/contrib/devtools/shell-win64-cross.nix b/contrib/devtools/shell-win64-cross.nix\nindex 4fd83b0..7e0da92 100644\n--- a/contrib/devtools/shell-win64-cross.nix\n+++ b/contrib/devtools/shell-win64-cross.nix\n@@ -10,8 +10,3 @@\n let\n-  host = builtins.getEnv \"HOST\";\n-  crossPkgs = if host == \"x86_64-w64-mingw32ucrt\"\n-    then pkgs.pkgsCross.ucrt64\n-    else if host == \"x86_64-w64-mingw32\"\n-      then pkgs.pkgsCross.mingwW64\n-      else throw \"Unsupported HOST: ${host}\";\n+  crossPkgs = pkgs.pkgsCross.ucrt64;\n   toolchain = crossPkgs.stdenv.cc.targetPrefix;\ndiff --git a/depends/README.md b/depends/README.md\nindex 3cee78a..f17bcab 100644\n--- a/depends/README.md\n+++ b/depends/README.md\n@@ -169,4 +169,3 @@ you may install `nix-bin` and use the Nix shell from the repository root:\n     apt install nix-bin\n-    NIX_BUILD_SHELL=bash HOST=x86_64-w64-mingw32ucrt nix-shell contrib/devtools/shell-win64-cross.nix  # UCRT\n+    NIX_BUILD_SHELL=bash nix-shell contrib/devtools/shell-win64-cross.nix"
  },
  {
   "t": "2026-09-16T14:03:52Z",
   "kind": "force_push",
   "who": "fanquake",
   "commit": "ce76c082cead6a107d1c95f584a0eff390b3539f"
  },
  {
   "t": "2026-09-16T14:07:18Z",
   "kind": "review_comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "path": "depends/README.md",
   "commit": "bc63b069143b1c5cba083a6573c9c0d9c2e7b219",
   "in_reply_to": 4026896061,
   "text": "Sure, dropped."
  },
  {
   "t": "2026-09-16T17:07:41Z",
   "kind": "review",
   "who": "hebasto",
   "assoc": "MEMBER",
   "state": "COMMENTED",
   "commit": "ce76c082cead6a107d1c95f584a0eff390b3539f",
   "text": "Concept ACK. This follows the [plan](https://github.com/bitcoin/bitcoin/pull/36057#issuecomment-5450203081)."
  },
  {
   "t": "2026-09-16T19:28:33Z",
   "kind": "review",
   "who": "ViniciusCestarii",
   "assoc": "CONTRIBUTOR",
   "state": "COMMENTED",
   "commit": "ce76c082cead6a107d1c95f584a0eff390b3539f",
   "text": "ACK ce76c082cead6a107d1c95f584a0eff390b3539f"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-16T14:05:07Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-16T15:35:52Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 1600,
 "text_tokens_estimate": 400,
 "changed_paths": [
  "cmake/bitcoin-build-config.h.in",
  "cmake/introspection.cmake",
  "contrib/devtools/shell-win64-cross.nix",
  "depends/README.md",
  "doc/build-windows.md",
  "src/util/threadnames.cpp"
 ],
 "files": [
  {
   "path": "cmake/bitcoin-build-config.h.in",
   "add": 0,
   "del": 3
  },
  {
   "path": "cmake/introspection.cmake",
   "add": 0,
   "del": 4
  },
  {
   "path": "contrib/devtools/shell-win64-cross.nix",
   "add": 1,
   "del": 6
  },
  {
   "path": "depends/README.md",
   "add": 1,
   "del": 2
  },
  {
   "path": "doc/build-windows.md",
   "add": 1,
   "del": 0
  },
  {
   "path": "src/util/threadnames.cpp",
   "add": 2,
   "del": 4
  }
 ],
 "test_lines": 7,
 "git": {
  "head": "ce76c082cead6a107d1c95f584a0eff390b3539f",
  "head_matches_backup": true,
  "base": "b8215855437288cac95c7fd5d41104c73c0f3495",
  "commits": [
   {
    "sha": "e394ba6dae",
    "subject": "Revert \"build: check for SetThreadDescription() at configure time\"",
    "files": 3,
    "add": 2,
    "del": 11
   },
   {
    "sha": "93ae95aeca",
    "subject": "doc: document mingw-w64 requirement in Windows build docs",
    "files": 1,
    "add": 1,
    "del": 0
   },
   {
    "sha": "ce76c082ce",
    "subject": "nix: drop MSVCRT build",
    "files": 2,
    "add": 2,
    "del": 8
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "6121b2ececdd8e51",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}