{
 "number": 36277,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36277",
 "title": "net: always complete all initial private broadcast connections",
 "author": "andrewtoth",
 "author_association": "MEMBER",
 "created_at": "2026-09-16T16:47:37Z",
 "updated_at": "2026-09-16T17:08:01Z",
 "age_days": 0,
 "draft": false,
 "labels": [
  "P2P"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "e4204baff71dfef93597ce5c92ee8111b5b380b0",
 "head_ref": "always_send",
 "head_repo": "andrewtoth/bitcoin",
 "head_history": [],
 "additions": 208,
 "deletions": 22,
 "changed_files": 7,
 "commit_count": 1,
 "size_bucket": "M",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "concept_ack": [
     {
      "login": "vasild",
      "url": "https://github.com/bitcoin/bitcoin/pull/36277#issuecomment-5701439844"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "vasild": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-09-16T17:07:58Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "vasild"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-16T16:41:38Z",
  "last_reviewer_activity": "2026-09-16T17:07:58Z",
  "last_reviewer": "vasild",
  "author_silent_days": 0,
  "waiting_on_author_days": 0,
  "days_since_update": 0
 },
 "refs": {
  "mentioned": [
   34707
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 34707,
    "type": "pull",
    "state": "open",
    "merged": false,
    "merged_at": null,
    "title": "net: keep finished private broadcast txs in memory"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Make sure we send out all three connections when initiating a private broadcast.\n\nUse `MarkReceived` instead of `Remove` to mark a tx as having been received back. Prevent additional stale retry connections by tracking disconnects and explicitly granting new connections with `TryGrantRetry`.\n\nIntended as an alternative to #34707, addressing the theoretical timing attack described in https://github.com/bitcoin/bitcoin/pull/34707#issuecomment-5603256702. Also fixes theoretical timing attacks described in https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2035693786. This is based on the idea described in https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2037527330:\n\n[quoted text omitted]",
 "commits": [
  {
   "sha": "e4204baff71dfef93597ce5c92ee8111b5b380b0",
   "date": "2026-09-16T16:41:38Z",
   "message": "net: always complete all initial private broadcast connections\n\nMake sure we send out all three connections when intiating a private broadcast.\n\nUse MarkReceived instead of Remove to mark a tx as having been received back.\nPrevent additional stale retry connections by tracking disconnects and explicitly granting new connections with TryGrantRetry."
  }
 ],
 "timeline": [
  {
   "t": "2026-09-16T17:07:58Z",
   "kind": "comment",
   "who": "vasild",
   "assoc": "MEMBER",
   "text": "Concept ACK, will review"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-16T16:47:42Z",
   "action": "labeled",
   "label": "P2P",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 1146,
 "text_tokens_estimate": 286,
 "changed_paths": [
  "src/net_processing.cpp",
  "src/private_broadcast.cpp",
  "src/private_broadcast.h",
  "src/test/fuzz/private_broadcast.cpp",
  "src/test/private_broadcast_tests.cpp",
  "test/functional/p2p_private_broadcast_completion.py",
  "test/functional/test_runner.py"
 ],
 "files": [
  {
   "path": "src/net_processing.cpp",
   "add": 12,
   "del": 14
  },
  {
   "path": "src/private_broadcast.cpp",
   "add": 41,
   "del": 4
  },
  {
   "path": "src/private_broadcast.h",
   "add": 33,
   "del": 0
  },
  {
   "path": "src/test/fuzz/private_broadcast.cpp",
   "add": 15,
   "del": 4
  },
  {
   "path": "src/test/private_broadcast_tests.cpp",
   "add": 28,
   "del": 0
  },
  {
   "path": "test/functional/p2p_private_broadcast_completion.py",
   "add": 78,
   "del": 0
  },
  {
   "path": "test/functional/test_runner.py",
   "add": 1,
   "del": 0
  }
 ],
 "test_lines": 126,
 "git": {
  "head": "e4204baff71dfef93597ce5c92ee8111b5b380b0",
  "head_matches_backup": true,
  "base": "57721f8074c2e8ccfe4c6d10114d4683dca58118",
  "commits": [
   {
    "sha": "e4204baff7",
    "subject": "net: always complete all initial private broadcast connections",
    "files": 7,
    "add": 208,
    "del": 22
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "948e0a2ebafd484e",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}