{
 "number": 36283,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36283",
 "title": "kernel: expose transaction version",
 "author": "nervana21",
 "author_association": "CONTRIBUTOR",
 "created_at": "2026-09-17T01:54:57Z",
 "updated_at": "2026-09-17T12:02:35Z",
 "age_days": 0,
 "draft": false,
 "labels": [
  "Validation"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "4397e8647a27d40fbc26d29b17bbedded5692009",
 "head_ref": "kernel-tx-version",
 "head_repo": "nervana21/bitcoin",
 "head_history": [],
 "additions": 29,
 "deletions": 0,
 "changed_files": 4,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "concept_ack": [
     {
      "login": "yuvicc",
      "url": "https://github.com/bitcoin/bitcoin/pull/36283#issuecomment-5714018337"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "yuvicc": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-09-17T12:02:31Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "stickies-v",
   "yuvicc"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-17T01:55:28Z",
  "last_reviewer_activity": "2026-09-17T12:02:31Z",
  "last_reviewer": "yuvicc",
  "author_silent_days": 0,
  "waiting_on_author_days": 0,
  "days_since_update": 0
 },
 "refs": {
  "mentioned": [
   36194,
   36207
  ],
  "depends_on": [
   36194
  ],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 36194,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-09-16",
    "title": "kernel: expose block header Merkle root"
   },
   {
    "number": 36207,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-09-15",
    "title": "kernel: add wtxid accessor"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "src/test/kernel/test_kernel.cpp"
 ],
 "body": "This PR is a follow-up to #36194 and #36207. It completes the existing set of transaction accessors allowing clients to read the transaction version without slicing serialized bytes.\n\nTests cover a range of versions.",
 "commits": [
  {
   "sha": "4397e8647a27d40fbc26d29b17bbedded5692009",
   "date": "2026-09-16T21:45:39Z",
   "message": "kernel: expose transaction version\n\nExpose CTransaction::version, allowing clients to read the transaction\nversion without slicing serialized bytes.\n\nTest the accessor against a range of transaction versions."
  }
 ],
 "timeline": [
  {
   "t": "2026-09-17T01:55:28Z",
   "kind": "comment",
   "who": "nervana21",
   "assoc": "CONTRIBUTOR",
   "text": "cc:\n@lucasdbr05\n@KY-U"
  },
  {
   "t": "2026-09-17T09:40:10Z",
   "kind": "review_comment",
   "who": "stickies-v",
   "assoc": "MEMBER",
   "path": "src/test/kernel/test_kernel.cpp",
   "commit": "4397e8647a27d40fbc26d29b17bbedded5692009",
   "in_reply_to": null,
   "text": "We try to keep dependencies for test_kernel on internal headers minimal, so in that light including `crypto/common.h` just to write a byte seems excessive. Perhaps concatenating strings or something like `tx_data[i] = std::byte(version >> (8 * i))` could be an alternative?\n\nAlso, transaction version is a scalar member like locktime etc. I think this can just be folded into `btck_transaction_tests`."
  },
  {
   "t": "2026-09-17T09:40:50Z",
   "kind": "review",
   "who": "stickies-v",
   "assoc": "MEMBER",
   "state": "COMMENTED",
   "commit": "4397e8647a27d40fbc26d29b17bbedded5692009",
   "text": "Code LGTM 4397e8647a27d40fbc26d29b17bbedded5692009 but test should be improved a bit"
  },
  {
   "t": "2026-09-17T12:02:31Z",
   "kind": "comment",
   "who": "yuvicc",
   "assoc": "CONTRIBUTOR",
   "text": "Concept ACK"
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-17T01:55:01Z",
   "action": "labeled",
   "label": "Validation",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 980,
 "text_tokens_estimate": 245,
 "changed_paths": [
  "src/kernel/bitcoinkernel.cpp",
  "src/kernel/bitcoinkernel.h",
  "src/kernel/bitcoinkernel_wrapper.h",
  "src/test/kernel/test_kernel.cpp"
 ],
 "files": [
  {
   "path": "src/kernel/bitcoinkernel.cpp",
   "add": 5,
   "del": 0
  },
  {
   "path": "src/kernel/bitcoinkernel.h",
   "add": 9,
   "del": 0
  },
  {
   "path": "src/kernel/bitcoinkernel_wrapper.h",
   "add": 5,
   "del": 0
  },
  {
   "path": "src/test/kernel/test_kernel.cpp",
   "add": 10,
   "del": 0
  }
 ],
 "test_lines": 10,
 "git": {
  "head": "4397e8647a27d40fbc26d29b17bbedded5692009",
  "head_matches_backup": true,
  "base": "b8215855437288cac95c7fd5d41104c73c0f3495",
  "commits": [
   {
    "sha": "4397e8647a",
    "subject": "kernel: expose transaction version",
    "files": 4,
    "add": 29,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "input_hash": "184962ead912074f",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}