{
 "number": 36285,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36285",
 "title": "refactor: Use static const over inline const to work around ld64 bug",
 "author": "maflcko",
 "author_association": "MEMBER",
 "created_at": "2026-09-17T09:16:10Z",
 "updated_at": "2026-09-17T11:03:57Z",
 "age_days": 0,
 "draft": false,
 "labels": [
  "Refactoring",
  "macOS",
  "Needs Backport (32.x)"
 ],
 "milestone": "32.0",
 "base": "master",
 "head_sha": "fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0",
 "head_ref": "2609-static-const-no-inline",
 "head_repo": "maflcko/bitcoin-core",
 "head_history": [],
 "additions": 8,
 "deletions": 8,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "janb84",
      "url": "https://github.com/bitcoin/bitcoin/pull/36285#pullrequestreview-5233973243"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "janb84": {
   "kind": "ack",
   "hash": "fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0",
   "t": "2026-09-17T09:58:45Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fanquake",
   "janb84",
   "willcl-ark"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-17T11:03:57Z",
  "last_reviewer_activity": "2026-09-17T10:55:32Z",
  "last_reviewer": "fanquake",
  "author_silent_days": 0,
  "waiting_on_author_days": 0,
  "days_since_update": 0
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "This partially reverts fa74f58a262096f25d5a3a4ec4951f4ce2a31792 to avoid initialization dependencies, which ld64 fails to handle properly.\n\nWorks around https://github.com/bitcoin/bitcoin/issues/36281 for now.\n\nObviously this will increase the bin size again (70kB for me), but this shouldn't matter much.",
 "commits": [
  {
   "sha": "fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0",
   "date": "2026-09-17T08:49:16Z",
   "message": "refactor: Use static const over inline const to work around ld64 bug\n\nThis partially reverts fa74f58a262096f25d5a3a4ec4951f4ce2a31792 to avoid\ninitialization dependencies, which the linker fails to handle properly."
  }
 ],
 "timeline": [
  {
   "t": "2026-09-17T09:29:58Z",
   "kind": "comment",
   "who": "willcl-ark",
   "assoc": "MEMBER",
   "text": "Attempted a run for this [here](https://github.com/willcl-ark/bitcoin-core-nightly/actions/runs/35205088979/job/105148781916).\n\nThe temporary workflow tests the currently-failing nix devShell against this PR.\n\nedit: annoyingly looks like my.cdash.org is down so might not get the best output. But we should still see success/failure."
  },
  {
   "t": "2026-09-17T09:58:45Z",
   "kind": "review",
   "who": "janb84",
   "assoc": "MEMBER",
   "state": "COMMENTED",
   "commit": "fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0",
   "text": "ACK fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0\n\nThis builds, runs and all the test work, on (my) macOS with nix."
  },
  {
   "t": "2026-09-17T10:04:39Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nHmm, looks like this is clang-lld, but the bug is with ld64? Also, it says `\t  3 - mptest (Failed)` (unrelated?), but there is no output/log?"
  },
  {
   "t": "2026-09-17T10:55:32Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nCan you clarify if this is ld64 generally, or just the older, patched version that Nix ships? Have we reported this to Nix upstream?"
  },
  {
   "t": "2026-09-17T11:03:57Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "I don't have macOS, so there is nothing more I can do here. In theory one could use CI to bisect+minimize+report, but this is a lot more tedious than doing it locally. My recommendation would be to merge this for now and then someone can continue in https://github.com/bitcoin/bitcoin/issues/36281 over the coming months or so."
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-17T09:16:14Z",
   "action": "labeled",
   "label": "Refactoring",
   "who": "DrahtBot"
  },
  {
   "t": "2026-09-17T09:16:34Z",
   "action": "labeled",
   "label": "Needs Backport (32.x)",
   "who": "maflcko"
  },
  {
   "t": "2026-09-17T09:17:04Z",
   "action": "labeled",
   "label": "macOS",
   "who": "maflcko"
  }
 ],
 "state_log": [
  {
   "t": "2026-09-17T09:16:43Z",
   "kind": "milestoned",
   "who": "maflcko"
  }
 ],
 "text_chars": 1682,
 "text_tokens_estimate": 420,
 "changed_paths": [],
 "files": [],
 "test_lines": 0,
 "git": {
  "head": "fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0",
  "head_matches_backup": true,
  "base": "fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0",
  "commits": [],
  "patch_truncated": false
 },
 "input_hash": "7fb4b4d869d3f5ed",
 "extracted_at": "2026-09-17T16:15:31+00:00"
}