{
 "number": 36292,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36292",
 "title": "index: Delete old coinstats index directory on startup",
 "author": "fjahr",
 "author_association": "MEMBER",
 "created_at": "2026-09-17T19:57:18Z",
 "updated_at": "2026-10-28T02:10:54Z",
 "description_hash": "460438cd5eb3218c",
 "age_days": 45,
 "draft": false,
 "labels": [
  "UTXO Db and Indexes"
 ],
 "milestone": "33.0",
 "base": "master",
 "head_sha": "82e4cc6964a9a130d3a41454e046af964ea05508",
 "head_ref": "2026-09-coinstats-b-gone",
 "head_repo": "fjahr/bitcoin",
 "head_history": [],
 "additions": 16,
 "deletions": 6,
 "changed_files": 3,
 "commit_count": 2,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "sedited",
      "url": "https://github.com/bitcoin/bitcoin/pull/36292#pullrequestreview-5245817064"
     }
    ],
    "concept_ack": [
     {
      "login": "mzumsande",
      "url": "https://github.com/bitcoin/bitcoin/pull/36292#pullrequestreview-5241703878"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "mzumsande": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-09-17T21:33:40Z",
   "stale": false
  },
  "sedited": {
   "kind": "ack",
   "hash": "82e4cc6964a9a130d3a41454e046af964ea05508",
   "t": "2026-09-18T08:31:55Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "bartoli",
   "mzumsande",
   "sedited"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-09-23T21:15:28Z",
  "last_reviewer_activity": "2026-09-23T18:52:06Z",
  "last_reviewer": "bartoli",
  "author_silent_days": 39,
  "waiting_on_author_days": 0,
  "days_since_update": 4
 },
 "refs": {
  "mentioned": [
   30469
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 30469,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2025-09-09",
    "title": "index: Fix coinstats overflow"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "`coinstatsindex` was updated in an incompatible way in v30 (see #30469) and moved to the `indexes/coinstatsindex` folder. The old `indexes/coinstats` directory was kept and a warning was logged so users could still downgrade to v29 without resyncing the index.\n\nThere was a TODO in the code that scheduled the deletion for v31. Since v32 branch-off has happened, this would now ship in v33. By then 29.x should be EOL assuming we are not going to release a v29.5.",
 "commits": [
  {
   "sha": "397c6c5c1c42cb2a4c1143bff6ab629a456d977b",
   "date": "2026-09-17T15:38:13Z",
   "message": "index: Delete old coinstats index directory on startup"
  },
  {
   "sha": "82e4cc6964a9a130d3a41454e046af964ea05508",
   "date": "2026-09-17T15:38:13Z",
   "message": "doc: Add release note for old coinstatsindex directory deletion"
  }
 ],
 "timeline": [
  {
   "t": "2026-09-17T21:33:40Z",
   "kind": "review",
   "who": "mzumsande",
   "assoc": "MEMBER",
   "state": "COMMENTED",
   "commit": "82e4cc6964a9a130d3a41454e046af964ea05508",
   "text": "Concept ACK",
   "id": "r:5241703878",
   "url": "https://github.com/bitcoin/bitcoin/pull/36292#pullrequestreview-5241703878",
   "hash": "e8334cc43879b73c",
   "edited": null
  },
  {
   "t": "2026-09-18T08:31:55Z",
   "kind": "review",
   "who": "sedited",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "82e4cc6964a9a130d3a41454e046af964ea05508",
   "text": "ACK 82e4cc6964a9a130d3a41454e046af964ea05508",
   "id": "r:5245817064",
   "url": "https://github.com/bitcoin/bitcoin/pull/36292#pullrequestreview-5245817064",
   "hash": "dfd779ac7ca6fc42",
   "edited": null
  },
  {
   "t": "2026-09-23T18:52:06Z",
   "kind": "comment",
   "who": "bartoli",
   "assoc": "NONE",
   "text": "Shouldn't deletion of the old one be done after the creation of the new one that potentially did not yet occur?\nThe new one shouldn't need to have the old one to be created, but that 'feels' risky?",
   "id": "c:5800930884",
   "url": "https://github.com/bitcoin/bitcoin/pull/36292#issuecomment-5800930884",
   "hash": "c3153862a26157b0",
   "edited": null
  },
  {
   "t": "2026-09-23T21:15:28Z",
   "kind": "comment",
   "who": "fjahr",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nThis isn't a concern. The new index doesn't use the old version at all. It is incompatible and has been synced from scratch since v30, so the old data is never read from there and so the order doesn't matter.",
   "id": "c:5803053562",
   "url": "https://github.com/bitcoin/bitcoin/pull/36292#issuecomment-5803053562",
   "hash": "37b1ea25a13e35de",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-17T19:57:21Z",
   "action": "labeled",
   "label": "UTXO Db and Indexes",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-09-18T10:00:46Z",
   "kind": "milestoned",
   "who": "fanquake"
  }
 ],
 "text_chars": 1123,
 "text_tokens_estimate": 280,
 "changed_paths": [
  "doc/release-notes-coinstatsindex-cleanup.md",
  "src/index/coinstatsindex.cpp",
  "test/functional/feature_coinstatsindex_compatibility.py"
 ],
 "files": [
  {
   "path": "doc/release-notes-coinstatsindex-cleanup.md",
   "add": 7,
   "del": 0
  },
  {
   "path": "src/index/coinstatsindex.cpp",
   "add": 7,
   "del": 5
  },
  {
   "path": "test/functional/feature_coinstatsindex_compatibility.py",
   "add": 2,
   "del": 1
  }
 ],
 "test_lines": 3,
 "git": {
  "head": "82e4cc6964a9a130d3a41454e046af964ea05508",
  "head_matches_backup": true,
  "base": "b8215855437288cac95c7fd5d41104c73c0f3495",
  "patch_id": "31add9d6f6cf9bbf",
  "commits": [
   {
    "sha": "397c6c5c1c",
    "subject": "index: Delete old coinstats index directory on startup",
    "files": 2,
    "add": 9,
    "del": 6
   },
   {
    "sha": "82e4cc6964",
    "subject": "doc: Add release note for old coinstatsindex directory deletion",
    "files": 1,
    "add": 7,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "31add9d6f6cf9bbf",
 "input_hash": "c8f078727ff84a0c",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}