{
 "number": 36378,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36378",
 "title": "test: Add SKIP_WRITE edge case to wallet_startup",
 "author": "aaron-leeb",
 "author_association": "FIRST_TIME_CONTRIBUTOR",
 "created_at": "2026-09-29T03:40:26Z",
 "updated_at": "2026-10-01T10:48:32Z",
 "description_hash": "a6406ff550297910",
 "age_days": 33,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "774dd9b034b3930dd1b5eba350558acc1d9da03c",
 "head_ref": "test-wallet-startup-skip-write",
 "head_repo": "aaron-leeb/bitcoin",
 "head_history": [],
 "additions": 5,
 "deletions": 0,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "unstable",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "mercie-ux",
      "url": "https://github.com/bitcoin/bitcoin/pull/36378#issuecomment-5929803248"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "mercie-ux": {
   "kind": "ack",
   "hash": "774dd9b",
   "t": "2026-10-01T10:48:28Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "mercie-ux"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "unstable",
  "last_author_activity": "2026-09-29T03:18:16Z",
  "last_reviewer_activity": "2026-10-01T10:48:28Z",
  "last_reviewer": "mercie-ux",
  "author_silent_days": 33,
  "waiting_on_author_days": 31,
  "days_since_update": 31
 },
 "refs": {
  "mentioned": [
   36176
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 36176,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-09-07",
    "title": "wallet: avoid a crash when creating a wallet with -nosettings"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Verifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.\n\nThis improves test coverage for the dynamic settings logic introduced in [#36176](https://github.com/bitcoin/bitcoin/pull/36176) by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.\n\nThis specific edge case was suggested by contributor jeanpablojp [here](https://github.com/bitcoin/bitcoin/pull/36176#discussion_r3944837660).",
 "commits": [
  {
   "sha": "774dd9b034b3930dd1b5eba350558acc1d9da03c",
   "date": "2026-09-29T03:18:16Z",
   "message": "test: Add SKIP_WRITE edge case to wallet_startup\n\nVerifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.\n\nThis improves coverage for the dynamic settings logic introduced in #36176 by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.\n\nThis specific edge case was suggested by contributor jeanpablojp."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-01T10:48:28Z",
   "kind": "comment",
   "who": "mercie-ux",
   "assoc": "CONTRIBUTOR",
   "text": "ACK 774dd9b\nRan this locally, the test passes and behaves as expected under `-nosettings`.",
   "id": "c:5929803248",
   "url": "https://github.com/bitcoin/bitcoin/pull/36378#issuecomment-5929803248",
   "hash": "7bb4bf80c66a00b0",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-09-29T03:40:29Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 1183,
 "text_tokens_estimate": 295,
 "changed_paths": [
  "test/functional/wallet_startup.py"
 ],
 "files": [
  {
   "path": "test/functional/wallet_startup.py",
   "add": 5,
   "del": 0
  }
 ],
 "test_lines": 5,
 "git": {
  "head": "774dd9b034b3930dd1b5eba350558acc1d9da03c",
  "head_matches_backup": true,
  "base": "ed7dd7cf4e1561a97edf72eba29a67b14e28c717",
  "patch_id": "a1c4d558df8e9025",
  "commits": [
   {
    "sha": "774dd9b034",
    "subject": "test: Add SKIP_WRITE edge case to wallet_startup",
    "files": 1,
    "add": 5,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "a1c4d558df8e9025",
 "input_hash": "ee0f009d7e5d3a23",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}