{
 "number": 36458,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36458",
 "title": "Test: Add script vectors for interpreter edges",
 "author": "benthecarman",
 "author_association": "CONTRIBUTOR",
 "created_at": "2026-10-07T19:35:17Z",
 "updated_at": "2026-10-22T21:31:58Z",
 "description_hash": "f3a5452eaec29dbf",
 "age_days": 25,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
 "head_ref": "script-vectors-interpreter-edges",
 "head_repo": "benthecarman/bitcoin",
 "head_history": [],
 "additions": 38,
 "deletions": 1,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "darosior",
      "url": "https://github.com/bitcoin/bitcoin/pull/36458#pullrequestreview-5620675342"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "darosior": {
   "kind": "ack",
   "hash": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "t": "2026-10-22T20:53:28Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "darosior",
   "fametrano",
   "fanquake"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-22T21:31:58Z",
  "last_reviewer_activity": "2026-10-22T20:53:28Z",
  "last_reviewer": "darosior",
  "author_silent_days": 10,
  "waiting_on_author_days": 0,
  "days_since_update": 10
 },
 "refs": {
  "mentioned": [
   36455
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 36455,
    "type": "pull",
    "state": "open",
    "merged": false,
    "merged_at": null,
    "title": "Test: Add legacy script edge cases to taproot test"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "src/test/data/script_tests.json",
  "src/test/data/tx_invalid.json"
 ],
 "body": "Add script_tests.json and tx_invalid.json vectors for edge cases that\nother implementations have gotten wrong, including CSV with -2, IFDUP\non negative zero, ROLL with duplicate values, a taproot output key\nthat is not a valid x coordinate, and single-flag STRICTENC, LOW_S and\nNULLFAIL cases.\n\nSome policy cases were only caught by the tx_valid harness adding\nflags back, which implementations copying the JSON don't replicate.\n\nRelated: #36455\n\nThese were discovered by finding gaps in an alternate implementation (bitcoin-s)",
 "commits": [
  {
   "sha": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "date": "2026-10-07T18:43:30Z",
   "message": "Test: Add script vectors for interpreter edges\n\nAdd script_tests.json and tx_invalid.json vectors for edge cases that\nother implementations have gotten wrong, including CSV with -2, IFDUP\non negative zero, ROLL with duplicate values, a taproot output key\nthat is not a valid x coordinate, and single-flag STRICTENC, LOW_S and\nNULLFAIL cases.\n\nSome policy cases were only caught by the tx_valid harness adding\nflags back, which implementations copying the JSON don't replicate."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-09T09:36:24Z",
   "kind": "comment",
   "who": "fametrano",
   "assoc": "CONTRIBUTOR",
   "text": "I ran the new vectors at 5d2fb8d through btclib, a Python implementation I maintain. Every new script_tests.json row gives the expected result and error code. Each of the 4 new tx_invalid.json rows fails under its listed flag with the error its comment describes, and is valid with no flags.",
   "id": "c:6078327410",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#issuecomment-6078327410",
   "hash": "b24817fe1844e71b",
   "edited": null
  },
  {
   "t": "2026-10-16T06:22:24Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "cc @instagibbs",
   "id": "c:6209454245",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#issuecomment-6209454245",
   "hash": "0db2f6d411552b9b",
   "edited": null
  },
  {
   "t": "2026-10-22T14:49:46Z",
   "kind": "comment",
   "who": "darosior",
   "assoc": "MEMBER",
   "text": "Concept ACK. It's useful to know what re-implementations got wrong, as it's often non-obvious stuff we can better cover in our automated testing.",
   "id": "c:6343690971",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#issuecomment-6343690971",
   "hash": "708565df116a6dce",
   "edited": null
  },
  {
   "t": "2026-10-22T20:49:45Z",
   "kind": "review_comment",
   "who": "darosior",
   "assoc": "MEMBER",
   "path": "src/test/data/tx_invalid.json",
   "commit": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "in_reply_to": null,
   "text": "Isn't this one redundant with the script_tests.json one you added above?",
   "id": "rc:4353381236",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#discussion_r4353381236",
   "hash": "559d163128848963",
   "edited": "2026-10-22T20:53:28Z"
  },
  {
   "t": "2026-10-22T20:51:20Z",
   "kind": "review_comment",
   "who": "darosior",
   "assoc": "MEMBER",
   "path": "src/test/data/script_tests.json",
   "commit": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "in_reply_to": null,
   "text": "Heh, nice. (Though the -1 vector would also catch this, but good to have it spelled out.)",
   "id": "rc:4353396540",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#discussion_r4353396540",
   "hash": "98fe30d035bde106",
   "edited": "2026-10-22T20:53:28Z"
  },
  {
   "t": "2026-10-22T20:52:55Z",
   "kind": "review_comment",
   "who": "darosior",
   "assoc": "MEMBER",
   "path": "src/test/data/script_tests.json",
   "commit": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "in_reply_to": null,
   "text": "Nice.",
   "id": "rc:4353411113",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#discussion_r4353411113",
   "hash": "b4791ba04377a68f",
   "edited": "2026-10-22T20:53:28Z"
  },
  {
   "t": "2026-10-22T20:53:28Z",
   "kind": "review",
   "who": "darosior",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "text": "ACK 5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "id": "r:5620675342",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#pullrequestreview-5620675342",
   "hash": "c9d2aee591a13b82",
   "edited": null
  },
  {
   "t": "2026-10-22T21:31:58Z",
   "kind": "review_comment",
   "who": "benthecarman",
   "assoc": "CONTRIBUTOR",
   "path": "src/test/data/tx_invalid.json",
   "commit": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
   "in_reply_to": 4353381236,
   "text": "yeah i guess, being redundant doesn't really hurt here though",
   "id": "rc:4353755704",
   "url": "https://github.com/bitcoin/bitcoin/pull/36458#discussion_r4353755704",
   "hash": "2211c0fa6f9ff24f",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-07T19:35:21Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 1779,
 "text_tokens_estimate": 444,
 "changed_paths": [
  "src/test/data/script_tests.json",
  "src/test/data/tx_invalid.json"
 ],
 "files": [
  {
   "path": "src/test/data/script_tests.json",
   "add": 22,
   "del": 1
  },
  {
   "path": "src/test/data/tx_invalid.json",
   "add": 16,
   "del": 0
  }
 ],
 "test_lines": 39,
 "git": {
  "head": "5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a",
  "head_matches_backup": true,
  "base": "aef8a04966d7ab6c04edc5d19b733e78205405de",
  "patch_id": "ca8ce1cf86a5fe0f",
  "commits": [
   {
    "sha": "5d2fb8d309",
    "subject": "Test: Add script vectors for interpreter edges",
    "files": 2,
    "add": 38,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "ca8ce1cf86a5fe0f",
 "input_hash": "db8d3922fa78508d",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}