{ "number": 36481, "repo": "bitcoin/bitcoin", "url": "https://github.com/bitcoin/bitcoin/pull/36481", "title": "wallet, rpc, gui: Allow users to manually rebroadcast a wallet transaction", "author": "achow101", "author_association": "MEMBER", "created_at": "2026-10-08T21:41:06Z", "updated_at": "2026-10-27T14:03:47Z", "description_hash": "f3b4d2283b527880", "age_days": 24, "draft": false, "labels": [ "CI failed" ], "milestone": null, "base": "master", "head_sha": "648450039ab1c93f5e0001e0829f094ca41d2bae", "head_ref": "manual-rebroadcast", "head_repo": "achow101/bitcoin", "head_history": [ { "t": "2026-10-08T22:05:49Z", "sha": "648450039ab1c93f5e0001e0829f094ca41d2bae" } ], "additions": 123, "deletions": 4, "changed_files": 9, "commit_count": 2, "size_bucket": "M", "mergeable_state": "unstable", "bot": { "drahtbot": { "present": true, "reviews": { "concept_ack": [ { "login": "polespinasa", "url": "https://github.com/bitcoin/bitcoin/pull/36481#issuecomment-6070262862" }, { "login": "mzumsande", "url": "https://github.com/bitcoin/bitcoin/pull/36481#pullrequestreview-5472173546" }, { "login": "murchandamus", "url": "https://github.com/bitcoin/bitcoin/pull/36481#issuecomment-6324896461" }, { "login": "jpk68", "url": "https://github.com/bitcoin/bitcoin/pull/36481#issuecomment-6329654439" }, { "login": "fametrano", "url": "https://github.com/bitcoin/bitcoin/pull/36481#pullrequestreview-5642981631" } ], "approach_ack": [ { "login": "vasild", "url": "https://github.com/bitcoin/bitcoin/pull/36481#pullrequestreview-5665738041" } ] }, "conflicts": [] } }, "acks_parsed": { "polespinasa": { "kind": "concept_ack", "hash": null, "t": "2026-10-08T22:24:55Z", "stale": false }, "mzumsande": { "kind": "concept_ack", "hash": null, "t": "2026-10-09T15:36:08Z", "stale": false }, "murchandamus": { "kind": "concept_ack", "hash": null, "t": "2026-10-21T19:39:55Z", "stale": false }, "jpk68": { "kind": "concept_ack", "hash": null, "t": "2026-10-22T00:27:13Z", "stale": false }, "fametrano": { "kind": "concept_ack", "hash": null, "t": "2026-10-25T11:35:15Z", "stale": false }, "vasild": { "kind": "approach_ack", "hash": "648450039ab1c93f5e0001e0829f094ca41d2bae", "t": "2026-10-27T14:03:41Z", "stale": false } }, "acks_tally": { "ack": 0, "stale_ack": 0, "concept_ack": 5, "approach_ack": 1, "nack": 0, "concept_nack": 0, "approach_nack": 0 }, "reviews": { "approved": 0, "changes_requested": 0, "distinct_reviewers": [ "fametrano", "jpk68", "murchandamus", "mzumsande", "polespinasa", "vasild" ] }, "signals": { "needs_rebase": false, "ci_failed": true, "mergeable_state": "unstable", "last_author_activity": "2026-10-08T22:05:49Z", "last_reviewer_activity": "2026-10-27T14:03:41Z", "last_reviewer": "vasild", "author_silent_days": 24, "waiting_on_author_days": 5, "days_since_update": 5 }, "refs": { "mentioned": [ 36403 ], "depends_on": [], "fixes": [], "linked_issues": [], "references": [ { "number": 36403, "type": "issue", "state": "open", "merged": false, "merged_at": null, "title": "Rethinking Transaction Rebroadcasting" } ], "conflicts": [] }, "stack": { "shares_commits_with": [], "based_on": [], "base_for": [] }, "review_paths": [ "src/interfaces/wallet.h", "src/qt/transactionview.cpp", "src/wallet/rpc/transactions.cpp", "src/wallet/wallet.cpp" ], "body": "From the discussion in #36403, it is clear that there needs to be a way for users to rebroadcast a transaction. Currently, the way to do so requires getting the raw transaction, getting the hex, and using `sendrawtransaction`. This PR adds `rebroadcastwallettx` RPC that takes a txid to attempt to rebroadcast that single transaction. An action is also added to the GUI menu for each transaction to do the same.", "commits": [ { "sha": "0a9df9bf236045a80205de26e1d6f8d1bf0f45e8", "date": "2026-10-08T22:05:41Z", "message": "wallet, rpc: Add rebroadcastwallettx" }, { "sha": "648450039ab1c93f5e0001e0829f094ca41d2bae", "date": "2026-10-08T22:05:41Z", "message": "gui: Add rebroadcast tx menu action" } ], "timeline": [ { "t": "2026-10-08T22:05:49Z", "kind": "force_push", "who": "achow101", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "id": "push:648450039ab1c93f5e0001e0829f094ca41d2bae" }, { "t": "2026-10-08T22:24:55Z", "kind": "comment", "who": "polespinasa", "assoc": "MEMBER", "text": "concept ACK", "id": "c:6070262862", "url": "https://github.com/bitcoin/bitcoin/pull/36481#issuecomment-6070262862", "hash": "d0815209cf45d36b", "edited": null }, { "t": "2026-10-09T15:36:08Z", "kind": "review", "who": "mzumsande", "assoc": "MEMBER", "state": "COMMENTED", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "text": "Concept ACK\n\nWhatever the solution of the existing issues with rebroadcast will be, giving the users the option to rebroadcast transactions manually is useful in all of these scenarios.", "id": "r:5472173546", "url": "https://github.com/bitcoin/bitcoin/pull/36481#pullrequestreview-5472173546", "hash": "384a10094261e574", "edited": "2026-10-09T16:03:33Z" }, { "t": "2026-10-21T19:39:55Z", "kind": "comment", "who": "murchandamus", "assoc": "MEMBER", "text": "Concept ACK", "id": "c:6324896461", "url": "https://github.com/bitcoin/bitcoin/pull/36481#issuecomment-6324896461", "hash": "e8334cc43879b73c", "edited": null }, { "t": "2026-10-22T00:27:13Z", "kind": "comment", "who": "jpk68", "assoc": "CONTRIBUTOR", "text": "Concept ACK", "id": "c:6329654439", "url": "https://github.com/bitcoin/bitcoin/pull/36481#issuecomment-6329654439", "hash": "e8334cc43879b73c", "edited": null }, { "t": "2026-10-25T11:35:15Z", "kind": "review", "who": "fametrano", "assoc": "NONE", "state": "COMMENTED", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "text": "Concept ACK\n\nOne issue should be fixed before merge: `rebroadcastwallettx` fails with code -1 and an empty message when the transaction is out of the mempool and its feerate is above the wallet's `-maxfeerate`.\n\nI ran the RPC on regtest at 648450039a. Other mempool rejections keep their reason, such as \"bad-txns-inputs-missingorspent\" for a child whose parent expired. The empty message shows up when a user lowers `-maxfeerate` to 20 sat/vB and restarts without mempool.dat. Our own 50 sat/vB child of an incoming payment then stays out of the mempool, and the RPC returns `{\"code\": -1, \"message\": \"\"}`. For the same transaction, `sendrawtransaction` with `maxfeerate=0.0002` returns -25 \"Fee rate exceeds maximum configured by user (maxfeerate)\".\n\nThe cause is that `Chain::broadcastTransaction` returns only a bool, and `BroadcastTransaction` sets no error string for `MAX_FEE_EXCEEDED` or `MAX_FEE_RATE_EXCEEDED`. `sendrawtransaction` falls back to `TransactionErrorString` in that case. The wallet's other callers only log the string or drop it, so this RPC is the first to show it to a user. The same fallback inside the `Chain::broadcastTransaction` wrapper would fix it, and the GUI action will need that message once it shows the result. I can share the probe script.", "id": "r:5642981631", "url": "https://github.com/bitcoin/bitcoin/pull/36481#pullrequestreview-5642981631", "hash": "0270102806e326a7", "edited": null }, { "t": "2026-10-27T10:41:28Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/interfaces/wallet.h", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "```suggestion\n //! Return whether transaction can be broadcast.\n```", "id": "rc:4387682282", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4387682282", "hash": "3e907d706b186730", "edited": "2026-10-27T14:03:41Z" }, { "t": "2026-10-27T10:41:59Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/interfaces/wallet.h", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "```suggestion\n //! Rebroadcast a transaction.\n```", "id": "rc:4387686530", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4387686530", "hash": "189100306e6d7727", "edited": "2026-10-27T14:03:41Z" }, { "t": "2026-10-27T10:45:45Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/qt/transactionview.cpp", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "What is the `&` in `Re&broadcast`? It is also in `A&bandon`.", "id": "rc:4387718797", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4387718797", "hash": "6277833e62b2e113", "edited": "2026-10-27T14:03:41Z" }, { "t": "2026-10-27T10:48:52Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/qt/transactionview.cpp", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "```suggestion\n if (!transactionView || !transactionView->selectionModel())\n return;\n```\nalso, the `return` should be either on the same line as `if` or there should be `{` and `}`.", "id": "rc:4387745222", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4387745222", "hash": "210b9f0d23738761", "edited": "2026-10-27T14:03:41Z" }, { "t": "2026-10-27T10:50:00Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/qt/transactionview.cpp", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "```suggestion\n // Rebroadcast the wallet transaction over the walletModel\n```", "id": "rc:4387754841", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4387754841", "hash": "4817cf5b8231aec9", "edited": "2026-10-27T14:03:41Z" }, { "t": "2026-10-27T13:38:05Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/wallet/wallet.cpp", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "If the wallet broadcast is disabled (`-walletbroadcast=0`), then the \"is not eligible to be rebroadcast\" will be misleading because it implies that there is something specific about this transaction that makes it not eligible.\n\nConsider extending `TransactionCanBeBroadcast()` to return the reason why the transaction can not be broadcast:\n\n[patch] TransactionCanBeBroadcast() with a reason\n\n```diff\ndiff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp\nindex 29460e3ba2..dcd571b684 100644\n--- a/src/wallet/wallet.cpp\n+++ b/src/wallet/wallet.cpp\n@@ -1832,51 +1832,64 @@ util::Expected CWallet::RebroadcastSingleTransaction(const Tx\n {\n LOCK(cs_wallet);\n auto it = mapWallet.find(txid);\n if (it == mapWallet.end()) {\n return util::Unexpected{WalletError{WalletErrorCode::InvalidParameter, strprintf(_(\"%s not in wallet\"), txid.ToString())}};\n }\n- if (!TransactionCanBeBroadcast(it->second)) {\n- return util::Unexpected{WalletError{WalletErrorCode::InvalidParameter, strprintf(_(\"%s is not eligible to be rebroadcast\"), txid.ToString())}};\n- }\n std::string err;\n+ if (!TransactionCanBeBroadcast(it->second, err)) {\n+ return util::Unexpected{WalletError{WalletErrorCode::InvalidParameter, strprintf(_(\"can not rebroadcast %s: %s\"), txid.ToString(), err)}};\n+ }\n if (!SubmitTxMemoryPoolAndRelay(it->second, err, node::TxBroadcast::MEMPOOL_AND_BROADCAST_TO_ALL)) {\n return util::Unexpected{WalletError{WalletErrorCode::MiscError, Untranslated(err)}};\n }\n return {};\n }\n\n-bool CWallet::TransactionCanBeBroadcast(const Txid& txid) const\n+bool CWallet::TransactionCanBeBroadcast(const Txid& txid, std::string& reason) const\n {\n LOCK(cs_wallet);\n const CWalletTx* wtx = GetWalletTx(txid);\n- return wtx && TransactionCanBeBroadcast(*wtx);\n+ return wtx && TransactionCanBeBroadcast(*wtx, reason);\n }\n\n-bool CWallet::TransactionCanBeBroadcast(const CWalletTx& wtx) const\n+bool CWallet::TransactionCanBeBroadcast(const CWalletTx& wtx, std::string& reason) const\n {\n AssertLockHeld(cs_wallet);\n // Can't relay if wallet is not broadcasting\n- if (!GetBroadcastTransactions()) return false;\n+ if (!GetBroadcastTransactions()) {\n+ reason = \"the wallet is configured to not broadcast transactions\";\n+ return false;\n+ }\n // Don't relay abandoned transactions\n- if (wtx.isAbandoned()) return false;\n+ if (wtx.isAbandoned()) {\n+ reason = \"the transaction is abandoned\";\n+ return false;\n+ }\n // Don't try to submit coinbase transactions. These would fail anyway but would\n // cause log spam.\n- if (wtx.IsCoinBase()) return false;\n+ if (wtx.IsCoinBase()) {\n+ reason = \"the transaction is a coinbase transaction\";\n+ return false;\n+ }\n // Don't try to submit conflicted or confirmed transactions.\n- if (GetTxDepthInMainChain(wtx) != 0) return false;\n+ if (GetTxDepthInMainChain(wtx) != 0) {\n+ reason = \"the transaction is already confirmed or is conflicted\";\n+ return false;\n+ }\n return true;\n }\n\n bool CWallet::SubmitTxMemoryPoolAndRelay(CWalletTx& wtx,\n std::string& err_string,\n node::TxBroadcast broadcast_method) const\n {\n AssertLockHeld(cs_wallet);\n\n- if (!TransactionCanBeBroadcast(wtx)) return false;\n+ std::string reason;\n+ if (!TransactionCanBeBroadcast(wtx, reason)) return false;\n\n const char* what{\"\"};\n switch (broadcast_method) {\n case node::TxBroadcast::MEMPOOL_AND_BROADCAST_TO_ALL:\n what = \"to mempool and for broadcast to peers\";\n break;\ndiff --git a/src/wallet/wallet.h b/src/wallet/wallet.h\nindex 8d7c72f4d7..0b64d62571 100644\n--- a/src/wallet/wallet.h\n+++ b/src/wallet/wallet.h\n@@ -443,13 +443,13 @@ private:\n // Update last block processed in memory only\n void SetLastBlockProcessedInMem(int block_height, uint256 block_hash) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);\n\n //! Update mempool conflicts for TRUC sibling transactions\n void UpdateTrucSiblingConflicts(const CWalletTx& parent_wtx, const Txid& child_txid, bool add_conflict) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);\n\n- bool TransactionCanBeBroadcast(const CWalletTx& wtx) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);\n+ bool TransactionCanBeBroadcast(const CWalletTx& wtx, std::string& reason) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);\n\n public:\n /**\n * Main wallet lock.\n * This lock protects all the fields added by CWallet.\n */\n@@ -635,13 +635,13 @@ public:\n void transactionRemovedFromMempool(const CTransactionRef& tx, MemPoolRemovalReason reason) override;\n /** Set the next time this wallet should resend transactions to 12-36 hours from now, ~1 day on average. */\n void SetNextResend() { m_next_resend = GetDefaultNextResend(); }\n /** Return true if all conditions for periodically resending transactions are met. */\n bool ShouldResend() const;\n void ResubmitWalletTransactions(node::TxBroadcast broadcast_method, bool force);\n- bool TransactionCanBeBroadcast(const Txid& txid) const;\n+ bool TransactionCanBeBroadcast(const Txid& txid, std::string& reason) const;\n util::Expected RebroadcastSingleTransaction(const Txid& txid);\n\n OutputType TransactionChangeType(const std::optional& change_type, const std::vector& vecSend) const;\n\n /** Fetch the inputs and sign with SIGHASH_ALL. */\n bool SignTransaction(CMutableTransaction& tx) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);\ndiff --git a/src/wallet/interfaces.cpp b/src/wallet/interfaces.cpp\nindex 78139f635d..1759680b02 100644\n--- a/src/wallet/interfaces.cpp\n+++ b/src/wallet/interfaces.cpp\n@@ -283,13 +283,17 @@ public:\n bool transactionCanBeAbandoned(const Txid& txid) override { return m_wallet->TransactionCanBeAbandoned(txid); }\n bool abandonTransaction(const Txid& txid) override\n {\n LOCK(m_wallet->cs_wallet);\n return m_wallet->AbandonTransaction(txid);\n }\n- bool transactionCanBeBroadcast(const Txid& txid) override { return m_wallet->TransactionCanBeBroadcast(txid); }\n+ bool transactionCanBeBroadcast(const Txid& txid) override\n+ {\n+ std::string reason;\n+ return m_wallet->TransactionCanBeBroadcast(txid, reason);\n+ }\n util::Expected rebroadcastTransaction(const Txid& txid) override\n {\n LOCK(m_wallet->cs_wallet);\n return m_wallet->RebroadcastSingleTransaction(txid);\n }\n bool transactionCanBeBumped(const Txid& txid) override\n```", "id": "rc:4389337972", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4389337972", "hash": "f3134eec93119d99", "edited": "2026-10-27T14:03:41Z" }, { "t": "2026-10-27T13:43:39Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/wallet/rpc/transactions.cpp", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "Should we not throw here? `UniValue::VNULL` is for \"If rebroadcast is successfully initiated\".\n\n```diff\n- if (!wallet) return UniValue::VNULL;\n+ if (!wallet) {\n+ throw JSONRPCError(RPC_WALLET_ERROR, \"no wallet\");\n+ }\n```", "id": "rc:4389395895", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4389395895", "hash": "72f8c639ef80332f", "edited": "2026-10-27T14:03:42Z" }, { "t": "2026-10-27T13:45:04Z", "kind": "review_comment", "who": "vasild", "assoc": "MEMBER", "path": "src/wallet/rpc/transactions.cpp", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "in_reply_to": null, "text": "I think it would be useful to add the sentence `Use the listtransactions RPC to see the wallet transactions` here.", "id": "rc:4389410912", "url": "https://github.com/bitcoin/bitcoin/pull/36481#discussion_r4389410912", "hash": "5603ced5cd004f16", "edited": "2026-10-27T14:03:42Z" }, { "t": "2026-10-27T14:03:41Z", "kind": "review", "who": "vasild", "assoc": "MEMBER", "state": "COMMENTED", "commit": "648450039ab1c93f5e0001e0829f094ca41d2bae", "text": "Approach ACK 648450039ab1c93f5e0001e0829f094ca41d2bae", "id": "r:5665738041", "url": "https://github.com/bitcoin/bitcoin/pull/36481#pullrequestreview-5665738041", "hash": "00d7d27ebfe1db5a", "edited": null } ], "labels_log": [ { "t": "2026-10-08T22:06:45Z", "action": "labeled", "label": "CI failed", "who": "DrahtBot" } ], "state_log": [], "text_chars": 9596, "text_tokens_estimate": 2399, "changed_paths": [ "src/interfaces/wallet.h", "src/qt/transactionview.cpp", "src/qt/transactionview.h", "src/wallet/interfaces.cpp", "src/wallet/rpc/transactions.cpp", "src/wallet/rpc/wallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_resendwallettransactions.py" ], "files": [ { "path": "src/interfaces/wallet.h", "add": 6, "del": 0 }, { "path": "src/qt/transactionview.cpp", "add": 16, "del": 0 }, { "path": "src/qt/transactionview.h", "add": 2, "del": 0 }, { "path": "src/wallet/interfaces.cpp", "add": 6, "del": 0 }, { "path": "src/wallet/rpc/transactions.cpp", "add": 28, "del": 0 }, { "path": "src/wallet/rpc/wallet.cpp", "add": 2, "del": 0 }, { "path": "src/wallet/wallet.cpp", "add": 35, "del": 4 }, { "path": "src/wallet/wallet.h", "add": 4, "del": 0 }, { "path": "test/functional/wallet_resendwallettransactions.py", "add": 24, "del": 0 } ], "test_lines": 24, "git": { "head": "648450039ab1c93f5e0001e0829f094ca41d2bae", "head_matches_backup": true, "base": "f739c7876b81304bdc72e7eaa307702da269ac31", "patch_id": "036b5cf39f96a3bf", "commits": [ { "sha": "0a9df9bf23", "subject": "wallet, rpc: Add rebroadcastwallettx", "files": 5, "add": 93, "del": 4 }, { "sha": "648450039a", "subject": "gui: Add rebroadcast tx menu action", "files": 4, "add": 30, "del": 0 } ], "patch_truncated": false }, "patch_id": "036b5cf39f96a3bf", "input_hash": "6899b6c07efecee3", "extracted_at": "2026-11-02T01:09:49+00:00" }