{
 "number": 36488,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36488",
 "title": "rpc: wallet: Schedule mixed-case confTarget option deprecation",
 "author": "maflcko",
 "author_association": "MEMBER",
 "created_at": "2026-10-09T09:54:22Z",
 "updated_at": "2026-10-26T09:03:48Z",
 "description_hash": "738577bfd4c1e0d8",
 "age_days": 23,
 "draft": false,
 "labels": [
  "Wallet",
  "RPC/REST/ZMQ"
 ],
 "milestone": "33.0",
 "base": "master",
 "head_sha": "fab22ac42e350d4b4481515fe8ba2a319a744389",
 "head_ref": "2610-confTarget",
 "head_repo": "maflcko/bitcoin-core",
 "head_history": [
  {
   "t": "2026-10-09T09:56:20Z",
   "sha": "fa9612b841299ad163c535a092ee680352c5aa7c"
  },
  {
   "t": "2026-10-09T11:08:07Z",
   "sha": "fa2ed3966f3d94b79c516b6025012148fce42369"
  },
  {
   "t": "2026-10-16T07:58:02Z",
   "sha": "faec0b33ab37dcc4e7458546b4108d7cedb53bf8"
  },
  {
   "t": "2026-10-20T06:53:48Z",
   "sha": "fab22ac42e350d4b4481515fe8ba2a319a744389"
  }
 ],
 "additions": 18,
 "deletions": 1,
 "changed_files": 4,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "fametrano",
      "url": "https://github.com/bitcoin/bitcoin/pull/36488#issuecomment-6394558268"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fametrano"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-26T09:03:48Z",
  "last_reviewer_activity": "2026-10-25T06:49:41Z",
  "last_reviewer": "fametrano",
  "author_silent_days": 6,
  "waiting_on_author_days": 0,
  "days_since_update": 6
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Since commit 91f6d2bc8ff4d4cd1b86daa370ec9d2d9662394d in 2020, the wallet accepts and documents `conf_target` for the fee bump RPC.\n\nSo it seems time to cut the confusion and properly deprecate it with the next cycle.",
 "commits": [
  {
   "sha": "fab22ac42e350d4b4481515fe8ba2a319a744389",
   "date": "2026-10-20T06:52:08Z",
   "message": "rpc: wallet: Schedule mixed-case confTarget option deprecation"
  }
 ],
 "timeline": [
  {
   "t": "2026-10-09T09:56:20Z",
   "kind": "force_push",
   "who": "maflcko",
   "commit": "fa9612b841299ad163c535a092ee680352c5aa7c",
   "id": "push:fa9612b841299ad163c535a092ee680352c5aa7c"
  },
  {
   "t": "2026-10-09T11:08:07Z",
   "kind": "force_push",
   "who": "maflcko",
   "commit": "fa2ed3966f3d94b79c516b6025012148fce42369",
   "id": "push:fa2ed3966f3d94b79c516b6025012148fce42369"
  },
  {
   "t": "2026-10-16T07:58:02Z",
   "kind": "force_push",
   "who": "maflcko",
   "commit": "faec0b33ab37dcc4e7458546b4108d7cedb53bf8",
   "id": "push:faec0b33ab37dcc4e7458546b4108d7cedb53bf8"
  },
  {
   "t": "2026-10-20T06:53:48Z",
   "kind": "force_push",
   "who": "maflcko",
   "commit": "fab22ac42e350d4b4481515fe8ba2a319a744389",
   "id": "push:fab22ac42e350d4b4481515fe8ba2a319a744389"
  },
  {
   "t": "2026-10-25T06:49:41Z",
   "kind": "comment",
   "who": "fametrano",
   "assoc": "NONE",
   "text": "tACK fab22ac42e350d4b4481515fe8ba2a319a744389\n\nNo test checks that `confTarget` still works under `-deprecatedrpc=confTarget`. The comment in `rpc_deprecated.py` asks that each deprecation tested there keep another functional test that still exercises it under the flag. `wallet_bumpfee.py` gains the flag, but its only `confTarget` call is the \"should not both be set\" error, so a change that broke `confTarget` behind the flag would still pass the tests. One `bumpfee` and one `psbtbumpfee` call with `{\"confTarget\": 6}` in that test would cover it.\n\nThe rest matched. Without the flag, both RPCs return -32 for `confTarget`, alone or next to `conf_target`, before the txid is looked up. With the flag, `confTarget` bumps and the conflict error is unchanged. `conf_target` works either way, positional or named. The help and `getopenrpcinfo` list only `conf_target`.\n\nI measured this on regtest against a build of the head, with and without the flag, with calls sent through a client library I maintain. I can share the script and its output.",
   "id": "c:6394558268",
   "url": "https://github.com/bitcoin/bitcoin/pull/36488#issuecomment-6394558268",
   "hash": "3cf469646e30c177",
   "edited": null
  },
  {
   "t": "2026-10-26T09:03:48Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nYour LLM-co-authored comment is just repeating what the Ralph LLM already said. There never was a test for this since 2020, the option was undocumented since then, so likely no user is using it. I don't think it makes sense to add a test for this now, given that such a test would be harder to review than the code change here by itself.",
   "id": "c:6412201138",
   "url": "https://github.com/bitcoin/bitcoin/pull/36488#issuecomment-6412201138",
   "hash": "a88d2adde4713152",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-09T09:54:26Z",
   "action": "labeled",
   "label": "RPC/REST/ZMQ",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-09T09:57:28Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-09T10:07:29Z",
   "action": "labeled",
   "label": "Wallet",
   "who": "maflcko"
  },
  {
   "t": "2026-10-09T12:29:09Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-10-09T09:55:57Z",
   "kind": "milestoned",
   "who": "maflcko"
  }
 ],
 "text_chars": 1752,
 "text_tokens_estimate": 438,
 "changed_paths": [
  "doc/release-notes-36488.md",
  "src/wallet/rpc/spend.cpp",
  "test/functional/rpc_deprecated.py",
  "test/functional/wallet_bumpfee.py"
 ],
 "files": [
  {
   "path": "doc/release-notes-36488.md",
   "add": 8,
   "del": 0
  },
  {
   "path": "src/wallet/rpc/spend.cpp",
   "add": 5,
   "del": 1
  },
  {
   "path": "test/functional/rpc_deprecated.py",
   "add": 4,
   "del": 0
  },
  {
   "path": "test/functional/wallet_bumpfee.py",
   "add": 1,
   "del": 0
  }
 ],
 "test_lines": 5,
 "git": {
  "head": "fab22ac42e350d4b4481515fe8ba2a319a744389",
  "head_matches_backup": true,
  "base": "0a8e904ceeae38d0e310d7ce569370ed71689e59",
  "patch_id": "baffc319dc8297c3",
  "commits": [
   {
    "sha": "fab22ac42e",
    "subject": "rpc: wallet: Schedule mixed-case confTarget option deprecation",
    "files": 4,
    "add": 18,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "baffc319dc8297c3",
 "input_hash": "39efb8e0d31de2b6",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}