{
 "number": 36563,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36563",
 "title": "Cover additional script edge cases with the json fixtures",
 "author": "reardencode",
 "author_association": "FIRST_TIME_CONTRIBUTOR",
 "created_at": "2026-10-18T11:24:39Z",
 "updated_at": "2026-10-20T08:39:12Z",
 "description_hash": "dd508db9a5a3f0c9",
 "age_days": 14,
 "draft": false,
 "labels": [],
 "milestone": null,
 "base": "master",
 "head_sha": "60bb41f4940c7aa5553d7fe5223e0a9d6d147f5c",
 "head_ref": "script-sigversion-vectors",
 "head_repo": "reardencode/bitcoin",
 "head_history": [],
 "additions": 196,
 "deletions": 0,
 "changed_files": 2,
 "commit_count": 5,
 "size_bucket": "M",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "Yudis-bit",
      "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6286977843"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "Yudis-bit": {
   "kind": "ack",
   "hash": "60bb41f494",
   "t": "2026-10-20T08:39:08Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "Yudis-bit",
   "fanquake",
   "instagibbs"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-19T14:22:17Z",
  "last_reviewer_activity": "2026-10-20T08:39:08Z",
  "last_reviewer": "Yudis-bit",
  "author_silent_days": 13,
  "waiting_on_author_days": 12,
  "days_since_update": 12
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "During rbitcoin's development, we created some additional script test vectors, some of which seem like they would be valuable additions to bitcoin core's script tests.\n\nThese cover mostly script limits on various versions, but also the non-FindAndDelete behavior of witness v0.",
 "commits": [
  {
   "sha": "ba7d25967009dcdfd4d32a0281cdc0b495b3a678",
   "date": "2026-10-18T11:14:54Z",
   "message": "test: assert v0 and tapscript size limits\n\nAdd script tests for witness v0 size limits and the lack of those same\nlimits in tapscript."
  },
  {
   "sha": "efb5d657bcfd2a0cc242d8e77c4dc705dc43f544",
   "date": "2026-10-18T11:16:43Z",
   "message": "test: assert OP_SUCCESS before script limits\n\nAdd script tests that verify OP_SUCCESS handling before script limits\nare applied."
  },
  {
   "sha": "320ea87bf97dab4d2584815773057468757da6f0",
   "date": "2026-10-18T11:18:16Z",
   "message": "test: assert witness v0 scripts skip FindAndDelete\n\nAdd script tests validating the lack of FindAndDelete behavior when\nexecuting witness v0 scripts."
  },
  {
   "sha": "43e35d6a50aa06659378ee521dadd57cdd01b7fd",
   "date": "2026-10-18T11:19:15Z",
   "message": "test: assert tapscript signature weight budget\n\nAdd script tests for tapscript signature weight, including for\nnon-empty, non-32-byte keys, and empty and non-empty signatures."
  },
  {
   "sha": "60bb41f4940c7aa5553d7fe5223e0a9d6d147f5c",
   "date": "2026-10-18T11:20:53Z",
   "message": "test: assert unknown tapleaf versions skip limits\n\nAdd script tests that validate unknown tapleaves are not subject to\ntapleaf 0xc2 witness limits."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-19T07:34:17Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "cc @instagibbs / @darosior",
   "id": "c:6262112201",
   "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6262112201",
   "hash": "6bf1cd7ac8f7f53f",
   "edited": "2026-10-19T07:34:28Z"
  },
  {
   "t": "2026-10-19T13:35:52Z",
   "kind": "comment",
   "who": "instagibbs",
   "assoc": "MEMBER",
   "text": "@reardencode are you looking to throw this over the fence or will you update it on review, or are you still going to add stuff later?\n\nJust want to know what to do with this",
   "id": "c:6268527761",
   "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6268527761",
   "hash": "ed927f01c87879b3",
   "edited": null
  },
  {
   "t": "2026-10-19T14:22:17Z",
   "kind": "comment",
   "who": "reardencode",
   "assoc": "NONE",
   "text": "Happy to update based on review. Not specifically planning to add stuff in the near future, but if we find other interesting cases and this kind of thing is useful to y'all, we'll make additional PRs later.",
   "id": "c:6269505393",
   "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6269505393",
   "hash": "a618117eb43a6a7b",
   "edited": null
  },
  {
   "t": "2026-10-20T08:39:08Z",
   "kind": "comment",
   "who": "Yudis-bit",
   "assoc": "NONE",
   "text": "Tested ACK 60bb41f494 on Windows.",
   "id": "c:6286977843",
   "url": "https://github.com/bitcoin/bitcoin/pull/36563#issuecomment-6286977843",
   "hash": "6e83761b15b8e05b",
   "edited": null
  }
 ],
 "labels_log": [],
 "state_log": [
  {
   "t": "2026-10-19T14:21:20Z",
   "kind": "ready_for_review",
   "who": "reardencode"
  }
 ],
 "text_chars": 1514,
 "text_tokens_estimate": 378,
 "changed_paths": [
  "src/test/data/script_tests.json",
  "src/test/script_tests.cpp"
 ],
 "files": [
  {
   "path": "src/test/data/script_tests.json",
   "add": 194,
   "del": 0
  },
  {
   "path": "src/test/script_tests.cpp",
   "add": 2,
   "del": 0
  }
 ],
 "test_lines": 196,
 "git": {
  "head": "60bb41f4940c7aa5553d7fe5223e0a9d6d147f5c",
  "head_matches_backup": true,
  "base": "924f4c4ac78b0cd3b917c694f42c0651a6f3003a",
  "patch_id": "d65c2666d9189c09",
  "commits": [
   {
    "sha": "ba7d259670",
    "subject": "test: assert v0 and tapscript size limits",
    "files": 1,
    "add": 32,
    "del": 0
   },
   {
    "sha": "efb5d657bc",
    "subject": "test: assert OP_SUCCESS before script limits",
    "files": 1,
    "add": 85,
    "del": 0
   },
   {
    "sha": "320ea87bf9",
    "subject": "test: assert witness v0 scripts skip FindAndDelete",
    "files": 1,
    "add": 1,
    "del": 0
   },
   {
    "sha": "43e35d6a50",
    "subject": "test: assert tapscript signature weight budget",
    "files": 2,
    "add": 29,
    "del": 0
   },
   {
    "sha": "60bb41f494",
    "subject": "test: assert unknown tapleaf versions skip limits",
    "files": 2,
    "add": 49,
    "del": 0
   }
  ],
  "patch_truncated": true
 },
 "patch_id": "d65c2666d9189c09",
 "input_hash": "96929feeaed06bf3",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}