{
 "number": 36570,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36570",
 "title": "i2p: pass base32 address directly to stream connect",
 "author": "jpk68",
 "author_association": "CONTRIBUTOR",
 "created_at": "2026-10-19T00:14:42Z",
 "updated_at": "2026-10-19T03:14:38Z",
 "description_hash": "48157606c3479aab",
 "age_days": 14,
 "draft": false,
 "labels": [],
 "milestone": null,
 "base": "master",
 "head_sha": "abbdec21490ffb355c7918bdb3b9b16aa0e75e4b",
 "head_ref": "i2p-connect",
 "head_repo": "jpk68/bitcoin",
 "head_history": [],
 "additions": 1,
 "deletions": 6,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": false,
   "reviews": {},
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fanquake"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-19T00:05:20Z",
  "last_reviewer_activity": "2026-10-19T03:14:38Z",
  "last_reviewer": "fanquake",
  "author_silent_days": 14,
  "waiting_on_author_days": 13,
  "days_since_update": 13
 },
 "refs": {
  "mentioned": [
   35696
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 35696,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-09-25",
    "title": "i2p: update leaseset encryption types"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "As the SAM protocol accepts a `.b32.i2p` address as the `DESTINATION` parameter for the `STREAM CONNECT` command, the `NAMING LOOKUP` round trip can be skipped on every outbound connection.\n\nThis should ostensibly make failure handling more accurate in certain situations as well, since a peer that cannot be resolved now returns `CANT_REACH_PEER`/`TIMEOUT` rather than there being an empty `VALUE=` key in the lookup reply. A missing `VALUE=` is a proxy error, so the attempt isn't recorded in AddrMan.\n\nRouter implementation versions that support this (Java I2P 0.9.48, i2pd 2.38.0) are older than ones supporting `i2cp.leaseSetEncType=6,4` (see #35696), so there should be no compatibility issues here.\n\nSource:\nhttps://i2p.net/en/docs/api/samv3/#sam-virtual-streams-connect",
 "commits": [
  {
   "sha": "abbdec21490ffb355c7918bdb3b9b16aa0e75e4b",
   "date": "2026-10-19T00:05:20Z",
   "message": "i2p: pass base32 address directly to stream connect"
  }
 ],
 "timeline": [
  {
   "t": "2026-10-19T03:14:38Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "cc @davidgumberg @jonatack",
   "id": "c:6258856189",
   "url": "https://github.com/bitcoin/bitcoin/pull/36570#issuecomment-6258856189",
   "hash": "caa10890a57b6b6d",
   "edited": null
  }
 ],
 "labels_log": [],
 "state_log": [],
 "text_chars": 907,
 "text_tokens_estimate": 226,
 "changed_paths": [
  "src/i2p.cpp"
 ],
 "files": [
  {
   "path": "src/i2p.cpp",
   "add": 1,
   "del": 6
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "abbdec21490ffb355c7918bdb3b9b16aa0e75e4b",
  "head_matches_backup": true,
  "base": "924f4c4ac78b0cd3b917c694f42c0651a6f3003a",
  "patch_id": "d343a1a4a4d947e1",
  "commits": [
   {
    "sha": "abbdec2149",
    "subject": "i2p: pass base32 address directly to stream connect",
    "files": 1,
    "add": 1,
    "del": 6
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "d343a1a4a4d947e1",
 "input_hash": "800fde782703ff06",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}