{
 "number": 36580,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36580",
 "title": "refactor: Use util::log::FormatString in BaseIndex::FatalErrorf and LogConnectFailure",
 "author": "maflcko",
 "author_association": "MEMBER",
 "created_at": "2026-10-20T09:20:39Z",
 "updated_at": "2026-10-21T09:35:05Z",
 "description_hash": "6e9ed63f086284a1",
 "age_days": 12,
 "draft": false,
 "labels": [
  "Refactoring"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "fafbcadc1bc512e16154649984d48b60a54f5f9d",
 "head_ref": "2610-log-format-string",
 "head_repo": "maflcko/bitcoin-core",
 "head_history": [
  {
   "t": "2026-10-20T10:19:44Z",
   "sha": "fafbcadc1bc512e16154649984d48b60a54f5f9d"
  }
 ],
 "additions": 6,
 "deletions": 7,
 "changed_files": 3,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "stickies-v",
      "url": "https://github.com/bitcoin/bitcoin/pull/36580#pullrequestreview-5597709570"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "stickies-v": {
   "kind": "ack",
   "hash": "fafbcadc1bc512e16154649984d48b60a54f5f9d",
   "t": "2026-10-21T09:35:02Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "stickies-v"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-20T10:19:44Z",
  "last_reviewer_activity": "2026-10-21T09:35:02Z",
  "last_reviewer": "stickies-v",
  "author_silent_days": 12,
  "waiting_on_author_days": 11,
  "days_since_update": 11
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Both functions format a message that is ultimately logged, so it must not contain a redundant trailing newline. Otherwise, it could lead to escaped \\x0a inside log messages.\n\nThis continues https://github.com/bitcoin/bitcoin/pull/36397",
 "commits": [
  {
   "sha": "fafbcadc1bc512e16154649984d48b60a54f5f9d",
   "date": "2026-10-20T10:19:31Z",
   "message": "refactor: Use util::log::FormatString in BaseIndex::FatalErrorf and LogConnectFailure\n\nBoth functions format a message to be logged, so it must not contain a\nredundant trailing newline. Otherwise, it could lead to escaped \\x0a\ninside log messages."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-20T10:19:44Z",
   "kind": "force_push",
   "who": "maflcko",
   "commit": "fafbcadc1bc512e16154649984d48b60a54f5f9d",
   "id": "push:fafbcadc1bc512e16154649984d48b60a54f5f9d"
  },
  {
   "t": "2026-10-21T09:35:02Z",
   "kind": "review",
   "who": "stickies-v",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "fafbcadc1bc512e16154649984d48b60a54f5f9d",
   "text": "ACK fafbcadc1bc512e16154649984d48b60a54f5f9d",
   "id": "r:5597709570",
   "url": "https://github.com/bitcoin/bitcoin/pull/36580#pullrequestreview-5597709570",
   "hash": "a3131f11b8dcf494",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-20T09:20:43Z",
   "action": "labeled",
   "label": "Refactoring",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-20T10:00:53Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-20T11:10:13Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 614,
 "text_tokens_estimate": 153,
 "changed_paths": [
  "src/index/base.cpp",
  "src/index/base.h",
  "src/netbase.cpp"
 ],
 "files": [
  {
   "path": "src/index/base.cpp",
   "add": 1,
   "del": 2
  },
  {
   "path": "src/index/base.h",
   "add": 3,
   "del": 3
  },
  {
   "path": "src/netbase.cpp",
   "add": 2,
   "del": 2
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "fafbcadc1bc512e16154649984d48b60a54f5f9d",
  "head_matches_backup": true,
  "base": "6799119cef7ead71e2b2fc7928a0ea58d720c708",
  "patch_id": "6f3badab743d3507",
  "commits": [
   {
    "sha": "fafbcadc1b",
    "subject": "refactor: Use util::log::FormatString in BaseIndex::FatalErrorf and LogConnectFailure",
    "files": 3,
    "add": 6,
    "del": 7
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "6f3badab743d3507",
 "input_hash": "e7834136c2fa8182",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}