{
 "number": 36601,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36601",
 "title": "test: avoid reusing AssumeUTXO coin insertion method in test fixtures",
 "author": "l0rinc",
 "author_association": "MEMBER",
 "created_at": "2026-10-22T07:36:05Z",
 "updated_at": "2026-10-30T15:00:39Z",
 "description_hash": "3c4d1e7d5508cd41",
 "age_days": 10,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "1c62336903ccf5f7f2aa1217eaf8344dee4e197a",
 "head_ref": "l0rinc/coins-tests-without-snapshot-bypass",
 "head_repo": "l0rinc/bitcoin",
 "head_history": [],
 "additions": 10,
 "deletions": 6,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "Hamza1610",
      "url": "https://github.com/bitcoin/bitcoin/pull/36601#issuecomment-6365340911"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "Hamza1610": {
   "kind": "ack",
   "hash": "1c62336903",
   "t": "2026-10-23T12:53:49Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "Hamza1610"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-22T07:19:59Z",
  "last_reviewer_activity": "2026-10-23T12:53:49Z",
  "last_reviewer": "Hamza1610",
  "author_silent_days": 10,
  "waiting_on_author_days": 9,
  "days_since_update": 2
 },
 "refs": {
  "mentioned": [
   35295,
   36598
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 36598,
    "type": "pull",
    "state": "open",
    "merged": false,
    "merged_at": null,
    "title": "[Demo] validation: remove AssumeUTXO"
   },
   {
    "number": 35295,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-07-09",
    "title": "validation: fetch block input prevouts in parallel during ConnectBlock"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [
   36598
  ],
  "based_on": [],
  "base_for": [
   36598
  ]
 },
 "review_paths": [],
 "body": "**Problem:** Several coin-cache fixtures use `EmplaceCoinInternalDANGER` just to set up their coins, even though it is reserved for snapshot loading.\n\n**Fix:** Use `AddCoin` and `SpendCoin` for fixture setup, keeping the entries dirty but not fresh, as before. Keep the [simulation](https://github.com/bitcoin/bitcoin/pull/33512), [fuzz and duplicate-insertion coverage](https://github.com/bitcoin/bitcoin/pull/32313) that intentionally tests the bypass.\n\nThis is a small extraction from #36598 that can be reviewed and merged independently of the broader AssumeUTXO removal demo. The overlay fixture change also follows the earlier [suggestion in #35295](https://github.com/bitcoin/bitcoin/pull/35295#discussion_r3421846300).",
 "commits": [
  {
   "sha": "1c62336903ccf5f7f2aa1217eaf8344dee4e197a",
   "date": "2026-10-22T07:19:59Z",
   "message": "test: avoid snapshot insertion in coin fixtures\n\nUse `AddCoin` and `SpendCoin` to set up the flush, reset and overlay tests, leaving direct coverage of `EmplaceCoinInternalDANGER` in the simulation, fuzz target and duplicate-insertion test.\nSet `possible_overwrite=true` to keep the entries DIRTY but not FRESH, as before."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-23T12:53:49Z",
   "kind": "comment",
   "who": "Hamza1610",
   "assoc": "NONE",
   "text": "Tested ACK 1c62336903\nRan `./build/bin/test_bitcoin -t coins_tests,coinsviewoverlay_tests` with, clean and structured changes.\n[quoted text omitted]",
   "id": "c:6365340911",
   "url": "https://github.com/bitcoin/bitcoin/pull/36601#issuecomment-6365340911",
   "hash": "5c7052a64f4da513",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-22T07:36:09Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-22T08:34:06Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-22T08:55:51Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 1267,
 "text_tokens_estimate": 316,
 "changed_paths": [
  "src/test/coins_tests.cpp",
  "src/test/coinsviewoverlay_tests.cpp"
 ],
 "files": [
  {
   "path": "src/test/coins_tests.cpp",
   "add": 2,
   "del": 2
  },
  {
   "path": "src/test/coinsviewoverlay_tests.cpp",
   "add": 8,
   "del": 4
  }
 ],
 "test_lines": 16,
 "git": {
  "head": "1c62336903ccf5f7f2aa1217eaf8344dee4e197a",
  "head_matches_backup": true,
  "base": "de96f3ae6d163e97a2cf29bbd7c2bf2d56e11019",
  "patch_id": "20d727b991027e92",
  "commits": [
   {
    "sha": "1c62336903",
    "subject": "test: avoid snapshot insertion in coin fixtures",
    "files": 2,
    "add": 10,
    "del": 6
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "20d727b991027e92",
 "input_hash": "2e3bce99d5767211",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}