{
 "number": 36615,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36615",
 "title": "guix: add --no-same-owner to codesign.sh TAR_OPTIONS",
 "author": "marcofleon",
 "author_association": "MEMBER",
 "created_at": "2026-10-22T20:11:44Z",
 "updated_at": "2026-10-30T14:58:41Z",
 "description_hash": "78179e10c3bd5036",
 "age_days": 10,
 "draft": false,
 "labels": [
  "Build system"
 ],
 "milestone": "32.2",
 "base": "master",
 "head_sha": "d2e5108ea2ddce1952d4db8b42d39a40e3d9f521",
 "head_ref": "codesign-tar-options",
 "head_repo": "marcofleon/bitcoin",
 "head_history": [],
 "additions": 1,
 "deletions": 1,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "concept_ack": [
     {
      "login": "fanquake",
      "url": "https://github.com/bitcoin/bitcoin/pull/36615#issuecomment-6364059489"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "fanquake": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-10-23T11:41:40Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fanquake",
   "willcl-ark"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-22T20:13:03Z",
  "last_reviewer_activity": "2026-10-30T14:58:41Z",
  "last_reviewer": "fanquake",
  "author_silent_days": 10,
  "waiting_on_author_days": 2,
  "days_since_update": 2
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Just ran `guix-codesign` for v32.0 as root, in fanquake's container image ([option 3](https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/INSTALL.md#option-3-using-fanquakes-container-image) in INSTALL.md) and got this error while unpacking the codesigning tarball:\n\n```bash\ntar: ./detached-sig-create.sh: Cannot change ownership to uid 0, gid 0: Invalid argument\ntar: ./unsigned/bitcoin-32.0: Cannot change ownership to uid 0, gid 0: Invalid argument\ntar: ./unsigned/bitcoin-32.0-win64-setup-unsigned.exe: Cannot change ownership to uid 0, gid 0: Invalid argument\n...\ntar: Exiting with failure status due to previous errors\n```\nSame happens for the macOS files.\n\nWhen updating guix in https://github.com/bitcoin/bitcoin/pull/34550, `--no-same-owner` was added in `build.sh` (now in `setup.sh`) in 0f323e10759aba4429677d0e1e202bf575b6d664, but not in `codesign.sh`. This PR adds it to `TAR_OPTIONS` in `codesign.sh`. This fixed the issue for me and my hashes match the other attestations for v32.0.",
 "commits": [
  {
   "sha": "d2e5108ea2ddce1952d4db8b42d39a40e3d9f521",
   "date": "2026-10-22T19:49:34Z",
   "message": "guix: add --no-same-owner to codesign.sh TAR_OPTIONS"
  }
 ],
 "timeline": [
  {
   "t": "2026-10-22T20:13:03Z",
   "kind": "comment",
   "who": "marcofleon",
   "assoc": "MEMBER",
   "text": "Bit out of my depth here, so if there's a reason to not add this option for codesigning or I just shouldn't be doing this as root or something, let me know.",
   "id": "c:6350290855",
   "url": "https://github.com/bitcoin/bitcoin/pull/36615#issuecomment-6350290855",
   "hash": "afdcb9dc66c2b69a",
   "edited": null
  },
  {
   "t": "2026-10-23T11:41:40Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "Concept ACK",
   "id": "c:6364059489",
   "url": "https://github.com/bitcoin/bitcoin/pull/36615#issuecomment-6364059489",
   "hash": "e8334cc43879b73c",
   "edited": null
  },
  {
   "t": "2026-10-26T21:08:11Z",
   "kind": "comment",
   "who": "willcl-ark",
   "assoc": "MEMBER",
   "text": "Could that var be extracted into libexec/prelude.sh to avoid repeats?",
   "id": "c:6427359185",
   "url": "https://github.com/bitcoin/bitcoin/pull/36615#issuecomment-6427359185",
   "hash": "707882341e54132d",
   "edited": null
  },
  {
   "t": "2026-10-30T14:58:41Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nYes I think so.",
   "id": "c:6525844902",
   "url": "https://github.com/bitcoin/bitcoin/pull/36615#issuecomment-6525844902",
   "hash": "4c6eed0c8b5ee11e",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-22T20:11:48Z",
   "action": "labeled",
   "label": "Build system",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-10-26T22:43:32Z",
   "kind": "milestoned",
   "who": "fanquake"
  }
 ],
 "text_chars": 1389,
 "text_tokens_estimate": 347,
 "changed_paths": [
  "contrib/guix/libexec/codesign.sh"
 ],
 "files": [
  {
   "path": "contrib/guix/libexec/codesign.sh",
   "add": 1,
   "del": 1
  }
 ],
 "test_lines": 2,
 "git": {
  "head": "d2e5108ea2ddce1952d4db8b42d39a40e3d9f521",
  "head_matches_backup": true,
  "base": "152a55397e451fed9c10041bddf01aa6839847d5",
  "patch_id": "31a6cb78d80090d6",
  "commits": [
   {
    "sha": "d2e5108ea2",
    "subject": "guix: add --no-same-owner to codesign.sh TAR_OPTIONS",
    "files": 1,
    "add": 1,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "31a6cb78d80090d6",
 "input_hash": "6df20f939ebf0d35",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}