{
 "number": 36632,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36632",
 "title": "kernel: document the import_blocks abort",
 "author": "fametrano",
 "author_association": "FIRST_TIME_CONTRIBUTOR",
 "created_at": "2026-10-23T21:59:36Z",
 "updated_at": "2026-11-01T18:36:36Z",
 "description_hash": "7a5cc1c40d4e66ab",
 "age_days": 9,
 "draft": false,
 "labels": [
  "Validation"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "2077d1571ee98f8b2fba611e8bdfc73797b8bd3f",
 "head_ref": "kernel-doc-process-block-dos",
 "head_repo": "fametrano/bitcoin",
 "head_history": [
  {
   "t": "2026-11-01T18:35:54Z",
   "sha": "2077d1571ee98f8b2fba611e8bdfc73797b8bd3f"
  }
 ],
 "additions": 4,
 "deletions": 0,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {},
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "sedited"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-11-01T18:36:36Z",
  "last_reviewer_activity": "2026-10-26T10:21:11Z",
  "last_reviewer": "sedited",
  "author_silent_days": 0,
  "waiting_on_author_days": 0,
  "days_since_update": 0
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "A second btck_chainstate_manager_import_blocks call on the same chainstate manager, while one is in progress, aborts the process, and the kernel header does not say so. I document it. The abort is the assert in ImportingNow in node/blockstorage.cpp, which I keep.",
 "commits": [
  {
   "sha": "2077d1571ee98f8b2fba611e8bdfc73797b8bd3f",
   "date": "2026-11-01T08:16:06Z",
   "message": "kernel: document the import_blocks abort\n\nA second btck_chainstate_manager_import_blocks call on the same\nchainstate manager, while one is in progress, aborts the process. The\nheader does not say so.\n\nI add it to the header. I keep the assert in ImportingNow."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-26T10:21:11Z",
   "kind": "comment",
   "who": "sedited",
   "assoc": "MEMBER",
   "text": "The first commit seems already documented to me. The second one's importblocks behaviour seems ok to add.",
   "id": "c:6413657247",
   "url": "https://github.com/bitcoin/bitcoin/pull/36632#issuecomment-6413657247",
   "hash": "566f801ccac09e09",
   "edited": null
  },
  {
   "t": "2026-11-01T18:35:54Z",
   "kind": "force_push",
   "who": "fametrano",
   "commit": "2077d1571ee98f8b2fba611e8bdfc73797b8bd3f",
   "id": "push:2077d1571ee98f8b2fba611e8bdfc73797b8bd3f"
  },
  {
   "t": "2026-11-01T18:36:36Z",
   "kind": "comment",
   "who": "fametrano",
   "assoc": "NONE",
   "text": "Dropped the first commit and the `spent_outputs_len` note. The PR now only documents the `import_blocks` abort you said is ok to add.",
   "id": "c:6562169922",
   "url": "https://github.com/bitcoin/bitcoin/pull/36632#issuecomment-6562169922",
   "hash": "4ee93344f26839e4",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-23T21:59:42Z",
   "action": "labeled",
   "label": "Validation",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-10-24T08:11:26Z",
   "kind": "renamed",
   "who": "fametrano",
   "from": "kernel: document that process_block stores unrequested blocks",
   "to": "kernel: document process_block storage and two aborting preconditions"
  },
  {
   "t": "2026-11-01T18:36:19Z",
   "kind": "renamed",
   "who": "fametrano",
   "from": "kernel: document process_block storage and two aborting preconditions",
   "to": "kernel: document the import_blocks abort"
  }
 ],
 "text_chars": 804,
 "text_tokens_estimate": 201,
 "changed_paths": [
  "src/kernel/bitcoinkernel.h"
 ],
 "files": [
  {
   "path": "src/kernel/bitcoinkernel.h",
   "add": 11,
   "del": 1
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "dda2c1f325e8e4a30dc4a41e35f42db434939f40",
  "head_matches_backup": true,
  "base": "a773e1e33b349dc819b5a0edc1c7a4839dc73b48",
  "patch_id": "812e4a63634a4ea2",
  "commits": [
   {
    "sha": "ed2c4a344a",
    "subject": "kernel: document that process_block stores unrequested blocks",
    "files": 1,
    "add": 4,
    "del": 0
   },
   {
    "sha": "dda2c1f325",
    "subject": "kernel: document two aborting preconditions",
    "files": 1,
    "add": 7,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "812e4a63634a4ea2",
 "input_hash": "cfda987cdd31220c",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}