{
 "number": 36636,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36636",
 "title": "netaddress: make .onion suffix check case-insensitive",
 "author": "jpk68",
 "author_association": "CONTRIBUTOR",
 "created_at": "2026-10-24T02:18:53Z",
 "updated_at": "2026-10-26T22:12:55Z",
 "description_hash": "7bd77423e541be3d",
 "age_days": 8,
 "draft": false,
 "labels": [],
 "milestone": null,
 "base": "master",
 "head_sha": "0574f096abf0cfe75501542efe1787679340d3d3",
 "head_ref": "onion-check",
 "head_repo": "jpk68/bitcoin",
 "head_history": [],
 "additions": 10,
 "deletions": 2,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "vasild",
      "url": "https://github.com/bitcoin/bitcoin/pull/36636#pullrequestreview-5637653085"
     },
     {
      "login": "AndreaDiazCorreia",
      "url": "https://github.com/bitcoin/bitcoin/pull/36636#pullrequestreview-5643376401"
     },
     {
      "login": "Husteem",
      "url": "https://github.com/bitcoin/bitcoin/pull/36636#issuecomment-6423711667"
     },
     {
      "login": "winterrdog",
      "url": "https://github.com/bitcoin/bitcoin/pull/36636#pullrequestreview-5659812839"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "vasild": {
   "kind": "ack",
   "hash": "0574f096abf0cfe75501542efe1787679340d3d3",
   "t": "2026-10-24T09:08:51Z",
   "stale": false
  },
  "AndreaDiazCorreia": {
   "kind": "ack",
   "hash": "0574f096abf0cfe75501542efe1787679340d3d3",
   "t": "2026-10-25T13:24:27Z",
   "stale": false
  },
  "Husteem": {
   "kind": "ack",
   "hash": null,
   "t": "2026-10-26T18:08:24Z",
   "stale": false
  },
  "winterrdog": {
   "kind": "ack",
   "hash": "0574f096abf0cfe75501542efe1787679340d3d3",
   "t": "2026-10-26T22:12:51Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 4,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "AndreaDiazCorreia",
   "Husteem",
   "vasild",
   "winterrdog"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-24T02:13:57Z",
  "last_reviewer_activity": "2026-10-26T22:12:51Z",
  "last_reviewer": "winterrdog",
  "author_silent_days": 8,
  "waiting_on_author_days": 6,
  "days_since_update": 6
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Makes the suffix/TLD check case-insensitive when parsing `.onion` addresses, as is already done for I2P hostnames. With the current code, a name like `<addr>.ONION` will not be parsed as a Tor address, and will instead fall through to regular hostname resolution.",
 "commits": [
  {
   "sha": "0574f096abf0cfe75501542efe1787679340d3d3",
   "date": "2026-10-24T02:13:57Z",
   "message": "netaddress: make .onion suffix check case-insensitive"
  }
 ],
 "timeline": [
  {
   "t": "2026-10-24T09:08:51Z",
   "kind": "review",
   "who": "vasild",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "0574f096abf0cfe75501542efe1787679340d3d3",
   "text": "ACK 0574f096abf0cfe75501542efe1787679340d3d3\n\nShow Signature\n\n```\n-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA256\n\nACK 0574f096abf0cfe75501542efe1787679340d3d3\n-----BEGIN PGP SIGNATURE-----\n\niQRPBAEBCAA5FiEE5k2NRWFNsHVF2czBVN8G9ktVy78FAmrcdTobFIAAAAAABAAO\nbWFudTIsMi41KzEuMTIsMiwzAAoJEFTfBvZLVcu/dV8f/1vDOoGWU1M0Q8ClJaod\nUATWwEHNI47tXPISqPpqoqtISp8Kv1MBeSX4GjVZhpDPRcqRdBfMPyC2GigQgiwY\nOiS8fjwvBsK+28XigejMSd4vWJdxUpzLBv8lsZaCDeGLWDirVEbPTdbWYKF47A4G\nIE5K3PunX7kUaRGOz/pE/NEVyLvE4L715SMstp2imx3Srnnw48XZmFekAU7jUG8M\nHJcX2g1K3X58P77vwsYv2LyXJlWkZ5FejcwBYg2we5YCQGjNEEtDrd7/knmw1bx9\nGLtXZNxmqEajPnZAopQKqZWsMIaJO3Am6+fYDXaweZSVhoWpvY4miMYmxPxIY5v/\nwcTl/YYV5G3KMbxSBvFo5rW3ew9QI3hxIc1rEKDFI4+JzYIdd8LpcK/qdGvKrgEz\n5knSPDm5OGqN+W9k3nIGIs9eFdAlLuKJNDpJVeg+i/wB5q4sLyuktXeK4LdFkXBR\n7q+Fl4VcWJDgpKaEVnGVvg9Ggf3HtOfkUzMkMznxPtwUZ7im1utCxePqOS4kC0AO\nZBpOr7Hw8gvwCmlvIKN+vEWU7nikRljesESC4izn4NfTbcS/QICurF7By2o35jG0\nOF2M9ey2nuQfmiRzn/lIzi39kiugKcDAHMBTUoa5mLduX/VOVIPey6lT5kI4zOML\nFyShu1tuaRvwvAG0tAuwFS4WgZGO/0YPQls/8ALYnlKe9WwAoIzsY7RvFPlpQoIw\nA95EKFvI1LlgJ4ZLhMgeAF2i7dInMI8N0lUIdGWgnUxUiAXlisAva6KFbWBg/PcH\nWwkC6Hbo9iz+shuBoH9fWwdON7eZkFxGZbOBHPNasNhJIZ8Xj0wBXREUW8z/7OqT\nq6Yot8V6/2Z8mdieH9uJlXFpslGhqmTgZU/gdUUz105B3yFyCJIP12hkrzKLmIPi\nFgKFf6mnYbeg8RL4NCmDzzUfvC4dlSvRaWsS1JhhyGglhL3PR/q/NU4bZe0omb7h\n0gTzLgC2k1J5OunyghLgX7YRfFefoNcQUB4unt+VciYTZ4MSBd6jwPFZ07Ft3uGF\nxL2chNh6l4GYZJzLsxWmw4F/Ewbk8hVsBDVBWT7/COdgkcMFZyIgQWHGY7Ly2gTU\naxo4yheGa1fqz0c99JtsHdk8EDO/SayOKNYtDzmriIcDQMQfSoSkdyW9W8dPCFgY\nozJnUKz6JWeA9hbJvOJvoJjeH27RCjlXgXtX/F3ZVNv84NntXm4jTr/oBG9VLGi/\n3OZt/2kd1Sy6QRYRw7/FQ6MkYRGhIGdJmfURRTtDZGO6ma6Z4znPAtU7KBK6mvP1\nfJWg3LJiLYPHLn1JnVPR556g6QhUEHY2kIQodYb8qMSwRgJVH3n+ASB0+D/P8eaw\n0r4=\n=f7eZ\n-----END PGP SIGNATURE-----\n```\n\nvasild's public key is [on openpgp.org](https://keys.openpgp.org/vks/v1/by-fingerprint/850E138BA9C0923881DFD55FCE712013582E2230)",
   "id": "r:5637653085",
   "url": "https://github.com/bitcoin/bitcoin/pull/36636#pullrequestreview-5637653085",
   "hash": "9c4246db2e0bfaaa",
   "edited": null
  },
  {
   "t": "2026-10-25T13:24:27Z",
   "kind": "review",
   "who": "AndreaDiazCorreia",
   "assoc": "NONE",
   "state": "COMMENTED",
   "commit": "0574f096abf0cfe75501542efe1787679340d3d3",
   "text": "ACK 0574f096abf0cfe75501542efe1787679340d3d3\n\nBuilt and ran net_tests, netbase_tests, and base32_tests successfully. Confirmed the new test fails with the parent\u2019s netaddress.cpp.",
   "id": "r:5643376401",
   "url": "https://github.com/bitcoin/bitcoin/pull/36636#pullrequestreview-5643376401",
   "hash": "aef0837a64d13ef5",
   "edited": null
  },
  {
   "t": "2026-10-26T18:08:24Z",
   "kind": "comment",
   "who": "Husteem",
   "assoc": "NONE",
   "text": "ACK [0574f09](https://github.com/bitcoin/bitcoin/pull/36636/commits/0574f096abf0cfe75501542efe1787679340d3d3)\n\nOne non-blocking nit\n`ToLower(addr.substr(...))` creates a temporary `std::string` (though 6 chars fits within SSO).\nUsing `CaseInsensitiveEqual(addr.substr(addr.size() - suffix.size()), suffix)` from `util/strencodings.h` avoids the temporary string entirely.\nIt would be nice to use that here (and similarly in SetI2P()) for consistency,",
   "id": "c:6423711667",
   "url": "https://github.com/bitcoin/bitcoin/pull/36636#issuecomment-6423711667",
   "hash": "9b2ce51aa8ab13e2",
   "edited": null
  },
  {
   "t": "2026-10-26T22:12:51Z",
   "kind": "review",
   "who": "winterrdog",
   "assoc": "CONTRIBUTOR",
   "state": "COMMENTED",
   "commit": "0574f096abf0cfe75501542efe1787679340d3d3",
   "text": "tested ACK 0574f096abf0cfe75501542efe1787679340d3d3\n\nsuccessfully built and tested on: Windows `10`/MSVC `19.51.36257`/`x86_64`. changes LGTM and the intent is pragmatic",
   "id": "r:5659812839",
   "url": "https://github.com/bitcoin/bitcoin/pull/36636#pullrequestreview-5659812839",
   "hash": "d1495b0e7387de30",
   "edited": "2026-10-26T22:12:52Z"
  }
 ],
 "labels_log": [],
 "state_log": [],
 "text_chars": 3030,
 "text_tokens_estimate": 757,
 "changed_paths": [
  "src/netaddress.cpp",
  "src/test/net_tests.cpp"
 ],
 "files": [
  {
   "path": "src/netaddress.cpp",
   "add": 3,
   "del": 2
  },
  {
   "path": "src/test/net_tests.cpp",
   "add": 7,
   "del": 0
  }
 ],
 "test_lines": 7,
 "git": {
  "head": "0574f096abf0cfe75501542efe1787679340d3d3",
  "head_matches_backup": true,
  "base": "a773e1e33b349dc819b5a0edc1c7a4839dc73b48",
  "patch_id": "92a4fbee304bd7e6",
  "commits": [
   {
    "sha": "0574f096ab",
    "subject": "netaddress: make .onion suffix check case-insensitive",
    "files": 2,
    "add": 10,
    "del": 2
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "92a4fbee304bd7e6",
 "input_hash": "74005a1fb01c06cf",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}