{
 "number": 36679,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36679",
 "title": "ci: enable IPC in the i686 job",
 "author": "Sjors",
 "author_association": "MEMBER",
 "created_at": "2026-10-28T02:54:08Z",
 "updated_at": "2026-10-28T16:05:34Z",
 "description_hash": "069bad057cc8f74a",
 "age_days": 4,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "65ddcb4f35c5fd315ecb9d9a6d0f076b37edcadd",
 "head_ref": "2026/10/i686-ipc",
 "head_repo": "Sjors/bitcoin",
 "head_history": [],
 "additions": 6,
 "deletions": 5,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "maflcko",
      "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6462410779"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fanquake",
   "l0rinc",
   "maflcko"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-28T07:32:35Z",
  "last_reviewer_activity": "2026-10-28T16:05:34Z",
  "last_reviewer": "fanquake",
  "author_silent_days": 4,
  "waiting_on_author_days": 4,
  "days_since_update": 4
 },
 "refs": {
  "mentioned": [
   31802,
   32387,
   35491,
   36045
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 31802,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2025-08-20",
    "title": "Add bitcoin-{node,gui} to release binaries for IPC"
   },
   {
    "number": 32387,
    "type": "pull",
    "state": "open",
    "merged": false,
    "merged_at": null,
    "title": "ipc: add windows support"
   },
   {
    "number": 35491,
    "type": "issue",
    "state": "closed",
    "merged": false,
    "merged_at": null,
    "title": "mptest times out intermittently"
   },
   {
    "number": 36045,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2026-08-21",
    "title": "test: avoid undersized Boost.Test signal stacks"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Enable IPC on 32-bit x86. It was chosen arbitrarily in #31802 to have coverage for `-DENABLE_IPC=OFF`, but this was not a good choice given issues like:\n- https://github.com/bitcoin-core/libmultiprocess/pull/383\n\nI could not find a good candidate CI configuration to disable IPC.\n\nIt's still disabled on Windows, until #32387. It's also disabled on RISC-V.",
 "commits": [
  {
   "sha": "65ddcb4f35c5fd315ecb9d9a6d0f076b37edcadd",
   "date": "2026-10-28T02:30:25Z",
   "message": "ci: Enable IPC in the i686 job\n\nExercise IPC on 32-bit x86, where compiler ABI differences have caused\nfailures."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-28T03:00:37Z",
   "kind": "comment",
   "who": "Sjors",
   "assoc": "MEMBER",
   "text": "To retain coverage for more build permutations, we could introduce something like `STAGED_CONFIG=\"-DENABLE_IPC=OFF\"` which builds with that additional option first, and then rebuilds without it.",
   "id": "c:6459481702",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6459481702",
   "hash": "c1089a33435997da",
   "edited": "2026-10-28T03:00:54Z"
  },
  {
   "t": "2026-10-28T06:33:46Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "Do you recall if this ci config piece ever failed? Recall we don't have any ci for `NO_ZMQ=1` either.\n\nOtherwise, lgtm ACK 65ddcb4f35c5fd315ecb9d9a6d0f076b37edcadd\n\nThe changes here should be fine since 0136e17c0a963e82bf47c223d41f4d5c009520c0",
   "id": "c:6462410779",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6462410779",
   "hash": "34c91581ee758d89",
   "edited": null
  },
  {
   "t": "2026-10-28T07:04:13Z",
   "kind": "comment",
   "who": "Sjors",
   "assoc": "MEMBER",
   "text": "@maflcko I don't remember, but my agent found a few examples from before #31802:\n\n[quoted text omitted]",
   "id": "c:6462883532",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6462883532",
   "hash": "697b7e84ca0bb2b4",
   "edited": null
  },
  {
   "t": "2026-10-28T07:10:56Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "Sorry, I think I wasn't clear. I agree that mixed gcc+clang coverage on 32-bit is useless, given that there is likely no user for it and given that the ABI failures are likely only possible to fix with an ABI break in upstream capnp, which is isn't going to happen, or at least seems too tedious to be worth it.\n\nMy question was if there was ever a CI failure due to `-DENABLE_IPC=OFF`. I presume those would only be build issues, like a link error? I don't recall one, so I think this change is fine to do.",
   "id": "c:6462994971",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6462994971",
   "hash": "fcf63691f1a1912a",
   "edited": null
  },
  {
   "t": "2026-10-28T07:32:35Z",
   "kind": "comment",
   "who": "Sjors",
   "assoc": "MEMBER",
   "text": "Not that I recall either (the agent found https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2779056673). In general we've occasionally had build failures creep in when an option was uncovered by CI.\n\nMost would be caught by Windows and RISC-V builds, but e.g. `src/ipc/stub.cpp` is not used by RISC-V (because it's `EXCLUDE_FROM_ALL`).",
   "id": "c:6463348933",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6463348933",
   "hash": "30ba5b9c4580fc65",
   "edited": null
  },
  {
   "t": "2026-10-28T07:38:19Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "Ah, good bot. So it is mostly functional test failures and they'll be caught by Windows. If we want `-DENABLE_IPC=OFF` in the future, I think there are two options:\n\n* Set `-DENABLE_IPC=OFF` in the musl ci config (It should be unlikely there is a musl-libc-specific issue in ipc, given that we never had a musl libc issue at all?)\n* Edit: Given that the quoted issues above are about the cli, There could be a new ci config, with `-DENABLE_IPC=OFF`, possibly unit tests, bench, and the gui and zmq could be skipped. Thus, no-IPC and CLI can be run in the functional tests.\n\nBut not a blocker, just thinking for the future.",
   "id": "c:6463441345",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6463441345",
   "hash": "8917bc8021f4bd3c",
   "edited": "2026-10-28T10:52:00Z"
  },
  {
   "t": "2026-10-28T10:22:21Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "[quoted text omitted]\n\nWe just had #35491.\n\n[quoted text omitted]\nWe just had #36045.",
   "id": "c:6466476180",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6466476180",
   "hash": "3026ba6544fc6388",
   "edited": null
  },
  {
   "t": "2026-10-28T10:37:07Z",
   "kind": "comment",
   "who": "maflcko",
   "assoc": "MEMBER",
   "text": "Thx for finding those. Edit: I guess in that case a new dedicated `-DENABLE_IPC=OFF` ci config makes most sense to catch the build issues, but leave coverage up in all other ci tasks?",
   "id": "c:6466782550",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6466782550",
   "hash": "de9b0b8dd143e7ae",
   "edited": "2026-10-28T10:51:01Z"
  },
  {
   "t": "2026-10-28T11:50:17Z",
   "kind": "comment",
   "who": "l0rinc",
   "assoc": "MEMBER",
   "text": "I won't block this, but as expressed before, I don't think pretending like we fully support 32 bit architectures is the best use of our time, see https://github.com/bitcoin/bitcoin/issues/36659",
   "id": "c:6468220320",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6468220320",
   "hash": "313c3bf7f6b741a4",
   "edited": null
  },
  {
   "t": "2026-10-28T16:05:34Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "cc @ryanofsky - if you've got any thoughts here.",
   "id": "c:6474076294",
   "url": "https://github.com/bitcoin/bitcoin/pull/36679#issuecomment-6474076294",
   "hash": "062e1d882b48b247",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-28T02:54:13Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  }
 ],
 "state_log": [
  {
   "t": "2026-10-28T03:33:57Z",
   "kind": "ready_for_review",
   "who": "Sjors"
  }
 ],
 "text_chars": 3036,
 "text_tokens_estimate": 759,
 "changed_paths": [
  ".github/workflows/ci.yml",
  "ci/test/{00_setup_env_i686_no_ipc.sh => 00_setup_env_i686.sh}"
 ],
 "files": [
  {
   "path": ".github/workflows/ci.yml",
   "add": 2,
   "del": 2
  },
  {
   "path": "ci/test/{00_setup_env_i686_no_ipc.sh => 00_setup_env_i686.sh}",
   "add": 4,
   "del": 3
  }
 ],
 "test_lines": 7,
 "git": {
  "head": "65ddcb4f35c5fd315ecb9d9a6d0f076b37edcadd",
  "head_matches_backup": true,
  "base": "2b5b6fe231ff45a09d9e24411e4420d51ed45cab",
  "patch_id": "b1d1648ab58a63d5",
  "commits": [
   {
    "sha": "65ddcb4f35",
    "subject": "ci: Enable IPC in the i686 job",
    "files": 2,
    "add": 6,
    "del": 5
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "b1d1648ab58a63d5",
 "input_hash": "19ad5a2468269df3",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}