{
 "number": 36685,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36685",
 "title": "wallet: export replaces_txid and replaced_by_txid",
 "author": "vasild",
 "author_association": "MEMBER",
 "created_at": "2026-10-28T17:23:39Z",
 "updated_at": "2026-10-29T09:14:13Z",
 "description_hash": "ad3a89a49e19b1c6",
 "age_days": 4,
 "draft": false,
 "labels": [
  "Wallet"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0",
 "head_ref": "wallet_replaces_txid",
 "head_repo": "vasild/bitcoin",
 "head_history": [],
 "additions": 4,
 "deletions": 0,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "pseudoramdom",
      "url": "https://github.com/bitcoin/bitcoin/pull/36685#issuecomment-6476376176"
     },
     {
      "login": "johnny9",
      "url": "https://github.com/bitcoin/bitcoin/pull/36685#issuecomment-6480062649"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "johnny9": {
   "kind": "ack",
   "hash": "bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0",
   "t": "2026-10-28T20:34:48Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "johnny9",
   "pseudoramdom"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-28T17:34:27Z",
  "last_reviewer_activity": "2026-10-28T20:34:48Z",
  "last_reviewer": "johnny9",
  "author_silent_days": 4,
  "waiting_on_author_days": 4,
  "days_since_update": 3
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "Export the fields `replaces_txid` and `replaced_by_txid` from `wallet::CWalletTx` to `interfaces::WalletTx`.\n\nIn May 2026 https://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c hooked a usage of `interfaces::WalletTx::value_map[\"replaces_txid\"]` and `interfaces::WalletTx::value_map[\"replaced_by_txid\"]` into the QML GUI.\n\nThen, in June 2026 https://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497 removed the map entirely from the main repository, but the `replaces_txid` and `replaced_by_txid` fields were not exposed in `interfaces::WalletTx`. Thus the QML GUI has no access to them.\n\nExport the fields to solve this.\n\nThe QT5 GUI never used those.",
 "commits": [
  {
   "sha": "bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0",
   "date": "2026-10-28T17:20:46Z",
   "message": "wallet: export replaces_txid and replaced_by_txid\n\nExport the fields `replaces_txid` and `replaced_by_txid` from\n`wallet::CWalletTx` to `interfaces::WalletTx`.\n\nIn May 2026\nhttps://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c\nhooked a usage of\n`interfaces::WalletTx::value_map[\"replaces_txid\"]` and\n`interfaces::WalletTx::value_map[\"replaced_by_txid\"]` into the QML GUI.\n\nThen, in June 2026\nhttps://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497\nremoved the map entirely from the main repository, but the\n`replaces_txid` and `replaced_by_txid` fields were not exposed in\n`interfaces::WalletTx`. Thus the QML GUI has no access to them.\n\nExport the fields to solve this.\n\nThe QT5 GUI never used those."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-28T17:25:40Z",
   "kind": "comment",
   "who": "vasild",
   "assoc": "MEMBER",
   "text": "cc @pseudoramdom, @achow101\n@johnny9, @hebasto",
   "id": "c:6475903727",
   "url": "https://github.com/bitcoin/bitcoin/pull/36685#issuecomment-6475903727",
   "hash": "f7ffa41230e0120f",
   "edited": null
  },
  {
   "t": "2026-10-28T17:34:27Z",
   "kind": "comment",
   "who": "vasild",
   "assoc": "MEMBER",
   "text": "An update of the bitcoin submodule in https://github.com/bitcoin-core/gui-qml to 631b0065a7f2696a7240db4bbb63589444dc96b8:\nhttps://github.com/vasild/gui-qml/commit/f9e392e49753289bb7262771b013761a12694084\nit requires the changes in this PR.",
   "id": "c:6476096011",
   "url": "https://github.com/bitcoin/bitcoin/pull/36685#issuecomment-6476096011",
   "hash": "50d957acf740e71b",
   "edited": "2026-10-29T09:14:13Z"
  },
  {
   "t": "2026-10-28T17:47:16Z",
   "kind": "comment",
   "who": "pseudoramdom",
   "assoc": "MEMBER",
   "text": "Thanks for catching this!\nThe gui-qml is pinned to an older Core version that still exposes `value_map`. So I hadn't realized these fields had been removed from the interface.\n\n---\nACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0",
   "id": "c:6476376176",
   "url": "https://github.com/bitcoin/bitcoin/pull/36685#issuecomment-6476376176",
   "hash": "7ba33f8b6df55dee",
   "edited": null
  },
  {
   "t": "2026-10-28T20:34:48Z",
   "kind": "comment",
   "who": "johnny9",
   "assoc": "CONTRIBUTOR",
   "text": "ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0\n\nThanks for catching this. We should update the gui-qml project as soon as this merges.",
   "id": "c:6480062649",
   "url": "https://github.com/bitcoin/bitcoin/pull/36685#issuecomment-6480062649",
   "hash": "de84187f5acc4f64",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-28T17:23:44Z",
   "action": "labeled",
   "label": "Wallet",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 2170,
 "text_tokens_estimate": 542,
 "changed_paths": [
  "src/interfaces/wallet.h",
  "src/wallet/interfaces.cpp"
 ],
 "files": [
  {
   "path": "src/interfaces/wallet.h",
   "add": 2,
   "del": 0
  },
  {
   "path": "src/wallet/interfaces.cpp",
   "add": 2,
   "del": 0
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0",
  "head_matches_backup": true,
  "base": "0f27bed5b2924420d65caeca439e6b036d3c6cb2",
  "patch_id": "ed6b98ed00116f68",
  "commits": [
   {
    "sha": "bff0a2fabf",
    "subject": "wallet: export replaces_txid and replaced_by_txid",
    "files": 2,
    "add": 4,
    "del": 0
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "ed6b98ed00116f68",
 "input_hash": "642da1ec7b23a8ec",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}