{
 "number": 36705,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36705",
 "title": "test: Replace stale TODO with mempoolminfee test in wallet_send.py",
 "author": "Conradgabe",
 "author_association": "FIRST_TIME_CONTRIBUTOR",
 "created_at": "2026-10-30T13:04:26Z",
 "updated_at": "2026-10-31T07:40:17Z",
 "description_hash": "c45a55017eee5ef0",
 "age_days": 2,
 "draft": false,
 "labels": [
  "Tests",
  "CI failed"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "a2d32135f34ab7d27817fb57be0b61d55cead575",
 "head_ref": "test-send-fee-below-mempoolminfee",
 "head_repo": "Conradgabe/bitcoin",
 "head_history": [
  {
   "t": "2026-10-31T07:40:01Z",
   "sha": "a2d32135f34ab7d27817fb57be0b61d55cead575"
  }
 ],
 "additions": 36,
 "deletions": 10,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "unstable",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {},
   "conflicts": []
  }
 },
 "acks_parsed": {},
 "acks_tally": {
  "ack": 0,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "fanquake"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": true,
  "mergeable_state": "unstable",
  "last_author_activity": "2026-10-31T07:40:01Z",
  "last_reviewer_activity": "2026-10-30T15:20:03Z",
  "last_reviewer": "fanquake",
  "author_silent_days": 1,
  "waiting_on_author_days": 0,
  "days_since_update": 1
 },
 "refs": {
  "mentioned": [
   16378
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 16378,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2020-09-15",
    "title": "The ultimate send RPC"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "`wallet_send.py` had a commented-out TODO from the original `send` PR (#16378) about returning the hex when the fee rate is below the mempool minimum. The commented code was stale; `estimate_mode=\"sat/b\"` no longer exists.\n\nAlso, an explicit `fee_rate` is only checked against `max(-mintxfee, -minrelaytxfee)`, not against `mempoolminfee` (see `src/wallet/fees.cpp`), so when the mempool is full, `send` can build a tx the node won't accept.\n\nThis PR adds a subtest covering this cases and removes the stale TODO.\n\nWith `add_to_wallet=false`, the returned hex is rejected by `testmempoolaccept`, and with `add_to_wallet=true`, `send` reports success, but the tx stays only in the wallet, not the mempool.",
 "commits": [
  {
   "sha": "a2d32135f34ab7d27817fb57be0b61d55cead575",
   "date": "2026-10-31T07:39:26Z",
   "message": "test: cover send fee_rate below mempoolminfee"
  }
 ],
 "timeline": [
  {
   "t": "2026-10-30T15:20:03Z",
   "kind": "comment",
   "who": "fanquake",
   "assoc": "MEMBER",
   "text": "cc @Sjors",
   "id": "c:6526311840",
   "url": "https://github.com/bitcoin/bitcoin/pull/36705#issuecomment-6526311840",
   "hash": "fa00cb221a218c57",
   "edited": null
  },
  {
   "t": "2026-10-31T07:40:01Z",
   "kind": "force_push",
   "who": "Conradgabe",
   "commit": "a2d32135f34ab7d27817fb57be0b61d55cead575",
   "id": "push:a2d32135f34ab7d27817fb57be0b61d55cead575"
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-30T13:04:30Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-30T17:56:55Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 827,
 "text_tokens_estimate": 206,
 "changed_paths": [
  "test/functional/wallet_send.py"
 ],
 "files": [
  {
   "path": "test/functional/wallet_send.py",
   "add": 36,
   "del": 10
  }
 ],
 "test_lines": 46,
 "git": {
  "head": "a2d32135f34ab7d27817fb57be0b61d55cead575",
  "head_matches_backup": true,
  "base": "d1fb1ba36aaeb80eb896318757c98f47c20539b8",
  "patch_id": "965bb680e47ea43f",
  "commits": [
   {
    "sha": "a2d32135f3",
    "subject": "test: cover send fee_rate below mempoolminfee",
    "files": 1,
    "add": 36,
    "del": 10
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "965bb680e47ea43f",
 "input_hash": "b43269e64c74218a",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}