{
 "number": 36706,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36706",
 "title": "policy: remove unused GetVirtualTransactionInputSize",
 "author": "fanquake",
 "author_association": "MEMBER",
 "created_at": "2026-10-30T14:01:51Z",
 "updated_at": "2026-10-30T20:02:16Z",
 "description_hash": "bc833a3db26ea1d3",
 "age_days": 2,
 "draft": false,
 "labels": [
  "TX fees and policy"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
 "head_ref": "remove_getvirtualtransactioninputsize",
 "head_repo": "fanquake/bitcoin",
 "head_history": [],
 "additions": 1,
 "deletions": 14,
 "changed_files": 4,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "l0rinc",
      "url": "https://github.com/bitcoin/bitcoin/pull/36706#pullrequestreview-5713933074"
     },
     {
      "login": "jpk68",
      "url": "https://github.com/bitcoin/bitcoin/pull/36706#issuecomment-6532346372"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "jpk68": {
   "kind": "ack",
   "hash": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "t": "2026-10-30T20:02:12Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "jpk68",
   "l0rinc"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-30T13:44:18Z",
  "last_reviewer_activity": "2026-10-30T20:02:12Z",
  "last_reviewer": "jpk68",
  "author_silent_days": 2,
  "waiting_on_author_days": 2,
  "days_since_update": 2
 },
 "refs": {
  "mentioned": [
   26567
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 26567,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2023-09-06",
    "title": "Wallet: estimate the size of signed inputs using descriptors"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [
  "src/wallet/test/wallet_tests.cpp"
 ],
 "body": "The last non-test caller was removed in 9b7ec393b8 (#26567). Since then it has only been used by the `tx_in` fuzz target and a helper in `wallet_tests`.",
 "commits": [
  {
   "sha": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "date": "2026-10-30T13:44:18Z",
   "message": "policy: remove unused GetVirtualTransactionInputSize\n\nThe last non-test caller was removed in 9b7ec393b8 (#26567), when the\nwallet switched to estimating input sizes using descriptors. Since then\nit has only been used by the tx_in fuzz target and a helper in\nwallet_tests."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-30T14:42:29Z",
   "kind": "review_comment",
   "who": "l0rinc",
   "assoc": "MEMBER",
   "path": "src/wallet/test/wallet_tests.cpp",
   "commit": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "in_reply_to": null,
   "text": "nit: seems like an inline instead of a remove",
   "id": "rc:4424827991",
   "url": "https://github.com/bitcoin/bitcoin/pull/36706#discussion_r4424827991",
   "hash": "a0d1ebc3ec0cb09c",
   "edited": "2026-10-30T14:44:16Z"
  },
  {
   "t": "2026-10-30T14:44:15Z",
   "kind": "review",
   "who": "l0rinc",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "text": "lightly tested code review ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "id": "r:5713933074",
   "url": "https://github.com/bitcoin/bitcoin/pull/36706#pullrequestreview-5713933074",
   "hash": "7493d0b8d3db4d48",
   "edited": "2026-10-30T14:44:16Z"
  },
  {
   "t": "2026-10-30T20:02:12Z",
   "kind": "comment",
   "who": "jpk68",
   "assoc": "CONTRIBUTOR",
   "text": "ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
   "id": "c:6532346372",
   "url": "https://github.com/bitcoin/bitcoin/pull/36706#issuecomment-6532346372",
   "hash": "2194345f85a295b6",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-30T14:01:57Z",
   "action": "labeled",
   "label": "TX fees and policy",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 640,
 "text_tokens_estimate": 160,
 "changed_paths": [
  "src/policy/policy.cpp",
  "src/policy/policy.h",
  "src/test/fuzz/tx_in.cpp",
  "src/wallet/test/wallet_tests.cpp"
 ],
 "files": [
  {
   "path": "src/policy/policy.cpp",
   "add": 0,
   "del": 5
  },
  {
   "path": "src/policy/policy.h",
   "add": 0,
   "del": 6
  },
  {
   "path": "src/test/fuzz/tx_in.cpp",
   "add": 0,
   "del": 2
  },
  {
   "path": "src/wallet/test/wallet_tests.cpp",
   "add": 1,
   "del": 1
  }
 ],
 "test_lines": 4,
 "git": {
  "head": "3e2cf63da5090d59218c66dcc9a54c0f8c67e648",
  "head_matches_backup": true,
  "base": "07efc592927b869b106276b5ace5fe255b5cc2d2",
  "patch_id": "dd29b82cebdd2e53",
  "commits": [
   {
    "sha": "3e2cf63da5",
    "subject": "policy: remove unused GetVirtualTransactionInputSize",
    "files": 4,
    "add": 1,
    "del": 14
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "dd29b82cebdd2e53",
 "input_hash": "0b0d0a2963d63326",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}