{
 "number": 36707,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36707",
 "title": "net_processing: remove redundant `peer` check in `MaybePunishNodeForBlock`",
 "author": "fanquake",
 "author_association": "MEMBER",
 "created_at": "2026-10-30T14:11:41Z",
 "updated_at": "2026-10-30T20:01:56Z",
 "description_hash": "5374136ceef3a812",
 "age_days": 2,
 "draft": false,
 "labels": [],
 "milestone": null,
 "base": "master",
 "head_sha": "66292fa4b575ef193ab2363391399cec29bf3503",
 "head_ref": "redundant_peer_check",
 "head_repo": "fanquake/bitcoin",
 "head_history": [],
 "additions": 1,
 "deletions": 1,
 "changed_files": 1,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "Crypt-iQ",
      "url": "https://github.com/bitcoin/bitcoin/pull/36707#issuecomment-6526774613"
     },
     {
      "login": "ViniciusCestarii",
      "url": "https://github.com/bitcoin/bitcoin/pull/36707#pullrequestreview-5716746677"
     },
     {
      "login": "l0rinc",
      "url": "https://github.com/bitcoin/bitcoin/pull/36707#pullrequestreview-5717082515"
     },
     {
      "login": "jpk68",
      "url": "https://github.com/bitcoin/bitcoin/pull/36707#issuecomment-6532340343"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "Crypt-iQ": {
   "kind": "ack",
   "hash": "66292fa4b575ef193ab2363391399cec29bf3503",
   "t": "2026-10-30T15:39:04Z",
   "stale": false
  },
  "ViniciusCestarii": {
   "kind": "ack",
   "hash": "66292fa4b575ef193ab2363391399cec29bf3503",
   "t": "2026-10-30T18:17:21Z",
   "stale": false
  },
  "l0rinc": {
   "kind": "ack",
   "hash": "66292fa4b575ef193ab2363391399cec29bf3503",
   "t": "2026-10-30T18:40:16Z",
   "stale": false
  },
  "jpk68": {
   "kind": "ack",
   "hash": "66292fa4b575ef193ab2363391399cec29bf3503",
   "t": "2026-10-30T20:01:52Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 4,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 1,
  "changes_requested": 0,
  "distinct_reviewers": [
   "Crypt-iQ",
   "ViniciusCestarii",
   "jpk68",
   "l0rinc"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-30T14:03:15Z",
  "last_reviewer_activity": "2026-10-30T20:01:52Z",
  "last_reviewer": "jpk68",
  "author_silent_days": 2,
  "waiting_on_author_days": 2,
  "days_since_update": 2
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "The `Misbehaving()` call is already inside an `if (peer && ...)` block.",
 "commits": [
  {
   "sha": "66292fa4b575ef193ab2363391399cec29bf3503",
   "date": "2026-10-30T14:03:15Z",
   "message": "net_processing: remove redundant peer check in MaybePunishNodeForBlock\n\nThe `Misbehaving()` call is already inside an `if (peer && ...)` block."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-30T15:39:04Z",
   "kind": "comment",
   "who": "Crypt-iQ",
   "assoc": "MEMBER",
   "text": "crACK 66292fa4b575ef193ab2363391399cec29bf3503",
   "id": "c:6526774613",
   "url": "https://github.com/bitcoin/bitcoin/pull/36707#issuecomment-6526774613",
   "hash": "15496a99cead3b14",
   "edited": null
  },
  {
   "t": "2026-10-30T18:17:21Z",
   "kind": "review",
   "who": "ViniciusCestarii",
   "assoc": "CONTRIBUTOR",
   "state": "COMMENTED",
   "commit": "66292fa4b575ef193ab2363391399cec29bf3503",
   "text": "ACK 66292fa4b575ef193ab2363391399cec29bf3503",
   "id": "r:5716746677",
   "url": "https://github.com/bitcoin/bitcoin/pull/36707#pullrequestreview-5716746677",
   "hash": "27ae324e83b981ec",
   "edited": null
  },
  {
   "t": "2026-10-30T18:40:16Z",
   "kind": "review",
   "who": "l0rinc",
   "assoc": "MEMBER",
   "state": "APPROVED",
   "commit": "66292fa4b575ef193ab2363391399cec29bf3503",
   "text": "ACK 66292fa4b575ef193ab2363391399cec29bf3503\n\nLooks safe since `peer` cannot be reseated between the checks.\nnit: if you touch again consider `const PeerRef peer` to make that even clearer.",
   "id": "r:5717082515",
   "url": "https://github.com/bitcoin/bitcoin/pull/36707#pullrequestreview-5717082515",
   "hash": "b29ebacd6fde1db4",
   "edited": null
  },
  {
   "t": "2026-10-30T20:01:52Z",
   "kind": "comment",
   "who": "jpk68",
   "assoc": "CONTRIBUTOR",
   "text": "ACK 66292fa4b575ef193ab2363391399cec29bf3503",
   "id": "c:6532340343",
   "url": "https://github.com/bitcoin/bitcoin/pull/36707#issuecomment-6532340343",
   "hash": "27ae324e83b981ec",
   "edited": null
  }
 ],
 "labels_log": [],
 "state_log": [],
 "text_chars": 616,
 "text_tokens_estimate": 154,
 "changed_paths": [
  "src/net_processing.cpp"
 ],
 "files": [
  {
   "path": "src/net_processing.cpp",
   "add": 1,
   "del": 1
  }
 ],
 "test_lines": 0,
 "git": {
  "head": "66292fa4b575ef193ab2363391399cec29bf3503",
  "head_matches_backup": true,
  "base": "07efc592927b869b106276b5ace5fe255b5cc2d2",
  "patch_id": "0a2877e1c24fb8ff",
  "commits": [
   {
    "sha": "66292fa4b5",
    "subject": "net_processing: remove redundant peer check in MaybePunishNodeForBlock",
    "files": 1,
    "add": 1,
    "del": 1
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "0a2877e1c24fb8ff",
 "input_hash": "75a4198d7a9b348b",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}