{
 "number": 36713,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36713",
 "title": "test: remove unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg`",
 "author": "fanquake",
 "author_association": "MEMBER",
 "created_at": "2026-10-30T17:12:25Z",
 "updated_at": "2026-10-30T20:01:30Z",
 "description_hash": "ae1e11a441eec966",
 "age_days": 2,
 "draft": false,
 "labels": [
  "Tests"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "e172eb69df92b5ef9cd5f4234de28430c1f7b7b8",
 "head_ref": "remove_dynsock_netmsg",
 "head_repo": "fanquake/bitcoin",
 "head_history": [
  {
   "t": "2026-10-30T17:12:47Z",
   "sha": "e172eb69df92b5ef9cd5f4234de28430c1f7b7b8"
  }
 ],
 "additions": 3,
 "deletions": 97,
 "changed_files": 2,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "jpk68",
      "url": "https://github.com/bitcoin/bitcoin/pull/36713#issuecomment-6532332641"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "jpk68": {
   "kind": "ack",
   "hash": "e172eb69df92b5ef9cd5f4234de28430c1f7b7b8",
   "t": "2026-10-30T20:01:26Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 0,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "jpk68"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-30T17:12:47Z",
  "last_reviewer_activity": "2026-10-30T20:01:26Z",
  "last_reviewer": "jpk68",
  "author_silent_days": 2,
  "waiting_on_author_days": 2,
  "days_since_update": 2
 },
 "refs": {
  "mentioned": [
   26812,
   30205
  ],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [
   {
    "number": 30205,
    "type": "pull",
    "state": "closed",
    "merged": true,
    "merged_at": "2025-02-10",
    "title": "test: add mocked Sock that can read/write custom data and/or CNetMessages"
   },
   {
    "number": 26812,
    "type": "pull",
    "state": "closed",
    "merged": false,
    "merged_at": null,
    "title": "test: add end-to-end tests for CConnman and PeerManager"
   }
  ],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "With these removed, `WaitForDataOrEof` and the condition variable are also removed.\n\nThis was merged as part of #30205, in advance of #26812, which never landed.",
 "commits": [
  {
   "sha": "e172eb69df92b5ef9cd5f4234de28430c1f7b7b8",
   "date": "2026-10-30T17:12:40Z",
   "message": "test: remove unused DynSock::Pipe::GetNetMsg and PushNetMsg\n\nWith these removed, WaitForDataOrEof and\nthe condition variable are also removed."
  }
 ],
 "timeline": [
  {
   "t": "2026-10-30T17:12:47Z",
   "kind": "force_push",
   "who": "fanquake",
   "commit": "e172eb69df92b5ef9cd5f4234de28430c1f7b7b8",
   "id": "push:e172eb69df92b5ef9cd5f4234de28430c1f7b7b8"
  },
  {
   "t": "2026-10-30T20:01:26Z",
   "kind": "comment",
   "who": "jpk68",
   "assoc": "CONTRIBUTOR",
   "text": "ACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8",
   "id": "c:6532332641",
   "url": "https://github.com/bitcoin/bitcoin/pull/36713#issuecomment-6532332641",
   "hash": "a876b2e229eecb36",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-30T17:12:30Z",
   "action": "labeled",
   "label": "Tests",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-30T17:15:01Z",
   "action": "labeled",
   "label": "CI failed",
   "who": "DrahtBot"
  },
  {
   "t": "2026-10-30T18:42:46Z",
   "action": "unlabeled",
   "label": "CI failed",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 413,
 "text_tokens_estimate": 103,
 "changed_paths": [
  "src/test/util/net.cpp",
  "src/test/util/net.h"
 ],
 "files": [
  {
   "path": "src/test/util/net.cpp",
   "add": 1,
   "del": 51
  },
  {
   "path": "src/test/util/net.h",
   "add": 2,
   "del": 46
  }
 ],
 "test_lines": 100,
 "git": {
  "head": "e172eb69df92b5ef9cd5f4234de28430c1f7b7b8",
  "head_matches_backup": true,
  "base": "b048a3e8386a543dfae30dcc4552b37b06671caf",
  "patch_id": "5323dbf4476577c1",
  "commits": [
   {
    "sha": "e172eb69df",
    "subject": "test: remove unused DynSock::Pipe::GetNetMsg and PushNetMsg",
    "files": 2,
    "add": 3,
    "del": 97
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "5323dbf4476577c1",
 "input_hash": "41db991687182ef2",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}