{
 "number": 36715,
 "repo": "bitcoin/bitcoin",
 "url": "https://github.com/bitcoin/bitcoin/pull/36715",
 "title": "refactor: Enable bugprone-signed-char-misuse",
 "author": "maflcko",
 "author_association": "MEMBER",
 "created_at": "2026-10-30T19:32:48Z",
 "updated_at": "2026-10-31T13:13:19Z",
 "description_hash": "b9dedb9d48eba4b3",
 "age_days": 2,
 "draft": false,
 "labels": [
  "Refactoring"
 ],
 "milestone": null,
 "base": "master",
 "head_sha": "fa6efa5da55c4b1acda336fb875e94b020c023a6",
 "head_ref": "2610-bugprone-signed-char-misuse",
 "head_repo": "maflcko/bitcoin-core",
 "head_history": [],
 "additions": 4,
 "deletions": 3,
 "changed_files": 4,
 "commit_count": 1,
 "size_bucket": "S",
 "mergeable_state": "clean",
 "bot": {
  "drahtbot": {
   "present": true,
   "reviews": {
    "ack": [
     {
      "login": "jpk68",
      "url": "https://github.com/bitcoin/bitcoin/pull/36715#issuecomment-6532312947"
     }
    ],
    "concept_ack": [
     {
      "login": "hebasto",
      "url": "https://github.com/bitcoin/bitcoin/pull/36715#pullrequestreview-5722845443"
     }
    ]
   },
   "conflicts": []
  }
 },
 "acks_parsed": {
  "jpk68": {
   "kind": "ack",
   "hash": "fa6efa5da55c4b1acda336fb875e94b020c023a6",
   "t": "2026-10-30T20:00:19Z",
   "stale": false
  },
  "hebasto": {
   "kind": "concept_ack",
   "hash": null,
   "t": "2026-10-31T13:13:15Z",
   "stale": false
  }
 },
 "acks_tally": {
  "ack": 1,
  "stale_ack": 0,
  "concept_ack": 1,
  "approach_ack": 0,
  "nack": 0,
  "concept_nack": 0,
  "approach_nack": 0
 },
 "reviews": {
  "approved": 0,
  "changes_requested": 0,
  "distinct_reviewers": [
   "hebasto",
   "jpk68"
  ]
 },
 "signals": {
  "needs_rebase": false,
  "ci_failed": false,
  "mergeable_state": "clean",
  "last_author_activity": "2026-10-30T19:25:13Z",
  "last_reviewer_activity": "2026-10-31T13:13:15Z",
  "last_reviewer": "hebasto",
  "author_silent_days": 2,
  "waiting_on_author_days": 1,
  "days_since_update": 1
 },
 "refs": {
  "mentioned": [],
  "depends_on": [],
  "fixes": [],
  "linked_issues": [],
  "references": [],
  "conflicts": []
 },
 "stack": {
  "shares_commits_with": [],
  "based_on": [],
  "base_for": []
 },
 "review_paths": [],
 "body": "This can help to prevent out-of-bounds reads such as the one removed in 43a33e513c4044dc01d92e77da76f2e98faaedb5, or prevent other bugs.\n\nThere is some code that correctly uses signed chars, but this can be trivially made \"tidy\" by using C++11 narrowing init to `int` (or whatever type you want).",
 "commits": [
  {
   "sha": "fa6efa5da55c4b1acda336fb875e94b020c023a6",
   "date": "2026-10-30T19:25:13Z",
   "message": "refactor: Enable bugprone-signed-char-misuse"
  }
 ],
 "timeline": [
  {
   "t": "2026-10-30T20:00:19Z",
   "kind": "comment",
   "who": "jpk68",
   "assoc": "CONTRIBUTOR",
   "text": "ACK fa6efa5da55c4b1acda336fb875e94b020c023a6",
   "id": "c:6532312947",
   "url": "https://github.com/bitcoin/bitcoin/pull/36715#issuecomment-6532312947",
   "hash": "26e3fb784f5caeb3",
   "edited": null
  },
  {
   "t": "2026-10-31T13:13:15Z",
   "kind": "review",
   "who": "hebasto",
   "assoc": "MEMBER",
   "state": "COMMENTED",
   "commit": "fa6efa5da55c4b1acda336fb875e94b020c023a6",
   "text": "Concept ACK.",
   "id": "r:5722845443",
   "url": "https://github.com/bitcoin/bitcoin/pull/36715#pullrequestreview-5722845443",
   "hash": "39bcd188b11b7a83",
   "edited": null
  }
 ],
 "labels_log": [
  {
   "t": "2026-10-30T19:32:53Z",
   "action": "labeled",
   "label": "Refactoring",
   "who": "DrahtBot"
  }
 ],
 "state_log": [],
 "text_chars": 443,
 "text_tokens_estimate": 110,
 "changed_paths": [
  "src/.clang-tidy",
  "src/base58.cpp",
  "src/test/net_tests.cpp",
  "src/util/strencodings.h"
 ],
 "files": [
  {
   "path": "src/.clang-tidy",
   "add": 1,
   "del": 0
  },
  {
   "path": "src/base58.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/test/net_tests.cpp",
   "add": 1,
   "del": 1
  },
  {
   "path": "src/util/strencodings.h",
   "add": 1,
   "del": 1
  }
 ],
 "test_lines": 2,
 "git": {
  "head": "fa6efa5da55c4b1acda336fb875e94b020c023a6",
  "head_matches_backup": true,
  "base": "b048a3e8386a543dfae30dcc4552b37b06671caf",
  "patch_id": "1a63aad3a24693b7",
  "commits": [
   {
    "sha": "fa6efa5da5",
    "subject": "refactor: Enable bugprone-signed-char-misuse",
    "files": 4,
    "add": 4,
    "del": 3
   }
  ],
  "patch_truncated": false
 },
 "patch_id": "1a63aad3a24693b7",
 "input_hash": "079cc053098b38ff",
 "extracted_at": "2026-11-02T01:09:49+00:00"
}