#35224 wallet: importdescriptors should output the request on error
https://github.com/bitcoin/bitcoin/pull/35224 · · +11/-2 in 2 files, 2 commits · labels: Wallet · draft
Goal
- Show which descriptor failed when importdescriptors reports a missing timestamp
- Makes troubleshooting bulk descriptor imports faster for wallet users
Updates the `importdescriptors` RPC error message when a timestamp is missing to echo the UniValue JSON representation of the rejected descriptor import request. It also adds a functional test case verifying the expanded error message.
Problem: When importing an array of multiple descriptors, an error about a missing timestamp does not identify which entry in the list caused the failure, making troubleshooting tedious.
Category: Wallet (#74 of 84)
P4 · cleanup
- P4 because it provides a minor diagnostic improvement for RPC errors
- It does not impact wallet correctness or safety
Improves diagnostic output on RPC input failure without addressing wallet correctness or safety. The PR description notes that 'it would be useful to know the exact request that failed' when multiple descriptors are passed, which is a minor usability improvement.
Membership: Touches src/wallet/rpc/backup.cpp and wallet functional tests.
Factors: security/stability 0, bug 0, performance 0, user value 1, leverage 0
Reviewability: Stale: Author silent
- Review #34861 first
- Marked as draft and author has been inactive
The author has been inactive for 134 days and marked the PR as draft pending #34861.
Author status: silent since opening on 2026-05-06
Agreement: Crickets
- No review activity or comments since submission
- Awaiting initial feedback
No reviews or comments.
No contributors have reviewed or commented on the PR since it was submitted.
Review verdicts (DrahtBot): 0
Dependencies
Depends on: #34861
Files
11 lines under test/bench/ci.
- test/functional/wallet_importdescriptors.py +10/-1
- src/wallet/rpc/backup.cpp +1/-1
Card
This PR improves the error message returned by importdescriptors when an entry lacks a timestamp by including the failed item's JSON payload. It solves a minor inconvenience where users submitting batch imports cannot easily tell which descriptor failed. The PR has seen no review activity and the author indicated it waits on #34861.