#36024 ci: Make `test_bitcoin-qt.exe` output visible

full analysis

https://github.com/bitcoin/bitcoin/pull/36024 · hebasto · +2/-0 in 2 files, 1 commits · labels: Windows, Tests

Goal

  • Make Qt unit test output and failure messages visible in Windows CI runs
  • Helps developers diagnose GUI test failures that are currently suppressed by the runner

Sets `QT_ASSUME_STDERR_HAS_CONSOLE=1` in both the Windows native and cross-compilation CI scripts. This forces Qt to write `test_bitcoin-qt.exe` logs and test results to stderr even when running in GitHub Actions without an attached console.

Problem: When running `test_bitcoin-qt.exe` in GitHub Actions on Windows, Qt's console detection returns false and discards stdout/stderr test reporting, making test failures difficult or impossible to diagnose.

Category: Build and CI (#19 of 55)

P3 · CI fix

  • P3 because it restores missing failure logs in Windows CI environments
  • Improves build diagnostics when Windows automated test jobs fail silently

Fixes a clear CI diagnostic issue where Qt test reports are lost in headless Windows CI environments. hebasto notes that 'there is no console attached, so Qt's stderrHasConsoleAttached() returns false and the entire test report is lost.' Restoring test diagnostics improves developer feedback during test failures.

Membership: Directly modifies GitHub Actions CI runner scripts `.github/ci-windows.py` and `.github/ci-windows-cross.py`.

Factors: security/stability 0, bug 1, performance 0, user value 0, leverage 1

Category: Test infrastructure (#31 of 45)

P3 · test coverage

  • P3 because it makes unit test execution and error reporting observable in CI
  • Impact is limited to test observability on Windows runners without adding new coverage

Improves test infrastructure signal by ensuring Qt test suite execution details and failure diagnostics are printed to test logs rather than being dropped.

Membership: Carries the Tests label and fixes reporting for the Qt unit test harness.

Factors: security/stability 0, bug 1, performance 0, user value 0, leverage 1

Reviewability: Ready

  • Ready for review
  • Small patch with passing CI

The PR is a trivial two-line environment variable addition with passing CI and no conflicts.

Author status: Silent since opening the PR.

Agreement: Crickets

  • No reviews or feedback yet

Crickets; no reviews or comments yet.

The PR has not received any comments or review feedback since being opened.

Objections: none enumerated.

State derived from the lists: no substantive comment either way

Review verdicts (DrahtBot): 0

Files

0 lines under test/bench/ci.

  • .github/ci-windows-cross.py +1/-0
  • .github/ci-windows.py +1/-0

Card

Sets QT_ASSUME_STDERR_HAS_CONSOLE=1 in Windows CI runner scripts to prevent Qt from suppressing test output in headless GitHub Actions runners. Without this change, test reports and failure messages from test_bitcoin-qt.exe are completely dropped when tests fail. The change is two lines, CI is green, and the PR is currently awaiting its first review.

Data

dossier JSON · extract JSON · model openrouter/google/gemini-3.8-flash, generated 2026-09-17T21:46, confidence high, input hash b53b8717a686c8f4