#36267 [32.x] Backports for rc2
https://github.com/bitcoin/bitcoin/pull/36267 · · +54/-35 in 4 files, 3 commits · labels: Backport
Goal
- Backport fixes to the 32.x branch for the 32.0rc2 release candidate
- Allow offline Windows signature validation in Guix and back off on dropped Tor control connections
This pull request backports two merged PRs to the 32.x branch for the 32.0rc2 release candidate: #36256 (updating osslsigncode to 2.14 in Guix to allow offline signature validation) and #36260 (adding exponential backoff on dropped Tor control connections). It also includes the associated man page and release documentation updates for the release branch.
Problem: Without osslsigncode 2.14, Guix Windows codesigning cannot validate signed binaries in network-isolated containers due to CRL check requirements. Additionally, dropped Tor control port connections could retry immediately without appropriate backoff.
Category: Build and CI (#1 of 55)
P2 · platform fix
- P2 because it fixes Guix codesigning verification for Windows release binaries
- Enables signature checks inside isolated Guix containers that lack network access
Fixes Guix codesigning verification for Windows release binaries. As noted in the commit message, osslsigncode prior to 2.14 requires CRL validation via network access, which fails inside isolated Guix containers.
Membership: Touches contrib/guix/libexec/codesign.sh and contrib/guix/manifest_codesign.scm to update osslsigncode and certificate dependencies.
Factors: security/stability 2, bug 2, performance 0, user value 0, leverage 2
Category: P2P (#30 of 65)
P3 · bug fix
- P3 because it ensures Tor control reconnections back off gracefully after dropped connections
- Prevents tight reconnect loops when Tor is restarting or unreachable
Ensures that Tor control reconnections back off gracefully when disconnected, preventing tight reconnect loops when Tor is restarting or unreachable.
Membership: Modifies src/torcontrol.cpp to apply exponential reconnect backoff after dropped connections.
Factors: security/stability 1, bug 1, performance 0, user value 1, leverage 0
Reviewability: Ready
- Ready to review now
- Straightforward backport of two commits already merged to master with passing CI
Clean merge state, passing CI, and straightforward backport of two commits already merged to master.
Author status: active
Agreement: Crickets
- No reviews or comments yet on this newly opened backport PR
No comments or reviews yet on this newly opened backport PR
The PR was recently opened by maintainer fanquake and has received no reviews or comments yet.
Review verdicts (DrahtBot): 0
Dependencies
Enables:
- 32.0rc2 release candidate build
Files
40 lines under test/bench/ci.
- doc/man/bitcoin-qt.1 +883/-3
- doc/man/bitcoind.1 +861/-3
- share/examples/bitcoin.conf +736/-1
- doc/man/bitcoin-cli.1 +214/-3
- doc/man/bitcoin-tx.1 +157/-3
- doc/man/bitcoin-wallet.1 +118/-3
- doc/release-notes-empty-template.md +0/-108
- doc/man/bitcoin-util.1 +80/-3
- doc/man/bitcoin.1 +57/-3
- src/torcontrol.cpp +16/-33
- contrib/guix/manifest_codesign.scm +16/-1
- test/functional/feature_torcontrol.py +16/-0
- contrib/guix/libexec/codesign.sh +6/-1
- CMakeLists.txt +3/-3
- src/clientversion.cpp +1/-1
- doc/release-notes.md +1/-0
Card
Backports two merged PRs to the 32.x maintenance branch for release candidate 32.0rc2. It updates osslsigncode to 2.14 in Guix to allow offline validation of Windows codesigned binaries without network CRL access (#36256) and applies reconnect exponential backoff to Tor control connections (#36260). Both changes address release reliability and network daemon stability for the upcoming major release. The PR is freshly opened by fanquake and is awaiting backport ACKs.