#36278 Update minisketch subtree to latest master
https://github.com/bitcoin/bitcoin/pull/36278 · · +4/-1 in 1 files, 2 commits · labels: none
Goal
- Prevent unused-variable warnings from minisketch when compiling with -Wunused-const-variable
- Unblocks enabling the -Wunused-const-variable compiler warning across the codebase
Updates the `src/minisketch` vendored subtree to the latest master commit. This incorporates an upstream change that adds `inline` to `constexpr IdTrans ID_TRANS` when compiling in C++17 or later.
Problem: Without `inline`, the `constexpr` singleton in the header triggers unused-variable warnings when compiling under `-Wunused-const-variable`, preventing the enablement of that warning flag across the codebase in #36275.
Category: Utilities (logging, arguments, libraries) (#56 of 66)
P4 · unblocks #36275
- P4 because this is a minor upstream subtree sync with no functional or security impact
- Provides minor leverage by unblocking warning enablement in #36275
P4 because this is a minor subtree sync of an upstream refactor to mark a variable `inline` in C++17, with no functional or security impact. It provides minor leverage by unblocking #36275 (`build: enable -Wunused-const-variable`).
Membership: Touches the vendored minisketch subtree under `src/minisketch/`, which is maintained as shared utility infrastructure.
Factors: security/stability 0, bug 0, performance 0, user value 0, leverage 1
Reviewability: Ready
- Ready to review
- Clean subtree bump with no conflicts or failing tests
Clean 3-line subtree bump with no conflicts or failing tests.
Author status: active
Agreement: Crickets
- No reviews or comments yet
- Recently opened with no discussion so far
No reviews or comments yet.
The PR was recently opened and has received no feedback yet.
Review verdicts (DrahtBot): 0
Dependencies
Enables:
Files
0 lines under test/bench/ci.
- src/minisketch/src/lintrans.h +4/-1
Card
Updates the minisketch vendored subtree to incorporate an upstream change adding `inline` to `ID_TRANS` for C++17. This fixes potential `-Wunused-const-variable` compiler warnings in consumers of the header. It unblocks PR #36275 which turns on that compiler warning flag. The PR was just opened and has had no review activity yet.