#36710 test: Replace hardcoded extended keys with ExtendedKey helpers

ReviewabilityReviewsAgreementSize
#36710 nebula-21 test: Replace hardcoded extended keys with ExtendedKey helpersNeeds rebase0Crickets0 + 42 tests
  • Standardize key generation across functional tests to remove inconsistent hardcoded key strings
  • Worth reviewing now because the required rebase is mechanical
  • No review verdicts recorded
  • No review comments or feedback yet
  • No participants have weighed in on the proposed changes
  • 0 lines added or modified outside tests
  • 42 lines added or modified in tests
  • 39 lines removed in total
  • 10 files, 1 commits
Test infrastructure#49 of 54
P4 · cleanup
  • P4 because standardizing key creation improves test cleanliness without altering coverage
  • No impact on test reliability or overall test framework capabilities
Ranking notes
Reviewability: ReadyStalePaused
Agreement: StrongPositivePositive w/ caveatsNeutralMildDisputedBlockedCrickets
Reviews: current code-review ACKs, then (+stale ACKs) and -NACKs; greener = more ACKs.
Size: lines added or modified outside tests, then in tests; greener = smaller.

Goal

Replaces hardcoded extended key string literals (tpub/tprv) across 10 functional test files with dynamically generated keys using the ExtendedPrivateKey test framework helper. This standardizes test key creation following the introduction of extended key test classes.

Problem: Multiple functional tests still rely on hardcoded extended key strings instead of using the standardized ExtendedKey helper classes introduced in PR #35543, keeping test setup patterns inconsistent.

Evidence of importance:

  • PR description: 'This PR is a follow-up of PR #35543. I've updated the tests that were still using hardcoded keys, and used the ExtendedKey classes instead.'

Risk of a mistake: low (tests). Touches only functional test files; any mistake would cause test failures in CI without affecting release binaries.

Changed since the previous assessment: Diff provided; confirms direct replacements of static key strings with ExtendedPrivateKey.generate() across 10 test files.

Reviewability

Ready · Needs rebase

Conflicts with master; review the logic now, the rebase is mechanical.

Agreement

Crickets

no substantive comment either way

Objections, suggestions, and questions: none recorded.

Files

81 lines under test/bench/ci.

  • test/functional/rpc_getdescriptorinfo.py +10/-8
  • test/functional/wallet_miniscript.py +3/-14
  • test/functional/wallet_exported_watchonly.py +7/-4
  • test/functional/rpc_psbt.py +5/-4
  • test/functional/rpc_generate.py +4/-2
  • test/functional/wallet_basic.py +4/-2
  • test/functional/wallet_listsinceblock.py +4/-2
  • test/functional/wallet_backwards_compatibility.py +3/-1
  • test/functional/wallet_fundrawtransaction.py +1/-1
  • test/functional/wallet_importdescriptors.py +1/-1

Card

The short text the ranking pass compares across PRs.

This PR replaces hardcoded extended key strings (tpub/tprv) with dynamically generated keys using the ExtendedPrivateKey helper class across 10 functional test files. It continues test framework modernization following PR #35543. This is an internal test cleanup with no impact on node behavior or consensus.

Data

dossier JSON · extract JSON · model ledger, generated 2026-11-01T01:16, confidence high, input hash c3be0f4823fdecef
labels: Tests, Needs rebase

Categories

Test infrastructure

P4 · cleanup

Adopts ExtendedKey helper classes across 10 functional test files to standardize test key creation. Cleanliness of test code ranks low in test infrastructure with no impact on test reliability or coverage.

Membership: Has the Tests label and refactors test setup across multiple functional tests to adopt framework ExtendedKey helpers.

Factors: security/stability 0, bug 0, performance 0, user value 0, leverage 0