Tools and scripts: ranking notes

Category notes

Band spread is deliberate: one P1 (security defect in release verification), four P2s (two concrete supported-platform/distro failures of the `bitcoin` wrapper, one privacy rewrite, one perf+unblocking change), with the rest genuine but deferrable developer and contrib tooling. Several cards' stated reasons under-described their PRs (notably #36106, #36603, #35831), which is where the bands moved.

Review order and overlapping PRs

  • Chain: #36105 (Windows exec/_cwait fix) must be reviewed before #36190, which only adds functional tests for the behaviour #36105 introduces; reviewing the tests first is wasted effort.
  • Chain: #19460 depends on #10102 and #29409 and is itself a prerequisite for #19461; its value is entirely as scaffolding, so it should be reviewed in that sequence rather than on its own merits.
  • #35814 supersedes the earlier stalled completion-generation attempts (#18606, #25243, #30860) and builds on merged OpenRPC work (#34683) — it is the one to review for issue #17289; the older PRs should be closed rather than re-reviewed.
  • #36603 and #36608 both land new binaries/subcommands in the tools surface while the bulk of their diffs sit in node and P2P code; reviewers from this category should focus on the bitcoin-util txoutsetsummary and bitcoin-privbcast interfaces and defer the rest.
  • #35994 is a draft whose author has stated a preference for abandoning it in favour of manual rewrites; it is kept at P4 rather than Unranked because intent is clear, but it has no claim on review time.

Band and position changes

  • #36293: P2 alone, P1 after comparison. Raised to P1: release-binary verification tooling counting revoked/expired keys toward the quorum is a disclosed security defect in a tool downstream users rely on, the most consequential problem in this category.
  • #36106: P3 alone, P2 after comparison. Raised to P2 and moved up: the wrapper is simply unusable on distros with non-default libexec layout (issue #35785), the same class of supported-platform breakage as #36105, so the two must share a band.
  • #36608: P3 alone, P2 after comparison. Raised to P2: the problem is recurring privacy/deanonymization leaks in private broadcast, a security-class issue, not merely a new CLI utility.
  • #36603: P3 alone, P2 after comparison. Raised to P2 and moved up: substantial snapshot-load performance gain plus an offline bitcoin-util inspection tool, and #35054 (P2P UTXO set sharing) builds on it.
  • #35831: P4 alone, P3 after comparison. Raised from P4: silently swallowing options after a command (e.g. trailing -rpcwallet) is a real user-facing CLI correctness problem, not incidental cleanup.
  • #35788: Moved down: a useful developer/researcher convenience tool with no existing breakage behind it, so it ranks below the tool bugs and the dev-time-saving automation in the same band.
  • #35167: Moved down: maintainability of a developer dependency check with unresolved design-doc objections and a stale branch ranks below concrete tool bugs and user-facing tooling in the same band.

About

This pass by claude-opus-5 on 2026-11-01 saw every PR in the category at once and checked the bands given to each PR alone against each other, ordered the PRs, and noted chains and overlaps. Back to the category.