P2P: not a member. This PR enables a clang-tidy linter check across the codebase with minor mechanical adjustments; it does not target P2P protocol, connection management, or transport logic.
Utilities (logging, arguments, libraries): not a member. Touches src/util/strencodings.h only to satisfy a newly enabled clang-tidy linter check in src/.clang-tidy.
Kernel (libbitcoinkernel): not a member. Touches src/kernel/chainparams.cpp and src/kernel/signet.h only for a single-line mechanical rename of GetSignetMessageStart.
Tools and scripts: not a member. PR has the 'Scripts and tools' label and targets bitcoin-cli argument parsing, but the category explicitly excludes the RPC client.
Validation: not a member. Touches src/chainparamsbase.cpp and src/chainparams.cpp without altering block or transaction validity rules.
Test infrastructure: not a member. Changes unit tests for the coins cache (src/test/coins_tests.cpp and src/test/coinsviewoverlay_tests.cpp) rather than shared test machinery or utilities.
RPC / REST / ZMQ: not a member. Matched keyword 'json' from test fixture filename `src/test/data/script_tests.json`, but changes no RPC, REST, or ZMQ interfaces.
Tools and scripts: not a member. Matched keyword 'script' referring to Bitcoin Script consensus evaluation rather than command-line tools or contributor scripts.
Tools and scripts: not a member. Matches keyword 'script' in the context of Bitcoin CScript, but touches core serialization in `src/compressor.h` rather than command-line tools or contrib scripts.
Test infrastructure: not a member. Touches only unit tests in src/test/ (script_segwit_tests.cpp, script_tests.cpp, sigopcount_tests.cpp, script_standard_tests.cpp) targeting script behavior; the tests category covers testing machinery and explicitly excludes tests that pin the behavior of a specific area.
Ready for review
No review verdicts recorded
Answered objection: truncated GetOp test does not kill the mutants it claims to (brunoerg)
Answered objection: LLM-generated text violates project AI policy (sedited)
Open suggestion: add a test covering an analogous witness script hash size mutant (fametrano)
0 lines added or modified outside tests
159 lines added or modified in tests
0 lines removed in total
4 files, 4 commits
(+)#36224nebula-21test: Add test coverage for `PartiallySignedTransaction::Merge()`
1 rejected
Ready
0
Crickets
0 + 96 tests
Add unit test coverage for PSBT merging logic to catch regressions in core transaction handling
Tests version mismatch rejection, fallback locktime propagation, and modifiable flag operations
Test infrastructure: not a member. Labeled Tests, but only adds unit tests for PSBT merging in src/test/psbt_tests.cpp rather than modifying test machinery, utilities, or runners.
Ready to review
No review verdicts recorded
Little discussion so far with no explicit stance either way
Implemented suggestion to verify matching unique IDs (polespinasa)
Unanswered suggestion to test positive AND case for modifiable flags (polespinasa)
0 lines added or modified outside tests
96 lines added or modified in tests
0 lines removed in total
1 files, 3 commits
(+)#36180jeanpablojpqt: don't abort or drop settings when dynamic settings are disabled
1 rejected
Ready
0
Crickets
55 + 53 tests
Prevent crashes on startup when running the GUI with dynamic settings disabled
Avoid losing settings and warn users when changes cannot be saved to disk
IPC / multiprocess: not a member. Touches src/interfaces/node.h and src/node/interfaces.cpp, but only to support a GUI settings error-handling fix rather than changing IPC infrastructure.
Ready to review
No review verdicts recorded
No substantive feedback either way yet
Asked whether the issue and fix are relevant to the QML GUI (sedited)
55 lines added or modified outside tests
53 lines added or modified in tests
27 lines removed in total
7 files, 2 commits
(+)#36013pablomartin4btctest: Descriptor roundtrip and raw()/ addr() coverage
1 rejected
Waiting on author
1
Strong
0 + 112 tests
Ensure inferring descriptors from generated scripts preserves the original descriptor structure
Add unit test coverage for valid keyless raw() and addr() descriptors
Test infrastructure: not a member. Touches only src/test/descriptor_tests.cpp, adding unit test coverage for descriptor inference and raw()/addr() descriptors.
Kernel (libbitcoinkernel): not a member. Touches src/kernel/chainparams.cpp only for duration literal refactoring without altering the kernel C/C++ API or library boundary.
Mempool and policy: not a member. Touches src/txmempool.h and src/txmempool.cpp only to use typed duration arithmetic for decay calculation.
P2P: not a member. Touches net_processing.cpp, net.cpp, banman.h, and headerssync.cpp only to use std::chrono durations.
RPC / REST / ZMQ: not a member. Touches src/rpc/node.cpp and src/rpc/blockchain.cpp to convert internal time arithmetic to std::chrono.
Validation: not a member. Touches src/validation.cpp, src/chain.h, and src/node/chainstate.cpp without changing consensus or validation rules.
Wallet: not a member. Touches src/wallet/spend.cpp and src/wallet/wallet.cpp for minor duration arithmetic adjustments.
Test infrastructure: not a member. Carries the 'Tests' label and touches test/functional/feature_torcontrol.py, but the category explicitly excludes tests that pin the behavior of a specific functional area rather than test machinery or framework.
Ready for review
No review verdicts recorded
No substantive review comments or approvals yet
Asked what the bad-password test validates separately from the successful case (davidgumberg)
Discussed coordinating overlapping test cases with #36374 and agreed to keep them separate (0xShadowX)
0 lines added or modified outside tests
100 lines added or modified in tests
0 lines removed in total
1 files, 1 commits
(+)#33973billymcbiptest: Improve STRICTENC/DERSIG unit tests in script_tests.json
1 rejected
Author silent 324d
0
Strong
+48/-9
Clarify consensus versus standardness checks in script signature encoding tests
Improve test descriptions and add coverage for negative CHECKMULTISIG NOT cases
Test infrastructure: not a member. Labeled Tests, but only modifies test vector data in script_tests.json rather than testing machinery, frameworks, or unit test utilities.
Author has been silent for 286 days so a review may wait a long time for a response
Test infrastructure: not a member. Changes only feature_cltv.py and feature_csv_activation.py to test specific consensus/validation behaviors (BIP65 and BIP113), touching no shared test framework machinery.
Author has been silent for 94 days, so a review may wait a long time for a response
Every assessed PR that the model placed in none of the categories listed in not_in above. The list is computed by the site, not judged by a model, and exists to catch PRs falling through the cracks: a PR here means either a category definition has a gap in its "Covers" text, the pre-filter hints (labels, paths, keywords) never put the PR in front of the right category, or the PR fits nowhere and that is fine.
Only the categories named above count. A temporary or one-off category can exist alongside them without shrinking this list, so when a new permanent category is added, add its name to not_in here.
What matters here
Nothing is ranked. Rows are newest first. The Judged column says which categories the model was asked about and the reason each gave, which is the starting point for fixing a definition.