#36206 build: drop use of `OBJC_OLD_DISPATCH_PROTOTYPES`
https://github.com/bitcoin/bitcoin/pull/36206 · · +0/-1 in 1 files, 1 commits · labels: macOS, Build system, DrahtBot Guix build requested
Goal
- Remove obsolete compiler flags from the macOS build configuration
- Reduces maintenance clutter following the minimum SDK bump to macOS 14
Removes the `OBJC_OLD_DISPATCH_PROTOTYPES=0` compiler flag from the Darwin build configuration in `CMakeLists.txt`. This definition is no longer necessary now that the macOS minimum target and SDK have been raised to 14.0 and direct `objc_msgSend` calls are no longer used.
Problem: Legacy build flags that are no longer needed add minor clutter to the CMake build definition.
Category: Build and CI (#50 of 55)
P4 · cleanup
- P4 because it is a minor cleanup of an obsolete compile definition with no functional impact
- Does not fix a broken build or unblock other development
P4 as it is a one-line removal of an obsolete compile definition with no user or functional impact. It does not fix a build failure or unblock ongoing work.
Membership: Modifies CMakeLists.txt build definitions for Darwin targets.
Factors: security/stability 0, bug 0, performance 0, user value 0, leverage 0
Reviewability: Ready
- Worth reviewing now as a straightforward single-line deletion with passing CI
The change is a single-line deletion with passing CI and Guix builds supplied.
Author status: active
Agreement: Positive
- Positive sentiment with no objections
- Concept approval confirming the flag is obsolete in modern macOS toolchains (hebasto)
Positive; hebasto gave Concept ACK with supporting upstream context.
The only reviewer provided a Concept ACK confirming the flag's obsolescence in newer macOS toolchains.
- hebasto: Concept ACK with reference to Qt 6 codebase notes on Xcode versions.
Review verdicts (DrahtBot): 0
- Concept ACK: hebasto
Files
0 lines under test/bench/ci.
- CMakeLists.txt +0/-1
Card
This PR removes the obsolete OBJC_OLD_DISPATCH_PROTOTYPES compile definition from CMakeLists.txt for Darwin targets. The definition was originally introduced in #16720 but is unneeded now that the project targets macOS 14+ SDKs and avoids direct objc_msgSend calls. It is an uncontroversial, single-line build cleanup with positive review feedback.