#36713 test: remove unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg`

ReviewabilityReviewsAgreementSize
#36713 fanquake test: remove unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg`Ready1Positive0 + 3 tests
  • Remove unused socket helpers and synchronization code left in the test suite from an unmerged PR
  • Cleans up test framework utilities with no change to test behavior
  • Ready for review
  • Nothing known that would invalidate a review
  • Support without stated reasons (jpk68)
  • No objections raised
  • 0 lines added or modified outside tests
  • 3 lines added or modified in tests
  • 97 lines removed in total
  • 2 files, 1 commits
Test infrastructure#51 of 54
P4 · cleanup
  • P4 because it is minor dead code cleanup in the test framework
  • Touches only test socket utilities and does not affect production code or test coverage
Ranking notes
Reviewability: ReadyStalePaused
Agreement: StrongPositivePositive w/ caveatsNeutralMildDisputedBlockedCrickets
Reviews: current code-review ACKs, then (+stale ACKs) and -NACKs; greener = more ACKs.
Size: lines added or modified outside tests, then in tests; greener = smaller.

Goal

Removes the unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg` helper methods from the test framework. Also removes the now-unneeded `WaitForDataOrEof` method and the pipe's internal condition variable, changing `DynSock::Pipe::GetBytes` to acquire a normal mutex lock.

Problem: Dead helper code and associated condition-variable synchronization remain in the test socket utilities after being merged in PR #30205 for PR #26812, which was never merged.

Evidence of importance:

  • PR description: 'This was merged as part of #30205, in advance of #26812, which never landed.'

Risk of a mistake: low (tests). Only touches test socket utility code, so any issue would at most cause unit test failures rather than affect production nodes.

Changed since the previous assessment: Diff provided; confirms removal of unused test helper methods and associated condition variable synchronization.

Reviewability

Ready

Nothing known that would invalidate a review now.

Waiting on (from the thread read):

  • nothing

Agreement

Positive

support without stated reasons, no open objection (jpk68)

Thread notes: Initial record. jpk68 left a bare ACK with no comments or claims. / Initial record. jpk68 gave an ACK with no rationale or evidence of testing.

Objections, suggestions, and questions: none recorded.

Support:

  • jpk68 (contributor) (ACK, 2026-10-30): (no reason given) [not substantive]

Participants:

  • jpk68 (contributor, support, 1 statements 2026-10-30 to 2026-10-30): bare ACK

Files

100 lines under test/bench/ci.

  • src/test/util/net.cpp +1/-51
  • src/test/util/net.h +2/-46

Card

The short text the ranking pass compares across PRs.

Removes unused helper methods GetNetMsg and PushNetMsg from the DynSock::Pipe test utility, along with associated condition variable synchronization. The methods were originally introduced in PR #30205 to prepare for PR #26812, which was never merged. This is routine dead code removal in the test utility suite.

Data

dossier JSON · extract JSON · model ledger, generated 2026-11-01T01:16, confidence high, input hash 5db64ac72aadfaac
thread read through 2026-10-30 (1 statements), head e172eb69df
labels: Tests

Categories

Test infrastructure

P4 · cleanup

Removes dead test utility helpers and unused synchronization primitives. As noted in the description, this helper code was merged in advance of a PR that never landed, making this a low-priority test framework cleanup.

Membership: Matches the 'Tests' label and modifies test utility framework code in src/test/util/net.cpp and src/test/util/net.h.

Factors: security/stability 0, bug 0, performance 0, user value 0, leverage 0