#36706 policy: remove unused GetVirtualTransactionInputSize

ReviewabilityReviewsAgreementSize
#36706 fanquake policy: remove unused GetVirtualTransactionInputSizeReady2Positive0 + 1 tests
  • Clean up dead code by removing an unused policy helper function
  • Simplifies the policy module after wallet input estimation moved to descriptors
  • Ready to review
  • Approval without stated reasons (jpk68)
  • Tested code review approval with an inline nit (l0rinc)
  • 0 lines added or modified outside tests
  • 1 lines added or modified in tests
  • 14 lines removed in total
  • 4 files, 1 commits
Mempool and policy#14 of 14
P4 · cleanup
  • P4 because it is dead-code cleanup with no behavioral effect on transaction acceptance or relay rules
  • Removes a helper with no production callers, offering minimal impact beyond cleaner code
Ranking notes
Reviewability: ReadyStalePaused
Agreement: StrongPositivePositive w/ caveatsNeutralMildDisputedBlockedCrickets
Reviews: current code-review ACKs, then (+stale ACKs) and -NACKs; greener = more ACKs.
Size: lines added or modified outside tests, then in tests; greener = smaller.

Goal

Removes the unused `GetVirtualTransactionInputSize` helper function from the policy module. It also drops its invocation from the `tx_in` fuzz target and replaces it with direct weight calculation in a wallet unit test.

Problem: `GetVirtualTransactionInputSize` has had no non-test callers since wallet input size estimation was changed to use descriptors in PR #26567, leaving dead code in the policy module.

Evidence of importance:

  • Commit message: "The last non-test caller was removed in 9b7ec393b8 (#26567), when the wallet switched to estimating input sizes using descriptors. Since then it has only been used by the tx_in fuzz target and a helper in wallet_tests."

Risk of a mistake: low (mempool_policy, tests). It deletes an unused helper function and inline declarations with no remaining production callers.

Changed since the previous assessment: No functional changes; diff provided matches the previous description.

Reviewability

Ready

Nothing known that would invalidate a review now.

Waiting on (from the thread read):

  • nothing

Agreement

Positive

support without stated reasons, no open objection (jpk68, l0rinc)

Thread notes: Initial record for PR 36706. l0rinc's inline comment rc:4424827991 is a style/naming nit on wallet_tests and is not tracked as a claim. / Initial record. Two approvals received (l0rinc and jpk68). l0rinc noted an inline nit on wallet_tests.cpp but approved the PR.

Objections, suggestions, and questions: none recorded.

Support:

  • jpk68 (contributor) (ACK, 2026-10-30): (no reason given) [not substantive]
  • l0rinc (member) (ACK, 2026-10-30) [tested]: lightly tested code review [not substantive]

Participants:

  • jpk68 (contributor, support, 1 statements 2026-10-30 to 2026-10-30): ACKed the commit
  • l0rinc (member, support, 2 statements 2026-10-30 to 2026-10-30): approved with a lightly tested code review ACK and noted an inline nit

Files

4 lines under test/bench/ci.

  • src/policy/policy.h +0/-6
  • src/policy/policy.cpp +0/-5
  • src/test/fuzz/tx_in.cpp +0/-2
  • src/wallet/test/wallet_tests.cpp +1/-1

Card

The short text the ranking pass compares across PRs.

Removes the unused GetVirtualTransactionInputSize function from policy code and updates the remaining fuzz and wallet tests. The helper became dead code after wallet input size estimation moved to descriptors in PR #26567. This is a routine internal cleanup with no user-facing or consensus impact.

Data

dossier JSON · extract JSON · model ledger, generated 2026-11-01T01:16, confidence high, input hash 007c9237674889e6
thread read through 2026-10-30 (3 statements), head 3e2cf63da5
labels: TX fees and policy

Categories

Mempool and policy

P4 · cleanup

Removes an unused policy helper function (`GetVirtualTransactionInputSize`) that has had no production callers since PR #26567. As an internal dead-code cleanup with no behavioral effect on acceptance or relay rules, it is low priority.

Membership: Matches the 'TX fees and policy' label and directly modifies policy header and source files in src/policy/.

Factors: security/stability 0, bug 0, performance 0, user value 0, leverage 0